[RESOLVED] Unlink warning

Square1

Hi all:

Getting a "Warning" when trying to unlink:

Here is the code:

			if ($handle = opendir("/home/everycar/public_html/deq/")) {
    			while (false !== ($file = readdir($handle))) { 
					$filelastmodified = filemtime($file);
						//if((time()-$filelastmodified) > 10*24*3600)
						if((time()-$filelastmodified) > 10)//for testing
        					{
							echo $file;	
         					unlink($file);//line 23
						}
					}
    		closedir($handle); 
			}

And here is the warning:

Warning: unlink(..) [function.unlink]: Is a directory in /home/everycar/public_html/deq/deqCreateFile.php on line 23

deqCreateFile.php is the file that the code is written on so there is no directory in deqCreateFile.php. But I don't get how to fix this.

Thanks!

NogDog

"." and ".." will end up in the directory list (current directory and parent directory), so you need to exclude them before trying to delete them.

Weedpacket

You're trying to delete the contents of a directory without first checking whether what you're deleting is a file or a directory. Even an empty directory contains two directories named [font=monospace]..[/font] and [font=monospace].[/font] and your code is failing when it tries to unlink the former.

Edit: what he said; but the case of other subdirectories still applies.

Square1

NogDog;10995475 wrote:
"." and ".." will end up in the directory list (current directory and parent directory), so you need to exclude them before trying to delete them.

Do you mean like:

unlink("home/everycar/public_html/deq/".$file);//line 23

If not I think I lost you.

Weedpacket

No, he means you have to check what the value of $file is first before you try to use it to unlink a file.

NogDog

If you do a directory listing, it will include two directories named "." (single dot) and ".." (double dot), which stand for the current directory and its parent directory, respectively. So as you loop through your opendir() handle via readdir(), you are hitting the ".." directory (the current directory's parent directory) and trying to delete it -- which I'm guessing you don't want to do. You could include an if() condition to skip that "file" in your loop:

while (false !== ($file = readdir($handle))) {
    if($file == '.' or $file == '..') {
        continue;
    }
    // rest of code...
}

Square1

NogDog;10995481 wrote:
If you do a directory listing, it will include two directories named "." (single dot) and ".." (double dot), which stand for the current directory and its parent directory, respectively. So as you loop through your opendir() handle via readdir(), you are hitting the ".." directory (the current directory's parent directory) and trying to delete it -- which I'm guessing you don't want to do. You could include an if() condition to skip that "file" in your loop:
while (false !== ($file = readdir($handle))) {
    if($file == '.' or $file == '..') {
        continue;
    }
    // rest of code...
}

PERFECT. Appreciated!