[RESOLVED] Greater than issue

[Square1]

Hi all:

Should be simple but I am not getting it 😕

Any file older 10 days I would like to be deleted. Right now with the following code, it is ignoring the 10 day requirement and just deleting the file reqardless of days.

			$filelastmodified = filemtime("/home/everycar/public_html/deq/".$file);
			$filedays = (time()-$filelastmodified);

		if($filedays > 60*60*24*10){ unlink("/home/everycar/public_html/deq/".$file); }

Thanks!

[dagon]

I use something like this (and rember diff between file creation and modified time)

if ( filemtime("/home/everycar/public_html/deq/".$file) <= time()-60*60*24*10 ) {
unlink("/home/everycar/public_html/deq/".$file);
}

[Square1]

dagon;10995513 wrote:

I use something like this (and rember diff between file creation and modified time)

if ( filemtime("/home/everycar/public_html/deq/".$file) <= time()-60*60*24*10 ) {
unlink("/home/everycar/public_html/deq/".$file);
}

Thank you but it didn't work. It is still deleting the file instantly upon refreshing the page

[dagon]

do you want to check the modification or creation time ?

[Square1]

dagon;10995515 wrote:

do you want to check the modification or creation time ?

I have checked the time. Every time the page is refreshed the file is deleted and re-created. Below is the delete and create code:

	if ($handle = opendir("/home/everycar/public_html/deq/")) {
    	while (false !== ($file = readdir($handle))) {
    		if($file == '.' or $file == '..') {
     			continue;
    		} 


		if(filemtime("/home/everycar/public_html/deq/".$file) <= time()-60*60*24*10){ unlink("/home/everycar/public_html/deq/".$file); }
	}
	closedir($handle); 
}

$vDelQC	= "/home/everycar/public_html/deq/".$vQCDate.".php";
$vCreateDelQC = fopen($vDelQC, 'w') or die("can't open file");		
fclose($vCreateDelQC);	

[traq]

things you might want to check:

1. if [man]filemtime/man fails, it returns FALSE (which is equivalent to 0 as far as PHP is concerned, so it would definitely be "less than" your ten-day limit).

2. the return value is cached, so if you got it wrong the first time and your test file always has the same filename, you might be using old results each time. look at [man]clearstatcache/man.

3. different OS's have varying degrees of support for this function (mostly Windows problems).

[Square1]

I think I found the problem. It is not the unlink code that is deleting the file, but the create code that is modifying it:

 $vDelQC    = "/home/everycar/public_html/deq/".$vQCDate.".php";
    $vCreateDelQC = fopen($vDelQC, 'w') or die("can't open file");        

    fclose($vCreateDelQC); 

How do I set modify the above code to say "If this file does not exist then create the new file"?

[Derokorian]

Use a different flag for opening see here fopen(). You are currently using

php.net wrote:

'w' Open for writing only; place the file pointer at the beginning of the file and truncate the file to zero length. If the file does not exist, attempt to create it.

If you don't want to worry about contents but rather just skip this command if the file is already there, then you would want to look at file_exists()

[Square1]

Derokorian;10995522 wrote:

Use a different flag for opening see here fopen(). You are currently using If you don't want to worry about contents but rather just skip this command if the file is already there, then you would want to look at file_exists()

BINGO. Changing the flag to "a" did it. Thank you!