need help on array

harkly

I have an array the inputs the user name in a table, however it loops thru all the names and inputs each one into the table. I need help figuring out how to do just the one selected.

I have a list of names which is displayed after it loops thru an array, this list can be endless

John
Jen
Betty

With each name is a link you click to "block" that person from appearing on the list again

Code for that

<input type='hidden' name='block2[]' value='$id' />
<input type='image' value='Block' src='delete.png'  title='Block'>

goes here to be processed

$my_array2 = $_POST['block2'];

if($_POST['block2']){
	$totalIDs = count($my_array2);
	for ( $i=0; $i < $totalIDs; $i++ ) {
		$sql2 = mysql_query("SELECT sender FROM nudges WHERE id='$my_array2[$i]'");
		while($r = mysql_fetch_array($sql2)) {
			$sender=$r['sender'];

		$query2 = ("INSERT INTO blockUser VALUES(NULL,'$clientID','$sender')");
		$result2 = mysql_query($query2) or die(mysql_error());

	} // END while
} // END for
} // END if($_POST['block2'])

However it loops thru every name on the page and inputs that into the db, I know that is does this due to the loop.

My problem is I cannot figure out how to code it to only do the 1 name, you will only be able to click on 1 name at a time.

Please help!

Bonesnap

If you're expecting only one value, why are you using an array? Or maybe I'm completely misunderstanding the problem.

Also, you're checking for $_POST['block2'] after you assign it to another variable. Those steps should be reversed.

harkly

I guess I thought I had to use a variable because when I pass it without one I always get the last name on the list.

I used to have it in a form but it was nested in another form. What other way can I do it?

bradgrafelman

Either wrap each "name" and corresponding image in an individual form (e.g. for n name-image pairs, you'll have n forms with 1 name-image pair per form), or modify the image's values to reflect which one was clicked.

Otherwise, if you're outputting the same value for all of the images, how is anyone (you, PHP, or anyone else for that matter) supposed to know what value "Block" means? In other words, if you look at the image values being paired with each name:

John - Block
Jen - Block
Betty - Block

and I tell you that I clicked on the image whose value was "Block", can you see why it's impossible to discern which name was associated with the image clicked?

Derokorian

Well clearly Brad you wanted to block John.

bradgrafelman

Derokorian;10995704 wrote:
Well clearly Brad you wanted to block John.

Er... I can't tell if you're just adding pointless clutter to the thread, or if my example was misunderstood?

Weedpacket

One way to identify which name was blocked would be name the blocking "link" in such a way that it includes the name (or id) of the person you're blocking.

<input type='image' value='Block' src='delete.png'  title='Block' name='block[<?php echo $id?>]'>

Of course, abusing type="image" inputs as buttons (instead of using actual <button>s) is already a mistake - even before having to deal with the extra complication it causes in the server code.

<button class="block-button" name='block' value='<?php echo $id?>'>

And in the stylesheet

.block-button {
  background-image:url(delete.png);
  border:0;
  width: /* width of image here */
  height: /* height of image here */
}

Further incidental thoughts:

harkly wrote:
this list can be endless

(or at least arbitrarily long).

If the list can get long then it might happen that I want to clean up and block several people at once? In that case having to go through the whole submission process each time could get tedious. I'm picturing a change to the interface: list the names alongside checkboxes. Check however many people I want, and have one delete button to block all of the checked people at once (preferably after confirmation).

The checkboxes would be named 'sender[$id]', and in the processing script $_POST['sender'] would be an array of IDs to block.

Bonesnap

Weedpacket;10995716 wrote:
Of course, abusing type="image" inputs as buttons (instead of using actual <button>s) is already a mistake

Just curious... why is this considered improper? I've only seen it used a few times and never bothered myself (I try to avoid using images when simple CSS will do). Does it violate the HTML spec or something?

bradgrafelman

I'd be curious on your views as well, Weedpacket, especially since the W3C HTML5 spec actually calls such an input an "Image Button".

Weedpacket

Well, mainly because it does complicate server-side processing - not helped by PHP's field-name mangling not playing nice when the name in question involves array subscripts (I think fixing it is in the bug tracker as a "feature request"). Also, <button> elements have values (instead of a pair of coordinates), so you can have several buttons with the same name and different values (which makes looking it up in $_POST easier); and the element also allows additional content such as text to be included.

Plus there's that old principle of separating style from content: we're talking here about a delete button that wants to look like an image, not a server-side image map. Now if the one image input was being used that displayed an image representing all of the options, and the submitted coordinates were used to determine the option clicked on, then that would be different (and even the W3C says probably not better).