getting Parse error..

atnixon

Hi folks...Am new here, and a php newbie and i have run into the following issue when installing some php software on one of my websites...

The error i get on page is...

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting T_STRING or T_VARIABLE or '$' in /root_dir/my_domain/public_html/my_folder/classes/database.php on line 339

I have highlighted in red/bold, line 339.

Have been doing various google searches on this and is stumped..Can anyone shed any light on this please??

( I've had to cut most of the php page code out, as its too big to post here....I've left in a few lines prior to the line in question, and some after...


            $this->compress = true;
        }
        else
        {
            $this->compress = false;
        }
        if ( !openFileToRead( $fname ) )
        {
            return 0;
        }
        $query = "";
        while ( !_eof( ) )
        {
            $line = _gets( );
            $first = substr( $line, 0, 1 );
           if ( !empty( "line" ) && $first != "-" && $first != "" && $first != "#" )
            {
                if ( $replace )
                {
                    $line = str_replace( "PREFIX", $replace, $line );
                }
                if ( oneQueryStr( $line ) )
                {
                    executeQuery( $query );
                    $query = "";
                    $query .= trim( $line );
                }
                else
                {
                    $query .= trim( $line );
                }
                if ( substr( $query, 0 - 1, 1 ) == ";" )
                {
                    $ans = executeQuery( $query );
                    $query = "";
                }
            }
        }
        closeFile( );
        return 1;
    }
}

atnixon

Sorry, the highlighting does not work in php code...doh...here is the line from above..

if ( !empty( "line" ) && $first != "-" && $first != "" && $first != "#" )

Derokorian

See empty()

PHP.net wrote:
Determine whether a variable is considered to be empty.

You are passing a string, not a variable. Perhaps you meant empty( $line ) instead?

atnixon

Derokorian;10996266 wrote:
See empty()
You are passing a string, not a variable. Perhaps you meant empty( $line ) instead?

Hi there...thanks for the reply...

Yes, that was something that i found while researching the error...I tried changing that part to $line ( there are 3 instances of this line ) and it just causes more errors further along in the php file, like after this change, it then errors on line 458, which is...

    if ( empty( "languages" ) )

Anymore insight into this??

Thanks

Derokorian

atnixon;10996282 wrote:
it then errors on line 458, which is...
    if ( empty( "languages" ) )
Anymore insight into this??

Thanks

Same insight as before, you are passing a string as an argument instead of a variable.

atnixon

Derokorian;10996283 wrote:
Same insight as before, you are passing a string as an argument instead of a variable.

As i say, i am total newbie when it comes to php, so, i am not sure what you mean..Its not that has written the php code, i'm just installing it...

Thanks

bradgrafelman

atnixon;10996286 wrote:
Its not that has written the php code, i'm just installing it...

If so, then you should stop, because you're attempting to "install" a PHP application that contains parse errors. You should then probably return to wherever you found this PHP application and look for a working version.

Otherwise, you will be writing it (well, rewriting anyway). Whether or not your changes agree with the original author's intent... well, who knows (hence the above suggestion).

atnixon

Whilst i slightly agree that i should not carry on with the install, i do like to get to the bottom of an issue, rather than just saying stuff it, leave it..

Thanks for the help...

bradgrafelman

atnixon;10996290 wrote:
Whilst i slightly agree that i should not carry on with the install, i do like to get to the bottom of an issue, rather than just saying stuff it, leave it..

Well the problem is that it's hard to say what the "issue" is when you don't know the original intent behind the code.

For example, one might guess that all instances of empty( "name" ) were meant to reference variables whose name is contained in the string, thus the code should instead be empty( $name )... but that's just a guess.

atnixon

bradgrafelman;10996291 wrote:
Well the problem is that it's hard to say what the "issue" is when you don't know the original intent behind the code.

For example, one might guess that all instances of empty( "name" ) were meant to reference variables whose name is contained in the string, thus the code should instead be empty( $name )... but that's just a guess.

If it would make it any easier, i could PM or email the php file so you can see the full code??

Weedpacket

You would be much better off asking whoever it was that wrote this. They would (presumably) be far more qualified to know what it is supposed to be doing.