[RESOLVED] PHP script does not loop through all podcast items if custom function used

[robertjm]

Hi all,

I have a script that takes a podcast xml file and parses out each item's data for inclusion into a MySQL database. I have been having problems populating a field with the subfolder name, and thanks to help here from others successfully wrote a script to parse that subfolder name out of the full path. However, when I added that custom function to my full script, it chokes after the first podcast.

If I comment out the custom function and go back to the entry that leaves the folder info blank, if loops through all four podcasts in my sample file.

What is it that I'm missing? I've tried it both through an inclusion file, as well as pasting the custom function directly into my main script.

Thanks for any help anyone can give me on this!

Robert

Here's the code of my full script:

<?php

// opens $myFile and assigns its content to $theData

$myFile = "Habakkuk.xml"; //PODCAST XML FILE WITH 4 PODCASTS

$fh = fopen($myFile, 'r');
$theData = fread($fh, filesize($myFile));
fclose($fh);

$strCode = $theData;

if (preg_match_all('%<item>.*?</item>%si',$strCode,$regs)) {
        $aryItems = $regs[0];
        foreach($aryItems as $strItem) {
		$strTitle = '';                

		$strDescription = '';
		$entry = '';
           $strLink = '';
		$strGUID = '';
		$strEnclosureURL = '';
		$intEnclosureLength = '';
		$strEnclosureType = '';
           $strPubDate = '';
		$strpubZoneOffset = '';
		$strblockEpisode = 'no';
		$strisClosedCaptioned ='no';
		$aryItuneData = array();

            if (preg_match('%<title>(.*?)</title>%si',$strItem,$regs)) {
                    $strTitle = $regs[1];
            }
            if (preg_match('%<description>(.*?)</description>%si',$strItem,$regs)) {
                    $strDescription = $regs[1];
            }

	if (preg_match('%<link>(.*?)</link>%si',$strItem,$regs)) {

					/* IF THE FUNCTION IS USED THIS STOPS AFTER ONLY ONE PODCAST, NOT FOUR
					function getDirName() {

					$entry = 'http://www.recastweb.com/media/Luke/Luke14_01-14.mp3';
					$path = pathinfo($entry);

					$url=$path['dirname'];

					$folder = parse_url($url, PHP_URL_PATH);


					$entry1 = $folder;
					$path1 = pathinfo($entry1);
					return $path1['basename'];
					}
					$xyz = getDirName();


					// include("return_value.php"); CONTENT OF return_value.php pasted above
					*/

					// IF THIS SECTION IF USED INSTEAD OF ABOVE IT PROCESSES ALL FOUR ITEMS
					$entry = $regs[1];
					$path = pathinfo($entry);
					$string=$path['dirname'];
					$folder = pathinfo($string);


		}

            if (preg_match('%<link>(.*?)</link>%si',$strItem,$regs)) {
                    $strLink = $regs[1];
            }
            if (preg_match('%<guid isPermaLink=\"false\">(.*?)</guid>%si',$strItem,$regs)) {
                    $strGUID = $regs[1];
            }
            if (preg_match('%<pubDate>(.*?)</pubDate>%si',$strItem,$regs)) {
                    $strPubDate = date('D, d M Y H:i:s',strtotime($regs[1]));
            }
            if (preg_match('%<pubDate>(.*?)</pubDate>%si',$strItem,$regs)) {
                    $strpubZoneOffset = date('O',strtotime($regs[1]));
            }





			if (preg_match('%<enclosure url="([^"]*?)" length="([^"]*?)" type="([^"]*?)".*?</enclosure>.%si',$strItem,$regs)) //use for </enclosure>
			{
//				if (preg_match('%<enclosure url="([^"]*?)" length="([^"]*?)" type="([^"]*?)".*?/>.%si',$strItem,$regs)) //use for />
//				{

		 		$strEnclosureURL = $regs[1];
				$intEnclosureLength = (int)$regs[2];
				$strEnclosureType = $regs[3];
			}

            if (preg_match_all('%<itunes:([^>]+)>(.*?)</itunes:\1>%si',$strItem,$regs)) {
                    foreach($regs[2] as $index=>$val) {
                            $aryItuneData[$regs[1][$index]] = $val;
                    }}



            echo "\n=============== ITEM DATA ==============\n <br />";
            echo "Title: $strTitle\n <br />";
	echo "Description: $strDescription\n <br />";
            echo "Link: $strLink\n <br />";
	echo "GUID: $strGUID\n <br />";
	echo "Folder: $xyz\n <br />";
	echo "Enclosure URL: $strEnclosureURL\n <br />";
	echo "Enclosure Size: $intEnclosureLength\n <br />";
	echo "Enclsoure Type: $strEnclosureType\n <br />"; 
            echo "PubDate: $strPubDate\n <br />";
	echo "pubZoneOffset: $strpubZoneOffset\n <br />";
	echo "<br />";
            echo "\n=============== ITUNES DATA ==============\n <br />";

            foreach($aryItuneData as $key=>$val) 
                    echo "\t$key: $val\n <br />";{
		echo "isClosedCaptioned: $strisClosedCaptioned\n <br />";
		echo "blockEpisode: $strblockEpisode\n <br />";}
		echo "------------------------------------------------------\n <br />";

$emptyExplicit = 'no';
$con = mysql_connect("localhost","USER","PASSWORD");

mysql_select_db("podadmin", $con);

// insertion into episodes table

$query = "INSERT INTO import (guid, title, subtitle, keywords, explicit, isClosedCaptioned, author, description, pubdate, pubZoneOffset, blockEpisode, size, duration, folder, filename)";
$query .= "VALUES (";
$query .= "'" . mysql_real_escape_string(basename($strGUID)) . "', " .
      "'" . mysql_real_escape_string($strTitle) . "', " .
          "'" . mysql_real_escape_string($aryItuneData['subtitle'])  . "', " .
      "'" . mysql_real_escape_string($aryItuneData['keywords'])  . "', " .
      "'" . mysql_real_escape_string($emptyExplicit)  . "', " .
      "'" . mysql_real_escape_string($strisClosedCaptioned)  . "', " .
          "'" . mysql_real_escape_string($aryItuneData['author'])  . "', " .
      "'" . mysql_real_escape_string($strDescription)  . "', " .
          "FROM_UNIXTIME('" . strtotime(mysql_real_escape_string($strPubDate))  . "'), " .
          "'" . mysql_real_escape_string($strpubZoneOffset)  . "', " .
          "'" . mysql_real_escape_string($strblockEpisode)  . "', " .
          "'" . mysql_real_escape_string($intEnclosureLength)  . "', " .
          "'" . mysql_real_escape_string($aryItuneData['duration'])  . "', " .
          "'" . mysql_real_escape_string($xyz)  . "', " .
          "'" . mysql_real_escape_string(basename($strLink)) . "')";


if ( ! mysql_query($query) ) {
  exit("Query failed! - $query<Br>" . mysql_error());
}




// CHECKING FOR DUPLICATE GUID ENTRIES IN XML FILE

$emptyExplicit = 'no';
$con = mysql_connect("localhost","USER","PASSWORD");

mysql_select_db("podadmin", $con);

// insertion into guid table

$query = "INSERT INTO guid (guid, filename) ";
$query .= "VALUES (";
$query .= "'" . mysql_real_escape_string(basename($strGUID)) . "', " .
          "'" . mysql_real_escape_string(basename($strLink)) . "')";

if ( ! mysql_query($query) ) {
  exit("Query failed! - $query<Br>" . mysql_error());


 }
}

}

print "<p style='color: green'>Episodes were added.</p>\n";



mysql_close($con);

?>

[bradgrafelman]

Well for one, why on earth are you using regular expressions to read data in a format that is meant to be easily parsed?! There are plenty of options ([man]DOM[/man], [man]SimpleXML[/man], etc.) to read XML files.

Second, why are you trying to define your function inside of an if() statement, which is inside of a loop, which is inside of.... etc. etc.?

Finally, your function itself doesn't really seem very useful, since the $entry is simply a constant string defined inside the function. In other words, all of this:

                        function getDirName() { 

                    $entry = 'http://www.recastweb.com/media/Luke/Luke14_01-14.mp3'; 
                    $path = pathinfo($entry); 

                    $url=$path['dirname']; 

                    $folder = parse_url($url, PHP_URL_PATH); 


                    $entry1 = $folder; 
                    $path1 = pathinfo($entry1); 
                    return $path1['basename']; 
                    } 

might as well just be written as:

function getDirName() {
    return "Luke";
}

since that's all it's doing. I'm guessing you'll want to change $entry from being a simple variable defined inside the function to being a parameter of that function (e.g. so you can pass in different URLs to that function).

[Derokorian]

Also you should have error_reporting set to E_ALL and either display_errors (development) or log_errors (production) turned on. You would then notice attempting to define your function within a loop is what is causing the problem. You should get an error similar to this:

Fatal error: Cannot redeclare getDirName() (previously declared in /path/to/file.php:#) in /path/to/file.php on line #

[robertjm]

Sorry if my logic, or coding, isn't up to snuff. I havn't done anything with PHP in a very long time.

As for why I'm using the constant expression for $entry? I'm using that as a controlled test until I could get the thing to work. I realize if it worked, it would populate the exact same thing within each line of the MySQL database. But, I figured to switch over to reading the actual data out of the mp3 file once the control worked.

The function is inside of a loop because the actual value of $entry will be taken from the XML feed, and won't be static, like the controlled sample is. Each loop goes through the xml file, pulling the data, till it doesn't encounter another <item> reference. The are approximately 200 podcast episodes, spread over about a half dozen different podcasts in the xml file I want to pull data from.

The project came about because I'm trying to modify a script I found online for writing your xml file by pulling info out of an MySQL database. Unfortunately, the script, as was written by the original author, only supports writing one feed, with one directory for the .mp3 files. My goal is to be able to write to different feeds, based on the different .mp3 files, which are stored in different subfolders so my server doesn't have one single media folder all jumbled up.

I had assumed that error handling was on, since I was getting errors if I didn't clean out the MySQL database prior to rerunning the script a second time (GUID is set to unique), but I realize now that those were MySQL errors, not PHP errors. Will turn that back on to see exactly what the error is; and also take a look at DOM and/or SimpleXML, to see if that would be a better option. Like I said before, the last time I was working with PHP, I think it was on version 2, or thereabouts. I can imagine there must've been a lot of changes since then.

Thanks everyone for trying to help.

Robert

bradgrafelman;10996454 wrote:

Well for one, why on earth are you using regular expressions to read data in a format that is meant to be easily parsed?! There are plenty of options ([man]DOM[/man], [man]SimpleXML[/man], etc.) to read XML files.

Second, why are you trying to define your function inside of an if() statement, which is inside of a loop, which is inside of.... etc. etc.?

Finally, your function itself doesn't really seem very useful, since the $entry is simply a constant string defined inside the function. In other words, all of this:

                        function getDirName() { 

                    $entry = 'http://www.recastweb.com/media/Luke/Luke14_01-14.mp3'; 
                    $path = pathinfo($entry); 

                    $url=$path['dirname']; 

                    $folder = parse_url($url, PHP_URL_PATH); 


                    $entry1 = $folder; 
                    $path1 = pathinfo($entry1); 
                    return $path1['basename']; 
                    } 

might as well just be written as:

function getDirName() {
    return "Luke";
}

since that's all it's doing. I'm guessing you'll want to change $entry from being a simple variable defined inside the function to being a parameter of that function (e.g. so you can pass in different URLs to that function).

[robertjm]

Yes, in fact that's pretty much what I got.

Fatal error: Cannot redeclare getDirName() (previously declared in /media/CHATEAU/robertjm/www/podadmin-0.5.1/parsingtext.php:58) in /media/CHATEAU/robertjm/www/podadmin-0.5.1/parsingtext.php on line 56

Derokorian;10996465 wrote:

Also you should have error_reporting set to E_ALL and either display_errors (development) or log_errors (production) turned on. You would then notice attempting to define your function within a loop is what is causing the problem. You should get an error similar to this:

[Derokorian]

Because you should be defining the function outside of the loop and just calling it in the loop:

function foo($bar) {
   return ucfirst(strtolower($bar));
}
$names = array('joHn','ASHLEY','brad','derOKoriAN');
foreach($names as $name) {
   echo foo($name) . '<br>';
}

HTH

[robertjm]

I moved the custom function to the top of my php file (i.e.: outside any of the loops) and now I am not getting the error msg, and "Luke" is populating all four MySQL lines rows in the database.

But, now my issue would be how to feed the custom function with data, based upon the loop, since the custom function is declared prior to the loop, and the $entry =$regs[1] would have no meaning anymore. Sort of like a "which came first, the chicken or the egg" scenario. Right?

Here's what I changed that part of the loop to:

 

if (preg_match('%<link>(.*?)</link>%si',$strItem,$regs)) {

					$entry = $regs[1];
					$xyz = getDirName();

		}
[/php/

[QUOTE=robertjm;10996488]Yes, in fact that's pretty much what I got.

[B][COLOR="Blue"]Fatal error: Cannot redeclare getDirName() (previously declared in /media/CHATEAU/robertjm/www/podadmin-0.5.1/parsingtext.php:58) in /media/CHATEAU/robertjm/www/podadmin-0.5.1/parsingtext.php on line 56[/COLOR][/B][/QUOTE]

[Derokorian]

robertjm;10996493 wrote:

But, now my issue would be how to feed the custom function with data, based upon the loop, since the custom function is declared prior to the loop, and the $entry =$regs[1] would have no meaning anymore. Sort of like a "which came first, the chicken or the egg" scenario. Right?

See my previous post, which shows how to use arguments in a user defined function.

[robertjm]

Looks like you were answering me at the same time I was writing my last post. 😃

Will try it later as I'm out the door right now.

Thanks again,

Robert

Derokorian;10996494 wrote:

See my previous post, which shows how to use arguments in a user defined function.

[bradgrafelman]

robertjm;10996487 wrote:

The function is inside of a loop because the actual value of $entry will be taken from the XML feed, and won't be static, like the controlled sample is.

The point is that you don't simply call the function inside the loop, you're constantly trying to define that function inside the loop, and you can't define a function that shares the same name with another function.

You simply need to define the function once and just call it as many times as you'd like.

EDIT: Oops - didn't see the latest two replies before composing this one.

[robertjm]

I gave up on using the custom function and just placed the functions code directly into the loop.

May not be the prettiest code, but it works.

Thanks everyone for their help.

Robert

		if (preg_match('%<link>(.*?)</link>%si',$strItem,$regs)) {

					$entry = $regs[1];
					$path = pathinfo($entry);
					$url=$path['dirname'];
					$folder = parse_url($url, PHP_URL_PATH);
					$entry1 = $folder;
					$path1 = pathinfo($entry1);
					$xyz = $path1['basename'];
		}

[bradgrafelman]

While it might make more sense now to simply use the code without creating a function for it (especially if this is the only place in the code you would ever need such a function), note that you'll eventually want to learn all about user-defined functions and how they work (it's one of the basic building blocks that more complex concepts/structures expand upon).

Also note that you probably could have reduced the code down to a single line:

$xyz = basename(dirname($regs[1]));

[robertjm]

Certainly true. Such is the case with trying to learn as you go, without starting at the beginning.

bradgrafelman;10996613 wrote:

While it might make more sense now to simply use the code without creating a function for it (especially if this is the only place in the code you would ever need such a function), note that you'll eventually want to learn all about user-defined functions and how they work (it's one of the basic building blocks that more complex concepts/structures expand upon).

Also note that you probably could have reduced the code down to a single line:

$xyz = basename(dirname($regs[1]));