[RESOLVED] Displaying links in rows

[rupertbj]

I've been trying to get links to display in rows of six columns with the following code:

<?php
$max_cols = 6;
$fileCount = 0;
$output = '';
$fileCount++;
$dir = "pictures"; 
$folder = scandir($dir, 0);
$files = array_reverse($folder); 
for( $ctr = 0; $ctr < sizeof( $files ); $ctr++ ) { 
if($files[$ctr] != "." && $files[$ctr] != "..") 
if (sscanf($files[$ctr], '%4d%2d%2d', $year, $month, $day) == 3) { 
    $months = array(1 => 'January', 'February', 'March', 'April', 'May', 'June', 
        'July', 'August', 'September', 'October', 'November', 'December'); 
    $date = "$day  $months[$month] $year"; 


if($fileCount%$max_cols==1)
{
    $output .= "<tr>\n";
}
$output .= "<td align=center><a href='list_pictures.php?pics=$dir/$files[$ctr]'>$date</a></td>";
if($fileCount%$max_cols==0)
{
    $output .= "</tr>\n";
}

if($fileCount%$max_cols!=0)
{
    $output .= "</tr>\n";
}

print " 
                    <table width=38% height=\"115\" border=\"0\" cellpadding=\"\"0 cellspacing=\"4\" bgcolor=\"#000000\">
			        {$output}
                    </table>
";
} 
}
?>

I've tried to adapt code I've used successfully elsewhere, but for some reason it's not displaying how I want, rather in a single column.

Can anyone help me out of the gloom!?

Many thanks,

Rupert

[Derokorian]

$fileCount++; 

That line should be in the loop, to increment on every iteration, instead of just the once before you even start looping.

[rupertbj]

I've done that... but problem still remains... I just want the links to line up in a table, six columns per row. Any ideas?

[Weedpacket]

Look at this bit:

   if($fileCount % $max_cols==0)
    {
        $output .= "</tr>\n";
    }

if($fileCount % $max_cols!=0)
{
    $output .= "</tr>\n";
}

In other words, if $fileCount is a multiple of $max_cols, you end the row; then if $fileCount is not a multiple of $max_cols, you ... end the row.

[rupertbj]

Thanks weedpacket... I see that's not going to help! I removed the second statement.

But now it displays like a christmas tree, and looping:

1
12
123
1234
12345
123456
123456
7
123456
78
123456
789
.
.

i can't figure out why?

[rupertbj]

so this is the current code:

$max_cols = 6;
$fileCount = 0;
$output = '';
$dir = "pictures"; 
$folder = scandir($dir, 0);
$files = array_reverse($folder); 
for( $ctr = 0; $ctr < sizeof( $files ); $ctr++ ) { 
if($files[$ctr] != "." && $files[$ctr] != "..") 
if (sscanf($files[$ctr], '&#37;4d%2d%2d', $year, $month, $day) == 3) { 
    $months = array(1 => 'January', 'February', 'March', 'April', 'May', 'June', 
        'July', 'August', 'September', 'October', 'November', 'December'); 
    $date = "$day  $months[$month] $year"; 

$fileCount++;

if($fileCount%$max_cols==1)
{
    $output .= "<tr>\n";
}
$output .= "<td align=center><a href='list_pictures.php?pics=$dir/$files[$ctr]'>$date</a></td>";
if($fileCount%$max_cols==0)
{
    $output .= "</tr>\n";
}

print " 
                    <table width=38% height=\"115\" border=\"0\" cellpadding=\"\"0 cellspacing=\"4\" bgcolor=\"#000000\">
			        {$output}
                    </table>
";

but it still looks like a christmas tree (as above) and is looping... any ideas?

R

[Derokorian]

That's easy, you have your print line IN the loop, so every time you add a new td you output it, so 1, 1 2, 1 2 3, 1 2 3 4, etc... Basically you're doing this:

<?php

$cols = 6;

$output = '';

for( $i=1; $i<28; $i++ ) {
   if( $i%$cols == 1 ) $output .= '<tr>';
   $output .= '<td>$i</td>';
   if( $i%$cols == 0 ) $output .= '</tr>';

   print "<table>$output</table>";
}

Instead of this:

<?php

$cols = 6;

$output = '';
for( $i=1; $i<28; $i++ ) {
   if( $i%$cols == 1 ) $output .= '<tr>';
   $output .= '<td>$i</td>';
   if( $i%$cols == 0 ) $output .= '</tr>';
}

print "<table>$output</table>";

[rupertbj]

Thanks.... feel like an idiot for all the time spent looking at it!! But one learns from one's mistakes!!
Thank you!