Help with pagination.

[gavin_am]

I am relativly new to php and have trieed to implement a script into my sql querys I can get it to limit the correct numbers I have a feeling it displays the correct amount of pages but when I click over to the next page it does not show any products any ideas? I have included my code as I thought it would make it easier...

<?php



$shopcatid = $_GET['id'];
$shopsubcatid = $_GET['s'];


// How many adjacent pages should be shown on each side?
$adjacents = 3;

/* 
   First get total number of rows in data table. 
   If you have a WHERE clause in your query, make sure you mirror it here.
*/
$query = "SELECT COUNT(*) as num FROM shop_products WHERE shopcatid = '" . $shopcatid . "' AND shopsubcatid = '" . $shopsubcatid . "'";
$total_pages = mysql_fetch_array(mysql_query($query));
$total_pages = $total_pages[num];

/* Setup vars for query. */
$targetpage = "sub-category.php"; 	//your file name  (the name of this file)
$limit = 9; 								//how many items to show per page
$page = $_GET['page'];
if($page) 
	$start = ($page - 1) * $limit; 			//first item to display on this page
else
	$start = 0;								//if no page var is given, set start to 0

/* Get data. */
$sql = "SELECT * FROM shop_products WHERE shopcatid = '" . $shopcatid . "' AND shopsubcatid = '" . $shopsubcatid . "'LIMIT $start, $limit";
$result = mysql_query($sql) or die( "An error has occured: " .mysql_error (). ":" .mysql_errno ());

/* Setup page vars for display. */
if ($page == 0) $page = 1;					//if no page var is given, default to 1.
$prev = $page - 1;							//previous page is page - 1
$next = $page + 1;							//next page is page + 1
$lastpage = ceil($total_pages/$limit);		//lastpage is = total pages / items per page, rounded up.
$lpm1 = $lastpage - 1;						//last page minus 1

/* 
	Now we apply our rules and draw the pagination object. 
	We're actually saving the code to a variable in case we want to draw it more than once.
*/
$pagination = "";
if($lastpage > 1)
{	
	$pagination .= "<div class=\"pagination\">";
	//previous button
	if ($page > 1) 
		$pagination.= "<a href=\"$targetpage?page=$prev\">< previous</a>";
	else
		$pagination.= "<span class=\"disabled\">< previous</span>";	

	//pages	
	if ($lastpage < 7 + ($adjacents * 2))	//not enough pages to bother breaking it up
	{	
		for ($counter = 1; $counter <= $lastpage; $counter++)
		{
			if ($counter == $page)
				$pagination.= "<span class=\"current\">$counter</span>";
			else
				$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
		}
	}
	elseif($lastpage > 5 + ($adjacents * 2))	//enough pages to hide some
	{
		//close to beginning; only hide later pages
		if($page < 1 + ($adjacents * 2))		
		{
			for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
			$pagination.= "...";
			$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
			$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";		
		}
		//in middle; hide some front and some back
		elseif($lastpage - ($adjacents * 2) > $page && $page > ($adjacents * 2))
		{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";
			for ($counter = $page - $adjacents; $counter <= $page + $adjacents; $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
			$pagination.= "...";
			$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
			$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";		
		}
		//close to end; only hide early pages
		else
		{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";
			for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++)
			{
				if ($counter == $page)
					$pagination.= "<span class=\"current\">$counter</span>";
				else
					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";					
			}
		}
	}

	//next button
	if ($page < $counter - 1) 
		$pagination.= "<a href=\"$targetpage?page=$next\">next ></a>";
	else
		$pagination.= "<span class=\"disabled\">next ></span>";
	$pagination.= "</div>\n";		
}
?>

<?php
	while($row = mysql_fetch_array($result))
	{

	// Get an image if we can
	$queryi = "SELECT filename FROM images WHERE productid = '" . $row['productid'] . "'";
	$resulti = mysql_query($queryi) or die( "An error has occured: " .mysql_error (). ":" .mysql_errno ());
	$tweener = mysql_fetch_row($resulti);
	$filename = $tweener[0];

	if ($filename != "")
	{
		// Resize thumbs ready for display

		$image = '<img src="' . $root . 'admin/uploads/thumb_' . $filename . '" alt="' . $row['productname'] . '" height="100" />';
	}
	else
	{
		$image = '<img src="' . $root . 'assets/no-image.jpg" alt="No Image Available" />';
	}

	echo '
	<div class="thumb" style="margin-left:-10px;">
		<div class="img"><a href="' . $root . 'shop/product.php?id=' . $row['productid'] . '">' . $image . '</a></div>
		<a href="' . $root . 'shop/product.php?id=' . $row['productid'] . '" style="color:#903;">' . $row['productname'] . '</a>
	</div>';

	}
?>

  <div class="clear"></div>  

<?php echo $pagination?>

[johanafm]

gavin_am;10996788 wrote:

$shopcatid = $_GET['id'];
$shopsubcatid = $_GET['s'];

Turn on error reporting.

[gavin_am]

But would it not need those to call the subcategory through from the previous page visited?

[gavin_am]

I already have error reprting turned on, I ahd to doble check all the html still appears there is no content on the second page of the pagination though.

[johanafm]

And the URL of the second page looks like?

[Derokorian]

To be a little more blunt, the reason he told you to turn error_reporting on (which should be more specifically to E_ALL) you would notice that the $_GET values for cat and subcat aren't defined, because you didn't include them in your links leading to other pages. You have links basically example.com?page=# but they should be example.com?id=cat&s=subcat&page=#

[gavin_am]

Right it is in russian but you will see what I mean when you look?

http://www.bwear.ru/shop/sub-category.php?id=20&s=49

[johanafm]

And the URL of the second page does indeed look like

http://www.bwear.ru/shop/sub-category.php?page=2

which means that code I quoted results in one error per line.

Add what you need to the url and the errors will go away, as will your problem.

[gavin_am]

So with the risk of sounding dumb here then would this be the place to make the correction?

$targetpage = "sub-category.php";

And if so how would I correct the issue and also can you point me in the right direction of good tutorial so that I can understand it a little better.

[Derokorian]

You could add it there, but you would still have to change all the lines similar to this:

$pagination.= "<a href=\"$targetpage?page=$prev\">< previous</a>";

To change it on target page do (something similar):

$targetpage = 'sub-category.php?id='.$shopcatid.'&s='.$shopsubcatid;

Then all the lines creating links (like the one previously mentioned) would need changed like so:

$pagination.= "<a href=\"$targetpage&page=$prev\">< previous</a>";

HTH

[gavin_am]

You my friend, are a star thank you for your help!!

[johanafm]

Derokorian;10996811 wrote:

$pagination.= "<a href=\"$targetpage&page=$prev\">< previous</a>";

with all & characters replaced by &

$pagination.= "<a href=\"$targetpage&amp;page=$prev\">< previous</a>";

Also make certain that anything you put in the url which comes from the outside world, such as anything coming from $_GET, has to be handled some way to make it safe. In your case, casting the data as int is enough. For string data you should [man]urlencode[/man] it.