[RESOLVED] Help spotting an error in my script

timski72

Hello,

I have written a script to upload a file from my PC to a server via the browser but it is not working as expected. Once I select a file from my PC I am returned to the script as if being executed for the first time. Perhaps I can't see the wood for the trees.

<?php

if (!isset($_POST["submit"]))
{

// Now draw default page
echo "<html>
<meta http-equiv=\"Content-Language\" content=\"bn\">
<meta http-equiv=\"Content-Type\" content=\"text/html;charset=UTF-8\">
<head>
<title>Upload file</title>
</head>
<body>
<form enctype=\"multipart/form-data\" action=\"upload_temp2.php\" method=\"POST\">
 Please choose a file: <input name=\"uploaded\" type=\"file\" /><br />
 <input type=\"submit\" value=\"Upload\" />
 </form> 
</body>
</html>";
} else
{

$target = "Upload/"; 
$target = $target . basename( $_FILES['uploaded']['name']) ;
 if(move_uploaded_file($_FILES['uploaded']['tmp_name'], $target)) 
 {
 echo "The file ". basename( $_FILES['uploadedfile']['name']). " has been uploaded";
 } 
 else {
 echo "Sorry, there was a problem uploading your file.";
 }
	}
?>

Thanks,
Tim.

jeepin81

you've got a couple issues going on here....

1.) you're missing the name attribute for your submit button. That name needs to be 'submit' since that is what you're looking for.

2.) $FILE['uploadedfile'] should be $FILE['uploaded'] since that is what you named that file input tag.

Also, I would get in the habit of indenting your code.... it will make your life a lot easier.

<?php 

if (!isset($_POST["submit"])) 
{ 

  // Now draw default page 
  echo "<html> 
  <meta http-equiv=\"Content-Language\" content=\"bn\"> 
  <meta http-equiv=\"Content-Type\" content=\"text/html;charset=UTF-8\"> 
  <head> 
  <title>Upload file</title> 
  </head> 
  <body> 
  <form enctype=\"multipart/form-data\" action=\"index.php\" method=\"POST\"> 
  Please choose a file: <input name=\"uploaded\" type=\"file\" /><br /> 
  <input type=\"submit\" value=\"Upload\" name=\"submit\"/> 
  </form> 
  </body> 
  </html>"; 
} else 
{ 

  $target = "Upload/"; 
  $target = $target . basename( $_FILES['uploaded']['name']) ; 
  if(move_uploaded_file($_FILES['uploaded']['tmp_name'], $target)) 
  { 
	echo "The file ". basename( $_FILES['uploaded']['name']). " has been uploaded"; 
  } 
  else { 
	echo "Sorry, there was a problem uploading your file."; 
  } 
} 
?>

timski72

Ah thanks.

That's what happens when you chop and change a script too much I suppose :-)