[RESOLVED] Question about tax calculation

[XPS710]

Hi All,

I have an issue with this piece of code right here below, I cant seem to get it to work.

what i would like this peice of code to do is if the user's country is "USA" Charge 13% tax on top of the total which is ['price'] thats also coming from the database, and if not just add price without tax

What getUserData() is getting the user information country from the database

<?php
   $row1 = $user->getUserData(('country'));

 function get_taxed_total($region, $amount){
$region = $row1['country']; 
$amount = $row['price'];
  if ($region = 'USA' ){
    return ($amount * 13 / 100 + 0.0013 );
  };
  if ($region != 'USA'){
    return ( $amount );
  };

}


<input type="hidden" name="a3" value="<?php echo $amount ;?>" />
?>

[cretaceous]

this line is wrong

 if ($region = 'USA' )

that simply assigns $region to become 'USA'

what you want is the equivalence operator ==

 if ($region == 'USA' )

there may be other problems but that one sticks out

[XPS710]

cretaceous;10997616 wrote:

this line is wrong

 if ($region = 'USA' )

that simply assigns $region to become 'USA'

what you want is the equivalence operator ==

 if ($region == 'USA' )

there may be other problems but that one sticks out

Yeah Thanks I noticed that, but Im getting undefined error.
My user country prints as well as my price but cant do the calc hahah😃

[cretaceous]

the idea of a function is that it is self encapsulating so it won't know what external values are (exceptions ignored for now)
so these two lines are wrong within the function:
$region = $row1['country'];
$amount = $row['price'];

(is that correct for price : $row not $row1 ??)

those values should be assigned outside the function and passed in

   

//function can go at top of your code so it's available to be called anywhere

function get_taxed_total($region, $amount){
  if ($region == 'USA' ){
    return ($amount * 13 / 100 + 0.0013 );
  } else {
    return ( $amount );
  }
}

// then way down the script when you need it:

$row1 = $user->getUserData(('country'));
$region = $row1['country'];
$amount = $row['price'];

$mynewamount=get_taxed_total($region, $amount);


 

I'm not sure about the operator precedence of this line:

$amount * 13 / 100 + 0.0013

I'd add brackets on the sub clauses to make it do everything in the required order

[XPS710]

cretaceous;10997619 wrote:

the idea of a function is that it is self encapsulating so it won't know what external values are (exceptions ignored for now)
so these two lines are wrong within the function:
$region = $row1['country'];
$amount = $row['price'];

(is that correct for price : $row not $row1 ??)

those values should be assigned outside the function and passed in

   

//function can go at top of your code so it's available to be called anywhere

function get_taxed_total($region, $amount){
  if ($region == 'USA' ){
    return ($amount * 13 / 100 + 0.0013 );
  } else {
    return ( $amount );
  }
}

// then way down the script when you need it:

$row1 = $user->getUserData(('country'));
$region = $row1['country'];
$amount = $row['price'];

$mynewamount=get_taxed_total($region, $amount);


 

I'm not sure about the operator precedence of this line:

$amount * 13 / 100 + 0.0013

I'd add brackets on the sub clauses to make it do everything in the required order

Hey thanks for spending time on this

Your input helped me to do a bit of tweaking to figure it out.

Thanks very much!! and have a good weekend.😃