[RESOLVED] Upload files

cybereclipse

I am doing a php program that upload files from the browser to the folder on the server. The file does upload but it does not send it to the appropriate folder nor it does not bark any errors at me. I gave the appropriate permissions on the "uploads" folder on the server. Could anyone point out what am I doing wrong with my code? Thanks in advanced! =)


<body>



<?php
//array

print("Uploaded files array:<pre>");  print_r ($_FILES);
 print("</pre><hr />");
     print("POST array:<pre>");  print_r ($_POST);  print("</pre><hr />");
     $target = "uploads/" . $_FILES['my_file']['name'];
     print("We will move " . $_FILES['my_file']['tmp_name'] . " to " .
 $target . "<hr />");
     move_uploaded_file($_FILES['my_file']['tmp_name'],
                        $target);
    print("<form name=\"uploadform\" action=\"" . $_SERVER["PHP_SELF"] .
 "\" method=\"post\" enctype=\"multipart/form-data\">\n");

//upload the files to the files directory 

$Dir = "uploads";
if (isset($_POST['upload'])){
	if (isset($_FILES['my_file'])){
		if(move_uploaded_file(
		$_FILES['my_file']['tmp_name'],
		$Dir . "/" . $_FILES['my_file']
		['name']) == TRUE) {
			chmod($Dir . "/" . $_FILES['my_file']
			['name'], 0644);
			echo "File \"" .
			htmlentities($_FILES['my_file']
			['name']) .
			"\"successfully uploaded.
			<br />\n";
		}
		else 
			echo "There was an error
			uploading \"" .
			htmlentities($_FILES['my_file']
			['name']) . 
			"\".<br />\n";

}
} else {
  print "Looks like we do not have a file.";
}

 ?>


 <p>This program tests the ability to upload a file.</p>
 <form action="QO7.php" method="post" enctype="multipart/form-data">
 <input type="file" name="my_file" />
 <input type="hidden" name="MAX_FILE_SIZE" value="1000" />
 <input type="submit" value="Submit" />
 </form>

</body>

sneakyimp

Your code has lots of problems. For instance, you output the opening <form> tag first using a print statement and then directly at the end of your file.

Then, you check for a $POST value that doesn't correspond to any form input in your form:

if (isset($_POST['upload'])){

You might want to do some more reading on PHP uploads in the docs:
http://us3.php.net/manual/en/features.file-upload.php

cybereclipse

Thanks for the reply, I apologize but I do know understand what am I doing wrong. Could you point out where exactly am I doing wrong? Also, based on what I've learned the $_Files should correspond to the input form.

sneakyimp

The question isn't so much what you've done wrong (and I gave two examples in my post) but what have you done right. Your code doesn't look very complete to me which is why I recommended that you read the documentation. The documentation will have example code you can use.

cybereclipse

The good news is, I went back to my folder and it seems that I have not gave the right permissions as I thought I did. It started to work but I'll def take a look to see what I'm still missing. Thanks for your assistance. =)

sneakyimp

usually, when trying to move files around on your server, the script will need permission to write any locations where files are to be placed. this can in some cases mean apache (which will have different user ids on different systems). some scripts don't run via apache (e.g., via cron or command-line) and the user running them will need the permission.

It's usually a good idea to check with is_writable or is_readable or other such functions before trying to move a file and, if you can't read/write the location in question, then you can output a more specific error so you know what the real problem is. it takes more time to write the code, but that usually pays off when you try to implement the script because it saves you from wondering what went wrong.

bradgrafelman

You could also get the same benefits without having to write any more code at all by setting error_reporting to E_ALL (or better) and logging all PHP errors.