how to get pass on the if variable?

[mark103]

Hi guys,

I have got a problem with the if variable statements. When I insert the text of the image location, the name of the strings and when I did not insert the username, all I get this:

image, strings or username are missing
Username or password are missing.

It should not display with the "Username or password are missing.", only the "image, strings or username are missing". The area of the code i am working on:

    if($image == '' && $strings == '' && $username == '') {
  $errmsg_arr[] = 'image, strings or username are missing';
  $errflag = true;
    } elseif($username  == '' && $password == ''){
  $errmsg_arr[] = 'Username or password are missing.';
  $errflag = true;
    }

<?php
session_start();
    define('DB_HOST', 'localhost');
    define('DB_USER', 'myusername');
    define('DB_PASSWORD', 'mypassword');
    define('DB_DATABASE', 'mydbname');

$errmsg_arr = array();
$errflag = false;

$link = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);
if(!$link) {
  die('Failed to connect to server: ' . mysql_error());
    }

$db = mysql_select_db(DB_DATABASE);
if(!$db) {

die("Unable to select database");
    }

   function clean($var){

return mysql_real_escape_string(strip_tags($var));
    }
    $image = clean($_GET['image']);
    $strings = clean($_GET['strings']);
    $username = clean($_GET['user']);
    $pass = clean($_GET['pass']);
    $delete = clean($_GET['delete']);

if($image == '' && $strings == '' && $username == '') {
  $errmsg_arr[] = 'image, strings or username are missing';
  $errflag = true;
    } elseif($username  == '' && $password == ''){
  $errmsg_arr[] = 'Username or password are missing.';
  $errflag = true;
    }
    if($errflag) {
  $_SESSION['ERRMSG_ARR'] = $errmsg_arr;
  echo implode('<br />',$errmsg_arr);
   }
   else {
$insert = array();
if(isset($_GET['image'])) {
    $insert[] = 'image = \'' . clean($_GET['image']) . '\'';
}
if(isset($_GET['strings'])) {
    $insert[] = 'strings = \'' . clean($_GET['strings']) . '\'';
}
if(isset($_GET['user'])) {
    $insert[] = 'username = \'' . clean($_GET['user']) .'\'';
}
if(isset($_GET['pass'])) {
    $insert[] = 'pass = \'' . clean($_GET['pass']) . '\'';
}
if(isset($_GET['delete'])) {
    $insert[] = 'delete = \'' . clean($_GET['delete']) . '\'';
}

if (count($insert)>0) {
   $names = implode(',',$insert);

if(isset($image) && ($strings) && ($username)) {
    echo "test";
} elseif($username && $delete == 'all') {

   if ($delete != NULL)
   {
  mysql_query("DELETE FROM user_list WHERE username='$username'");
  $deleted = mysql_affected_rows();

  if($deleted > 0) {
  echo("The data are now deleted");
  } else {
  echo("The user's data is empty");
  }
   }else{
  echo("failed");
   } 
   mysql_close($link);
   }
  }
 }
?>

Do anyone know how i can get pass on those methods if I enter the images, the name of the strings and the username or the or the username with the password?

[dagon]

1. separate in to two distinct if statements
2. check in the elseif, the status of the preceding if

[Weedpacket]

mark103's right, though; there shouldn't be both messages - if the first one succeeds, the other one is never tested, let alone found to succeed. I thought at first perhaps it was because the sessioned copy of the array was sitting around accumulating old error messages, but no; it's being replaced (and isn't being used on this page).

One significant problem though, is that [font=monospace]&&[/font] (and) is being used instead of [font=monospace]||[/font] (or). An error message would only be added if all of the corresponding fields were blank instead of any of them.

[dagon]

Weedpacket;10998439 wrote:

mark103's right, though; there shouldn't be both messages

correct, i did not read it to closely. :o

[mark103]

dagon;10998438 wrote:

1. separate in to two distinct if statements
2. check in the elseif, the status of the preceding if

do you mean i have to use something like this?

if($image == '' && $strings == '' && $username == '') {
  $errmsg_arr[] = 'image, strings or username are missing';
  $errflag = true;
    } elseif($username  == '' && $password == ''){
  $errmsg_arr[] = 'Username or password are missing.';
  $errflag = true;
    } 

if so, i have already tried it and when I insert the image, strings and username function, i will always keep getting the "Username or password are missing" when I haven't included the username and password function separate.

Any idea how i can make both functions to make it separate?

[dagon]

i rewrote it to a method i prefer when checking a large number of variables

$check = array('image','strings','username','password');
$errmsg_arr=array();
foreach($check as $c){

if(empty(${$c})){
	$errmsg_arr[] = $c.' is missing';
		}

}

if(count($errmsg_arr)>0){
	$_SESSION['ERRMSG_ARR'] = $errmsg_arr;
	echo implode('<br />',$errmsg_arr);
}

actully i would usually loop through the $GET\$POST array, rather than use variable variables, but i did not want to alter your code to much

[mark103]

That doesn't really helping. I only want to use something like this:

if($image == '' && $strings == '' && $username == '') {
  $errmsg_arr[] = 'image, strings or username are missing';
  $errflag = true;
    } elseif($username  == '' && $password == ''){
  $errmsg_arr[] = 'Username or password are missing.';
  $errflag = true;
    }

i want to check with the array for the images, strings and the username to see if it have been empty or not and also I want to check the array for the username with the password to see if it have been empty or not.

Could you please post a similar code of what I have written?

[Derokorian]

As Weedpacket stated you should use || (or) instead of && (and) if you want to check if ONE of them is empty. These if statements will only evaluate to true if all the tested fields are empty. IE if $image and $strings are both empty but $username is not, then the first if will not evaluate to true. If it helps your current error message should read 'image, strings and username are missing' because you are using && (and) as previously mentioned.