[RESOLVED] Search with pagination where am I going wrong

[darkangel2001lv]

Hey guys, have been trying to get this to work for the better half of the week.
Ok, this is how it works:

User enters a search. Form then searches database field name keyword and link returns the results displays 'link' all that part worked before, now I am so confussed when trying to add pagination, i have read tons of post here and online, can't figure it out. Can someone help?

Org search code that works with out pagination

<?php

require_once ('connection file'); // Connect to the database.
// Set up our error check and result check array
$error = array();
$results = array();

// First check if a form was submitted. 
// Since this is a search we will use $_GET
if (isset($_GET['search'])) {
   $searchTerms = trim($_GET['search']);
   $searchTerms = strip_tags($searchTerms); // remove any html/javascript.

   if (strlen($searchTerms) < 2) {
      $error[] = "Search terms must be longer than 2 characters.";
   }else {
      $searchTermDB = mysql_real_escape_string($searchTerms); // prevent sql injection.
   }

   // If there are no errors, lets get the search going.
   if (count($error) < 1) {
      $searchSQL = "SELECT link, keywords FROM products WHERE ";

  // grab the search types.
  $types = array();
  $types[] = isset($_GET['keywords'])?"`keywords` LIKE '%{$searchTermDB}%'":'';

  $types = array_filter($types, "removeEmpty"); // removes any item that was empty (not checked)

  if (count($types) < 1)
     $types[] = "`keywords` LIKE '%{$searchTermDB}%'"; // use the body as a default search if none are checked

      $andOr = isset($_GET['matchall'])?'AND':'OR';
  $searchSQL .= implode(" {$andOr} ", $types) . " ORDER BY `keywords`"; // order by title.

  $searchResult = mysql_query($searchSQL) or trigger_error("There was an error.<br/>" . mysql_error() . "<br />SQL Was: {$searchSQL}");

  if (mysql_num_rows($searchResult) < 1) {
     $error[] = "The search term provided {$searchTerms} yielded no results.";
  }else {
     $results = array(); // the result array
     $i = 1;
     while ($row = mysql_fetch_assoc($searchResult)) {
        $results[] = " {$row['link']}<br />";

     }
  }
   }
}

function removeEmpty($var) {
   return (!empty($var)); 
}
?>

Search Form:

	<table width="856" height="auto" border="0" cellpadding="0" cellspacing="0"  id="id-form">
		<tr>
			<td align="center" valign="bottom">  <div align="center">
			  <table width="633" border="0">
			    <tr>
			      <td width="627"><div align="center">
			        <div align="center"><?php echo (count($error) > 0)?"The following had errors:<br /><span id=\"error\">" . implode("<br />", $error) . "</span><br /><br />":""; ?>
			          <p><br />
			            </p>
			          </div>
                    <form action="<?php echo $_SERVER['PHP_SELF'];?>" method="get" id="searchForm">
                      <div align="center">
                        <p>
                          <input name="search" type="text" value="<?php echo isset($searchTerms)?htmlspecialchars($searchTerms):''; ?>" size="50" />
                          <input type="submit" name="submit" value="Search" />
                        </p>
                        <p>&nbsp;</p>
                        <p>&nbsp;</p>
                      </div>
                    </form>
                    <div align="center"><?php echo (count($results) > 0)?"Your search: {$searchTerms} returned:<br /><br />" . implode("", $results):""; ?></div>
			      </div></td>
			      </tr>
			    </table>
			</div></tr>

</table>

And now the one i am trying to get working with search and pagination:

<?php




    include('connection file');  // connect to the database
	?>
    <?php
    // number of results to show per page
    $per_page = 6;

   $error = array();
$results = array();

// First check if a form was submitted. 
// Since this is a search we will use $_GET
if (isset($_GET['search'])) {
   $searchTerms = trim($_GET['search']);
   $searchTerms = strip_tags($searchTerms); // remove any html/javascript.

   if (strlen($searchTerms) < 2) {
      $error[] = "Search terms must be longer than 2 characters.";
   }else {
      $searchTermDB = mysql_real_escape_string($searchTerms); // prevent sql injection.
   }

   // If there are no errors, lets get the search going.
   if (count($error) < 1) {
      $searchSQL = "SELECT link, keywords FROM products WHERE ";

  // grab the search types.
  $types = array();
  $types[] = isset($_GET['keywords'])?"`keywords` LIKE '%{$searchTermDB}%'":'';

  $types = array_filter($types, "removeEmpty"); // removes any item that was empty (not checked)

  if (count($types) < 1)
     $types[] = "`keywords` LIKE '%{$searchTermDB}%'"; 

      $andOr = isset($_GET['matchall'])?'AND':'OR';
  $searchSQL .= implode(" {$andOr} ", $types) . " ORDER BY `keywords`"; // order by title.

  $searchResult = mysql_query($searchSQL) or trigger_error("There was an error.<br/>" . mysql_error() . "<br />SQL Was: {$searchSQL}");

  if (mysql_num_rows($result) < 1) {
     $error[] = "The search term provided {$searchTerms} yielded no results.";
  }else {

    $total_results = mysql_num_rows($result);
    $total_pages = ceil($total_results / $per_page);

    // check if the 'page' variable is set in the URL (ex: view-paginated.php?page=1)
    if (isset($_GET['page']) && is_numeric($_GET['page']))
    {
            $show_page = $_GET['page'];

            // make sure the $show_page value is valid
            if ($show_page > 0 && $show_page <= $total_pages)
            {
                    $start = ($show_page -1) * $per_page;
                    $end = $start + $per_page; 
            }
            else
            {
                    // error - show first set of results
                    $start = 0;
                    $end = $per_page; 
            }               
    }
    else
    {
            // if page isn't set, show first set of results
            $start = 0;
            $end = $per_page; 
    }

    // display pagination

    echo "<p><a href='view.php'>View All</a> | <b>View Page:</b> ";
    for ($i = 1; $i <= $total_pages; $i++)
    {
            echo "<a href='view-paginated.php?page=$i'>$i</a> ";
    }
    echo "</p>";

    // display data in table
    echo "<table border='1' cellpadding='10'>";


    // loop through results of database query, displaying them in the table 
    for ($i = $start; $i < $end; $i++)
    {
            // make sure that PHP doesn't try to show results that don't exist
            if ($i == $total_results) { break; }

            // echo out the contents of each row into a table
            echo "<tr>";
            echo '<td>' . mysql_result($result, $i, 'link') . '</td>';

    }
    // close table>
    echo "</table>"; 
  }

   }

 }



function removeEmpty($var) {
   return (!empty($var)); 
}
       ?> 

[johanafm]

You need

• Variable to hold number of entries per page

• Variable to hold current page

• Make use of your DBs LIMIT offset, rowcount

Rowcount is obviously the same as number of entries per page. Offset is obviously (page - 1) rowcount. Thus with
Rowcount: $r
For page 1 you have:
page: 1
Thus: (1 - 1) $r, $r => LIMIT 0, $r

For page 2:
page: 2
Thus: (2 - 1) * $r, $r => LIMIT $r, $r

etc.

Simply start by implementing this and create something like 5 links before and after the current page. If your not certain how to do everything at once, don't worry about having links for page -4, -3 etc when on first page. Just get the links up and see how they work. Once that is done, you can add checks so that you never go above or below the range limits for your data.

The only thing left to do is remember to keep track of the search criteria as well. Your pagination information will (probably) be sent as GET data, since ordinary anchors are the most common implementation. Thus, you'd need to keep passing your search criteria as GET data as well, or store it as SESSION data.

You could obviously also create submit buttons for your pagination (and style them as links if you prefer that look) and keep sending both pagination and search as post data.

However, If you don't allready send the initial search as GET data, I'd recommend keeping pagination as GET data using links and store search criteria as SESSSION data.

[darkangel2001lv]

You need

Variable to hold number of entries per page
Variable to hold current page
Make use of your DBs LIMIT offset, rowcount

Please bear with me I am new to php and don't have the knowledge, but am wanting and willing to learn.

First item on list I need variable to hold number of entries per page. Wouldn't this be what you are saying I need or is it incorrect/ in wrong page.

From Top of script of third Code Block in first post:

    include('connection file');  // connect to the database
    ?>
    <?php
    // number of results to show per page
    $per_page = 6;  <-----------------Variable to hold number of entries per page

   $error = array();
$results = array();

// First check if a form was submitted.
// Since this is a search we will use $_GET
if (isset($_GET['search'])) {
   $searchTerms = trim($_GET['search']);
   $searchTerms = strip_tags($searchTerms); // remove any html/javascript.

Second Variable to hold current page you lost me on that one can you explain?

Third Make use of your DBs LIMIT offset, rowcount, i think i understand this one just not sure where in script to place it

[bradgrafelman]

darkangel2001lv;10998566 wrote:

Second Variable to hold current page you lost me on that one can you explain?

Knowing how many items to display per page is vital, but you also need to know which page you're supposed to be displaying.

If you've got 200 results being returned from the query, and you're displaying 6 per page, you need to pass a "page number" in your pagination links so that you can determine which 6 results to display. For example, if you're passing in "?search=foo&page=3", then you know that the user is requesting the 3rd "page" of results; you'll need to know this in order to determine the "offset" of the LIMIT clause since you want to skip the first 12 results (6 results per page, page 3 = 2 pages beyond the first page of results; offset = 6 results/pg * 2 pages = 12 results).

darkangel2001lv;10998566 wrote:

Third Make use of your DBs LIMIT offset, rowcount, i think i understand this one just not sure where in script to place it

You'd place it wherever you're SELECT'ing the data that you're trying to paginate.

[darkangel2001lv]

ok thanks let me work on that and will post back with outcome

[darkangel2001lv]

Ok been working with code all morning revised most of it however still am having problems
get the following error on page load:\
Parse error: syntax error, unexpected $end in /home/content/84/8829884/html/members/search2.php on line 711

I have searched threads on Parse errors and have checked code but can't find the problem. Am I missing something.

Here is revised code:

<?php

require_once ('connection file'); // Connect to the database.
// Set up our error check and result check array
$error = array();
$results = array();

// First check if a form was submitted. 
// Since this is a search we will use $_GET
if (isset($_GET['search'])) {
   $searchTerms = trim($_GET['search']);
   $searchTerms = strip_tags($searchTerms); // remove any html/javascript.

   if (strlen($searchTerms) < 2) {
      $error[] = "Search terms must be longer than 2 characters.";
   }else {
      $searchTermDB = mysql_real_escape_string($searchTerms); // prevent sql injection.
   }

   // If there are no errors, lets get the search going.
   if (count($error) < 1) {
      $searchSQL = "SELECT link, keywords FROM products WHERE ";

  // grab the search types.
  $types = array();
  $types[] = isset($_GET['keywords'])?"`keywords` LIKE '%{$searchTermDB}%'":'';

  $types = array_filter($types, "removeEmpty"); // removes any item that was empty (not checked)

  if (count($types) < 1)
     $types[] = "`keywords` LIKE '%{$searchTermDB}%'"; // use the body as a default search if none are checked

      $andOr = isset($_GET['matchall'])?'AND':'OR';
  $searchSQL .= implode(" {$andOr} ", $types) . " ORDER BY `keywords`"; // order by keyword.

  $searchResult = mysql_query($searchSQL) or trigger_error("There was an error.<br/>" . mysql_error() . "<br />SQL Was: {$searchSQL}");

  if (mysql_num_rows($searchResult) < 1) {
     $error[] = "The search term provided {$searchTerms} yielded no results.";
  }else {
//Pagination Logic 
$nr = mysql_num_rows($searchResult); // Get total of Num rows from the database query
if (isset($_GET['pn'])) { // Get pn from URL vars if it is present
    $pn = preg_replace('#[^0-9]#i', '', $_GET['pn']); // filter everything but numbers for security(new)
    //$pn = ereg_replace("[^0-9]", "", $_GET['pn']); // filter everything but numbers for security(deprecated)
} else { // If the pn URL variable is not present force it to be value of page number 1
    $pn = 1;
}
//how many database items to show on each page
$itemsPerPage = 5;
// get the value of the last page in the pagination result set
$lastPage = ceil($nr / $itemsPerPage);
//  URL variable $pn(page number) is no lower than page 1 and no higher than $lastpage
if ($pn < 1) { // If it is less than 1
    $pn = 1; // force if to be 1
} else if ($pn > $lastPage) { // if it is greater than $lastpage
    $pn = $lastPage; // force it to be $lastpage's value
}
// This creates the numbers to click in between the next and back buttons
$centerPages = "";
$sub1 = $pn - 1;
$sub2 = $pn - 2;
$add1 = $pn + 1;
$add2 = $pn + 2;
if ($pn == 1) {
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $pn . '</span> &nbsp;';
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $add1 . '">' . $add1 . '</a> &nbsp;';
} else if ($pn == $lastPage) {
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $sub1 . '">' . $sub1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $pn . '</span> &nbsp;';
} else if ($pn > 2 && $pn < ($lastPage - 1)) {
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $sub2 . '">' . $sub2 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $sub1 . '">' . $sub1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $pn . '</span> &nbsp;';
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $add1 . '">' . $add1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $add2 . '">' . $add2 . '</a> &nbsp;';
} else if ($pn > 1 && $pn < $lastPage) {
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $sub1 . '">' . $sub1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $pn . '</span> &nbsp;';
    $centerPages .= '&nbsp; <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $add1 . '">' . $add1 . '</a> &nbsp;';
}
// This line sets the "LIMIT" range... the 2 values we place to choose a range of rows from database in our query
$limit = 'LIMIT ' .($pn - 1) * $itemsPerPage .',' .$itemsPerPage;
// Now we are going to run the same query as above but this time add $limit onto the end of the SQL syntax
// $searchSQL is what I will use to fuel the while loop statement below
$searchSQL  = mysql_query("SELECT keyword, link FROM products ORDER BY keyword ASC $limit");
// end of pagination logic 
//pagination display setup 
$paginationDisplay = ""; // Initialize the pagination output variable
// This code runs only if the last page variable is ot equal to 1, if it is only 1 page we require no paginated links to display
if ($lastPage != "1"){
    // This shows the user what page they are on, and the total number of pages
    $paginationDisplay .= 'Page <strong>' . $pn . '</strong> of ' . $lastPage. '&nbsp;  &nbsp;  &nbsp; ';
    // If we are not on page 1 we can place the Back button
    if ($pn != 1) {
        $previous = $pn - 1;
        $paginationDisplay .=  '&nbsp;  <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $previous . '"> Back</a> ';
    }
    // Lay in the clickable numbers display here between the Back and Next links
    $paginationDisplay .= '<span class="paginationNumbers">' . $centerPages . '</span>';
    // If we are not on the very last page we can place the Next button
    if ($pn != $lastPage) {
        $nextPage = $pn + 1;
        $paginationDisplay .=  '&nbsp;  <a href="' . $_SERVER['PHP_SELF'] . '?pn=' . $nextPage . '"> Next</a> ';
    }
}
// end of pagination display setup 
// Build the Output Section Here
$outputList = '';
while($row = mysql_fetch_array($sql2)){

$id = $row["link"];

} // close while loop
?>

as well as code editor states there is a syntax error on line 695

here is that code:

<div id="step-holder">
		  <div class="step-dark-left">N Fact Search</div>
         <div class="clear"></div>
          <div>

        <div align="center">Please enter your search in the following formats: Item Code (99-999 format) or Handheld Code </div>
      </div>
	<!--  end step-holder -->
<table width="856" height="auto" border="0" cellpadding="0" cellspacing="0"  id="id-form">
	<tr>
		<td align="center" valign="bottom">  <div align="center">
		  <table width="633" border="0">
		    <tr>
		      <td width="627"><div align="center">
		        <div align="center"><?php echo (count($error) > 0)?"The following had errors:<br /><span id=\"error\">" . implode("<br />", $error) . "</span><br /><br />":""; ?>
		          <p><br />
		            </p>
		          </div>
                <form action="<?php echo $_SERVER['PHP_SELF'];?>" method="get" id="searchForm">
                  <div align="center">
                    <p>
                      <input name="search" type="text" value="<?php echo isset($searchTerms)?htmlspecialchars($searchTerms):''; ?>" size="50" />
                      <input type="submit" name="submit" value="Search" />
                    </p>
                    <p>&nbsp;</p>
                    <p>&nbsp;</p>
                  </div>
                </form>
                <p>Total items found: <?php echo $nr; ?></p>
                    <p><span style="margin-left:58px; 
margin-right:58px; 
padding:6px; 
background-color:#FFF; border:#999 1px solid;"><?php echo $paginationDisplay; ?></span></p>
                        <p><span style="margin-left:64px; 
margin-right:64px;"><?php echo "$outputList"; ?></span></p>
                        <p><span style="margin-left:58px;
margin-right:58px; 
padding:6px; 
background-color:#FFF; 
border:#999 1px solid;"><?php echo $paginationDisplay; ?></span></p> <------- syntax error line 578
			      </div></td>
			      </tr>
			    </table>
			</div></tr>

</table>

I Know it has to be something simple but have been looking at it too long need second set of eyes

[bradgrafelman]

You might want to attach this 'search2.php' in whole to your next reply (rename it to have a '.txt' extension so that the forum software doesn't get angry), as it's hard to tell what is or isn't properly closed/terminated in all 711 lines of your code based on the ~115 lines of code in your first code snippet.

For example, going solely based on the first code snippet posted, the '{' braces on lines 11, 22, and 41 appear to be missing a matching '}' brace.

Another problem might be that you have a PHP script with over 700 lines and is in desperate need of reorganization (or organization in the first place? 😉), refactoring, etc. This isn't a problem for the PHP interpreter, but it definitely is for the human trying to manage all of that code.

[darkangel2001lv]

Ok, cleaned up code a bit had a few things left over from earlier attempt that were not doing anything but taking up space the Parse error: syntax error, unexpected $end is now on line 515 (last line ). Also I am getting in my editor a syntax error on line 395.

[bradgrafelman]

Looks like the same problems that I already mentioned above; the '{' opening braces on lines 57, 68, and 87 are never closed.

Part of the problem is your lack of a consistent usage of indentation/whitespace...

i   m p  r  o   perl   y     spac  e d  c    o  de i s ha   rdto   r   ea d!     !         !

(I'd also recommend you consider separating display markup from PHP code, e.g. keeping HTML/CSS/JavaScript/etc. out of your .php files.)

[darkangel2001lv]

ok scrapped the scripts post earlier

Have redone them based results of searching this forum and Google. I think I am on right track. However I am stuck at the last part where it is suppose to display the search results.
In short user enters their search then page is suppose to search keywords field in MySQL and display link field for each match with pagination. Have taken into account all everyone has post I think.. I am still getting an error:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /home/content/84/8829884/html/members/search3.php on line 190

there i know my while statement is not correct, am stuck on how to fix it

Here is the full code hope i cleaned it up enough to be a easy read:

 <?php

require_once ('connection file'); // Connect to the database.

	$tbl_name="products"; //table name

		$adjacents = 3; // How many adjacent pages 


				$query = "SELECT COUNT(*) as num FROM $tbl_name";
					$total_pages = mysql_fetch_array(mysql_query($query));
						$total_pages = $total_pages[num];




/* Setup vars for query. */
					$targetpage = "$_SERVER['PHP_SELF']"';  // <------------------------WANT TO TARGET SAME PAGE NOT SURE IF I HAVE THIS CORRECT GET SYNTAX ERROR THIS LINE
						$limit = 5; //how many items to show per page
							$page = $_GET['page'];
									if($page)
											$start = ($page - 1) * $limit; //first item to display on this page

											else

												$start = 0; //if no page var is given, set start to 0




/* Get data. */

			if ($_POST['search']=="search")
				{
				$keyword=$_POST['keyword'];
						$result=mysql_query("SELECT link, keywords FROM products WHERE keywords LIKE '%$keyword%' OR `url` LIKE '%$keyword%' LIMIT $start, $limit");

									if (mysql_num_rows($searchResult) < 1) {
    										 $error[] = "The search term provided {$searchTerms} yielded no results.";
								  					}else {
    													 $results = array(); // the result array
     															$i = 1;



  }
	}


/* Setup page vars for display. */
								if ($page == 0) $page = 1; //if no page var is given, default to 1.
										$prev = $page - 1; //previous page is page - 1
												$next = $page + 1; //next page is page + 1
														$lastpage = ceil($total_pages/$limit); //lastpage is = total pages / items per page, rounded up.
																$lpm1 = $lastpage - 1; //last page minus 1



/*
 Apply rules and draw the pagination object.
Saving the code to a variable in case need to draw it more than once.
*/
						$pagination = "";
								if($lastpage > 1)
									{
										$pagination .= "<div class=\"pagination\">";







//previous button	
		if ($page > 1)
				$pagination.= "<a href=\"$targetpage?page=$prev\">« previous</a>";

						else

							$pagination.= "<span class=\"disabled\">« previous</span>";









//pages
if ($lastpage < 7 + ($adjacents * 2)) //not enough pages to bother breaking it up
		{
			for ($counter = 1; $counter <= $lastpage; $counter++)
				{
					if ($counter == $page)
							$pagination.= "<span class=\"current\">$counter</span>";
								else
									$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
										}
											}

											elseif($lastpage > 5 + ($adjacents * 2)) //enough pages to hide some
												{






//close to beginning; only hide later pages
if($page < 1 + ($adjacents * 2))
		{
	for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++)
		{
		if ($counter == $page)
			$pagination.= "<span class=\"current\">$counter</span>";

				else

					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
					}
					$pagination.= "...";
					$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
					$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";
					}




//in middle; hide some front and some back
					elseif($lastpage - ($adjacents * 2) > $page && $page > ($adjacents * 2))
						{
						$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
						$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
						$pagination.= "...";

							for ($counter = $page - $adjacents; $counter <= $page + $adjacents; $counter++)
								{
									if ($counter == $page)
										$pagination.= "<span class=\"current\">$counter</span>";

												else

														$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
														}
														$pagination.= "...";
														$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
														$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";
														}



//close to end; only hide early pages
		else

			{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";												

								for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++)
										{
										if ($counter == $page)

											$pagination.= "<span class=\"current\">$counter</span>";

														else

															$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
																						}
																						}
																						}



//next button
				if ($page < $counter - 1)

					$pagination.= "<a href=\"$targetpage?page=$next\">next »</a>";

							else

								$pagination.= "<span class=\"disabled\">next »</span>";
								$pagination.= "</div>\n";
								}
								?>

<?php

 while ($row = mysql_fetch_assoc($results)) {  // <-----------|Know part of problem is this is incorrect
        $results[] = " {$row['link']}<br />";  // <-----------|

}
?>

 <?=$pagination?>

part of code I know is not right:

//next button
				if ($page < $counter - 1)

					$pagination.= "<a href=\"$targetpage?page=$next\">next »</a>";

							else

								$pagination.= "<span class=\"disabled\">next »</span>";
								$pagination.= "</div>\n";
								}
								?>

<?php

 while ($row = mysql_fetch_assoc($results)) {  // <-----------|Know part of problem is this is incorrect This is line 190 where I get syntax error message
                 $results[] = " {$row['link']}<br />";  // <-----------|

}
?>

 <?=$pagination?>

And a side question am I doing this correct?:

/* Setup vars for query. */
					$targetpage = "$_SERVER['PHP_SELF']"  // <------------------------WANT TO TARGET SAME PAGE NOT SURE IF I HAVE THIS CORRECT GET SYNTAX ERROR THIS LINE AS WELL
						$limit = 5; //how many items to show per page
							$page = $_GET['page'];
									if($page)
											$start = ($page - 1) * $limit; //first item to display on this page

											else

												$start = 0; //if no page var is given, set start to 0

[johanafm]

darkangel2001lv;10998627 wrote:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /home/content/84/8829884/html/members/search3.php on line 190

This question has been answered several times on this forum. Each call to [man]mysql_query[/man] returns a result set resource OR boolean false. [man]mysql_fetch_assoc[/man] only ever takes a result set resource argument, never boolean false as the documentation tells you.
Use mysql_errno and mysql_error to see what went wrong.

As for your code, I recommend you read an article about indentation, for example on wikipedia. Choose something, whatever you wish and stick to it. But I would claim that you really need to keep your indentation level at the same depth for all statements belonging to the same block.

Thus

if (true)
# This starts a block
{
	# All statements that belong to that block should be at the same indent depth
	mysql_query();			// Like this one
	mysql_fetch_assoc();	// and this one
		foreach();				// this one is NOT in the correct place

foreach()				// this is where it should be
# new block opened here
{
	# Thus, indent one more level
	etc();
}

}

If you look at your code below, suddenly everything turns red. If you look at the beginning of the code, only string literals are red. Thus, at some point, you turn all (most) the remaining code into a string literal. Find the extra/missing single or double quote to fix it.

/* Setup vars for query. */
					$targetpage = "$_SERVER['PHP_SELF']"';  // <------------------------WANT TO TARGET SAME PAGE NOT SURE IF I HAVE THIS CORRECT GET SYNTAX ERROR THIS LINE
						$limit = 5; //how many items to show per page
							$page = $_GET['page'];
									if($page)
											$start = ($page - 1) * $limit; //first item to display on this page

											else

												$start = 0; //if no page var is given, set start to 0




/* Get data. */

			if ($_POST['search']=="search")
				{
				$keyword=$_POST['keyword'];
						$result=mysql_query("SELECT link, keywords FROM products WHERE keywords LIKE '%$keyword%' OR `url` LIKE '%$keyword%' LIMIT $start, $limit");

									if (mysql_num_rows($searchResult) < 1) {
    										 $error[] = "The search term provided {$searchTerms} yielded no results.";
								  					}else {
    													 $results = array(); // the result array
     															$i = 1;



  }
	}


/* Setup page vars for display. */
								if ($page == 0) $page = 1; //if no page var is given, default to 1.
										$prev = $page - 1; //previous page is page - 1
												$next = $page + 1; //next page is page + 1
														$lastpage = ceil($total_pages/$limit); //lastpage is = total pages / items per page, rounded up.
																$lpm1 = $lastpage - 1; //last page minus 1



/*
 Apply rules and draw the pagination object.
Saving the code to a variable in case need to draw it more than once.
*/
						$pagination = "";
								if($lastpage > 1)
									{
										$pagination .= "<div class=\"pagination\">";







//previous button	
		if ($page > 1)
				$pagination.= "<a href=\"$targetpage?page=$prev\">« previous</a>";

						else

							$pagination.= "<span class=\"disabled\">« previous</span>";









//pages
if ($lastpage < 7 + ($adjacents * 2)) //not enough pages to bother breaking it up
		{
			for ($counter = 1; $counter <= $lastpage; $counter++)
				{
					if ($counter == $page)
							$pagination.= "<span class=\"current\">$counter</span>";
								else
									$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
										}
											}

											elseif($lastpage > 5 + ($adjacents * 2)) //enough pages to hide some
												{






//close to beginning; only hide later pages
if($page < 1 + ($adjacents * 2))
		{
	for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++)
		{
		if ($counter == $page)
			$pagination.= "<span class=\"current\">$counter</span>";

				else

					$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
					}
					$pagination.= "...";
					$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
					$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";
					}




//in middle; hide some front and some back
					elseif($lastpage - ($adjacents * 2) > $page && $page > ($adjacents * 2))
						{
						$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
						$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
						$pagination.= "...";

							for ($counter = $page - $adjacents; $counter <= $page + $adjacents; $counter++)
								{
									if ($counter == $page)
										$pagination.= "<span class=\"current\">$counter</span>";

												else

														$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
														}
														$pagination.= "...";
														$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
														$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";
														}



//close to end; only hide early pages
		else

			{
			$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
			$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
			$pagination.= "...";												

								for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++)
										{
										if ($counter == $page)

											$pagination.= "<span class=\"current\">$counter</span>";

														else

															$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";
																						}
																						}
																						}



//next button
				if ($page < $counter - 1)

					$pagination.= "<a href=\"$targetpage?page=$next\">next »</a>";

							else

								$pagination.= "<span class=\"disabled\">next »</span>";
								$pagination.= "</div>\n";
								}
								?>

<?php

 while ($row = mysql_fetch_assoc($results)) {  // <-----------|Know part of problem is this is incorrect
        $results[] = " {$row['link']}<br />";  // <-----------|

}
?>

 <?=$pagination?>

part of code I know is not right:

//next button
				if ($page < $counter - 1)

					$pagination.= "<a href=\"$targetpage?page=$next\">next »</a>";

							else

								$pagination.= "<span class=\"disabled\">next »</span>";
								$pagination.= "</div>\n";
								}
								?>

<?php

 while ($row = mysql_fetch_assoc($results)) {  // <-----------|Know part of problem is this is incorrect This is line 190 where I get syntax error message
                 $results[] = " {$row['link']}<br />";  // <-----------|

}
?>

 <?=$pagination?>

And a side question am I doing this correct?:

/* Setup vars for query. */
					$targetpage = "$_SERVER['PHP_SELF']"  // <------------------------WANT TO TARGET SAME PAGE NOT SURE IF I HAVE THIS CORRECT GET SYNTAX ERROR THIS LINE AS WELL
						$limit = 5; //how many items to show per page
							$page = $_GET['page'];
									if($page)
											$start = ($page - 1) * $limit; //first item to display on this page

											else

												$start = 0; //if no page var is given, set start to 0