need help with creating download links from server in php

[toufail]

hi I'm new to PHP i am trying to create a link for users so they can download their own file from the server which they have previously uploaded, similarly the way user can delete their own files i need some help, i created a page called download_image.php and download.func.php, but now the problem l am facing is that its not downloading the image i want rather its downloading the page where the code is executed from which is download_image.php

here are my code

download_image.php

<?php
include 'init.php';


if (!logged_in()) {
        header('Location: index.php');
        exit();
}

if (image_check($_GET['image_id']) == false) {
        echo 'stopped at check'; //--  header('Location: albums.php');
        exit();
}

if (isset($_GET['image_id']) || empty($_GET['image_id'])) {
        download_image($_GET['image_id']);
        echo 'stopped at download'; //--  header('Location: '.$_SERVER['HTTP_REFERER']);
        exit();
}

?>

function download_image

    function download_image($image_id)
            {
                    $image_id = (int)$image_id;
                    $image_query=  mysql_query (" SELECT `album_id`, `ext`, FROM `images`  WHERE `image_id`=$image_id AND `user_id`=".$_SESSION['user_id'] );

                $image_result = mysql_fetch_assoc($image_query);
                $album_id =  $image_result['album_id'];
                $image_ext =  $image_result['ext'];

                //$file = $image['id'];        
                //$file = fetch file data from db based off of
                $_GET['image_id'];
                header("Content-Type: application/force-download");
                header('Content-Description: File Transfer');
                readfile($image_id);


        }

😕

Thanks
Toufail

[bradgrafelman]

Welcome to PHPBuilder! When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

As for your issue... what is the purpose of all of this code:

                    $image_query=  mysql_query (" SELECT `album_id`, `ext`, FROM `images`  WHERE `image_id`=$image_id AND `user_id`=".$_SESSION['user_id'] ); 

                $image_result = mysql_fetch_assoc($image_query); 
                $album_id =  $image_result['album_id']; 
                $image_ext =  $image_result['ext']; 

? The reason I ask is because at present, all of it is superfluous and could be removed since you never use any of those variables.

Furthermore... where are the image files stored? Can you give us an example of what values you're passing in via 'image_id' in the query string?