[RESOLVED] Pagination Mostly Works

[rsmith]

I've written pagination before but it's been a long while so I had to use a refresher tutorial. In the end, here's my code:

	// Select correct database and query it
		$db_selected = mysql_select_db("database",$connect);
		if(!$db_selected){
			die("Cannot connect to database: " .mysql_error());
		}else{
			$query = "SELECT * FROM table_name WHERE column = 'x'";

		// Check to see if there is already a page 1
			if(!isset($pagenum)){ 
				$pagenum = 1;
			}

		$result = mysql_query($query);
		$rows = mysql_num_rows($result);
		$page_rows = 4;
		$last = ceil($rows/$page_rows);


		// Pagination information
			if ($pagenum < 1){ 
				$pagenum = 1;
			}elseif($pagenum > $last){
				$pagenum = $last; 
			}

		$max = " LIMIT ".($pagenum - 1) * $page_rows.", ".$page_rows."";
		$query2 = $query.$max;
		$result2 = mysql_query($query2);

	}

And my problem is that it displays the correct number of table rows on the first page but clicking on the links to the subsequent pages yields no results. For example, this query returns 6 results, the first 4 are shown so clicking on the "next" or "last" page links should show the last 2 but they don't. Only the first four remain displayed. 😕

[Derokorian]

How do you create the links? Are you using a query string to represent the page (such as ?page=#)? If so where are you attempting to access this info in this script because I see no reference to the $_GET array.

[rsmith]

I knew I was forgetting something... Here's the chunk that creates the links.

<?php
          	echo "Page ".$pagenum." of ".$last."";
          	echo "&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;";

      	if($pagenum == 1){
		}else{
			echo "<a href='{$_SERVER['PHP_SELF']}?pagenum=1' class='paginationlink'> <<-First</a> ";
			echo " ";
			$previous = $pagenum-1;
			echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$previous' class='paginationlink'> <-Previous</a> ";
		}

		if ($pagenum == $last){
		}else{
			$next = $pagenum+1;
			echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$next' class='paginationlink'>Next -></a> ";
			echo " ";
			echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$last' class='paginationlink'>Last ->></a> ";
		}
      ?>

[Derokorian]

Well my first concern then would be this:

if(!isset($pagenum)){ 
                    $pagenum = 1; 
                }

It seems you are relying on Register Globals which has been deprecated as of 5.3 and removed as of 5.4. You might try changing these 3 lines to this line:

$pagenum = isset($_GET['pagenum']) ? $_GET['pagenum'] : 1;

and see if that fixes the problem. If not post that it didn't help and I'll take a more in depth look.

[rsmith]

Fixed it like a champ!

Thanks man, much appreciated.