[RESOLVED] delete record from MySQL not working.....

darkangel2001lv

Don't know what is going on, need to delete single record from MySQL

<?php require_once('connect file'); ?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  if (PHP_VERSION < 6) {
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  }

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? doubleval($theValue) : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

if ((isset($_POST['delete'])) && ($_POST['delete'] != "remove_system_user")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user_id'], "text"));



  $Result1 = mysql_query($deleteSQL) or die(mysql_error());

  $deleteGoTo = "remove-user-ok.php";
  if (isset($_SERVER['QUERY_STRING'])) {
    $deleteGoTo .= (strpos($deleteGoTo, '?')) ? "&" : "?";
    $deleteGoTo .= $_SERVER['QUERY_STRING'];
  }
  header(sprintf("Location: %s", $deleteGoTo));
}
?>

and the form

<form name="remove_system_user" method="POST" action="<?php echo $editFormAction; ?>">
  	<h5 align="center"><em>Remove  System User</em></h5>
    <h6>First Name:
    <input type='text' name='firstname' id='firstname' />
    <br />
    <br />
    Last Name:
    <input type='text' name='lastname' id='lastname' />
    <br />
    <br />
    Username:
	<input type='text' name='user_id' id='user_id' />
    <br />
    <br/>
    <br />
    </h6>
	<p>&nbsp;</p>
    <input type="image" name="submit" img src="../images/submitactive.gif" alt="button" width="75" height="21">
    <input type="hidden" name="delete" value="remove_system_user">

</form>

bradgrafelman

This part of your outer if() condition:

($_POST['delete'] != "remove_system_user")

is false since your hidden 'delete' element has a value of 'remove_system_user'.

darkangel2001lv

bradgrafelman;10999120 wrote:
This part of your outer if() condition:
($_POST['delete'] != "remove_system_user")
is false since your hidden 'delete' element has a value of 'remove_system_user'.

I am Sorry, I guess I don't understand what you are saying, can you explain?

Have changed this :


if ((isset($_POST['delete'])) && ($_POST['delete'] != "remove_system_user")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user_id'], "text"));

To this:


if ((isset($_POST['delete'])) && ($_POST['delete'] != "")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user_id'], "text"));

but in doing that i now get

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

bradgrafelman

That if() condition will only be true if $_POST['delete'] is not equal to 'remove_system_user.' Since your form above has a hidden input element named 'delete' equal to that same value, the entire contents of that if() statement will never be executed.

darkangel2001lv

bradgrafelman;10999126 wrote:
That if() condition will only be true if $_POST['delete'] is not equal to 'remove_system_user.' Since your form above has a hidden input element named 'delete' equal to that same value, the entire contents of that if() statement will never be executed.

0k so what you are saying is i need to remove that value from 'delete' ? or remove the hidden field delete completely, and change this


if ((isset($_POST['delete'])) && ($_POST['delete'] != "remove_system_user")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user_id'], "text"));

to this :

if ((isset($_POST['remove_system user'])) && ($_POST['remove_system_user'] != "")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user_id'], "text"));

darkangel2001lv

Update:

been working with this the better half of the night,
reworked to code to this :

processing the form:

<?php require_once('connect.php');?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "")
{
  if (PHP_VERSION < 6) {
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  }

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? doubleval($theValue) : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

if ((isset($_POST['removeuser'])) && ($_POST['removeuser'] != "")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user_id'], "text"));



  $Result1 = mysql_query($deleteSQL) or die(mysql_error());

  $deleteGoTo = "remove-user-ok.php";
  if (isset($_SERVER['QUERY_STRING'])) {
    $deleteGoTo .= (strpos($deleteGoTo, '?')) ? "&" : "?";
    $deleteGoTo .= $_SERVER['QUERY_STRING'];
  }
  header(sprintf("Location: %s", $deleteGoTo));
}
?>


<style type="text/css">
body,td,th {
	color: #000;
}
</style>

And the form

<table width="212" border="0">
  <th width="206" align="center" scope="col">
  <form id="removeuser" name="removeuser" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
    <h5 align="center"><em>Remove  System User</em></h5>
    <h6>First Name:
      <input type='text' name="firstname" id='firstname" />
      <br />
      <br />
      Last Name:
  <input type='text' name="lastname" id="lastname" />
  <br />
  <br />
      Username:
  <input type='text' name="user_id" id="user_id" />
  <br />
  <br/>
  <br />
    </h6>
    <p>&nbsp;</p>
    <p>&nbsp;</p>
    <p>
      <input type="image" name="submit" onclick="submit" img="img" src="../images/submitactive.gif" alt="button" width="75" height="21" />
  </p>
</form>
  </table>

No error on page load but when you hit submit the form clears and does nothing.
have tried every thing i can find searching online, this form and the many books i have but nothing works. Am i wasting my time trying to get this script to work or am i missing something simple.
Note: Only need to delete one record at any giving time so this should be simple what am i missing?????

bradgrafelman

This part of your new if() statement:

($_POST['removeuser'] != "")

will never be true because you don't have any form entities named 'removeuser' that are getting POST'ed.

darkangel2001lv

bradgrafelman;10999133 wrote:
This part of your new if() statement:
($_POST['removeuser'] != "")
will never be true because you don't have any form entities named 'removeuser' that are getting POST'ed.

Ok....
changed to this

if ((isset($_POST['user'])) && ($_POST['user'] != "")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user'], "text"));

and now i get :

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
I don't understand how line on is requiring once the MySQL connection file.....

I am sorry, I just understand what you are saying. I get that it is failing due to removeuser was not in fields being posted, however 'user' is. So I changed it to the only field that i have not removed that is being POSTED and still doesn't work....

Full Code:

<?php require_once('connect.php');?>  <----line 1 
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "")
{
  if (PHP_VERSION < 6) {
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  }

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? doubleval($theValue) : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

if ((isset($_POST['user'])) && ($_POST['user'] != "")) {
  $deleteSQL = sprintf("DELETE FROM members WHERE user_id=%s,",
                       GetSQLValueString($_POST['user'], "text"));



  $Result1 = mysql_query($deleteSQL) or die(mysql_error());

  $deleteGoTo = "remove-user-ok.php";
  if (isset($_SERVER['QUERY_STRING'])) {
    $deleteGoTo .= (strpos($deleteGoTo, '?')) ? "&" : "?";
    $deleteGoTo .= $_SERVER['QUERY_STRING'];
  }
  header(sprintf("Location: %s", $deleteGoTo));
}
?> 


<style type="text/css">
body,td,th {
	color: #000;
}
</style>

  <table width="212" border="0">
  <th width="206" align="center" scope="col">
	  <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="POST" >
   		<h5 align="center"><em>Remove  System User</em></h5>
   		<p align="center">&nbsp;</p>
   		<h6>Username:
   		  <input type="text" name="user" id="user" />
     	  </h6>
   	    <h6>&nbsp;</h6>
   	    <h6>&nbsp;</h6>
   	    <h6>
   	      <input type="image" name="submit" onclick="submit" img="img" src="../images/submitactive.gif" alt="button" width="75" height="21" />
   	    </h6>
   	    <p>&nbsp;</p>
        </form>
  </table>

Weedpacket

function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "")
{
  if (PHP_VERSION < 6) {
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  }

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? doubleval($theValue) : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

You know, you wouldn't need to muck around with stuff like this if you used one of the modern MySQL interfaces and their support for prepared statements instead of the old mysql_* one.

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

That error message comes from MySQL, and refers to line 1 of your SQL command, which is apparently

DELETE FROM members WHERE user_id='',

And clearly the comma shouldn't be there.

darkangel2001lv

Weedpacket;10999135 wrote:
You know, you wouldn't need to muck around with stuff like this if you used one of the modern MySQL interfaces and their support for prepared statements instead of the old mysql_* one.

Ok, Modern MYSQL interfaces, what do you mean? there is a easier why than why i am doing it. can you explain?

Currently until i learn PHP mainly better I am using dreamweaver CS5.5, yeah i know it is not the best but its what i have to work with, and i hate it. Any suggestions?

... a single comma really......

thanks Weedpacket i have been pulling my hair out for hrs trying to get this to work....

Weedpacket

http://www.php.net/manual/en/mysqlinfo.api.choosing.php