call_user_func cannot handle with $this?

[volant]

Dear Sir/Madam,
Please find my code below:

class Email
{
    public function __construct()
    {
        $this->EmailFrom 	= "[e-mail]";
        $this->EmailTo 		= "[e-mail]";
        $this->EmailSubject 	= "i am subject";
        $this->EmailBody 	= "*******";
	}

public static function sendEmail()
{
    mail ($this->EmailTo, $this->EmailSubject , $this->EmailBody );
}
}

Then I use call_user_func to send email:

call_user_func("Email::sendEmail");

It shows the error:

Fatal error: Using $this when not in object context in Email.class.php on line X.

My Questions:
1. Is there any possible to allow call_user_func() handle with $this?
2. What are the differences in between:

$email = new Email;
$email->sendEmail();

with the :

call_user_func("Email::sendEmail");

[Weedpacket]

1. [font=monospace]call_user_func(array($email, 'sendEmail'))[/font] if [font=monospace]$email->sendEmail()[/font] isn't good enough for some reason.

2. The latter one is trying to call [font=monospace]sendEmail()[/font] as a static method not associated with any object (and, therefore, nothing for [font=monospace]$this[/font] to refer to, hence the error message).

[traq]

More to the point, your [font=monospace]Email::sendEmail()[/font] method is static - it can't use [font=monospace]$this[/font] at all. It should be using [font=monospace]self[/font] instead - but it will only be able to access static properties (not the regular properties defined by the constructor, specifically because static methods don't run the constructor).

Two choices - Instantiate the class and make [font=monospace]sendEmail()[/font] a regular, public method:

class Email
{
    public function __construct()
    {
        $this->EmailFrom 	= "[e-mail]";
        $this->EmailTo 		= "[e-mail]";
        $this->EmailSubject 	= "i am subject";
        $this->EmailBody 	= "*******";
	}

//  NOTE: _NO_ "static"!
public function sendEmail()
{
    mail ($this->EmailTo, $this->EmailSubject , $this->EmailBody );
}
}
// instantiate an Email object
$Email = new Email();
// call the sendEmail() method
$Email->sendEmail();

or, leave the method static, and make the properties static as well:

class Email
{
    public static $EmailFrom 	= "[e-mail]";
    public static $EmailTo 		= "[e-mail]";
    public static $EmailSubject 	= "i am subject";
    public static $EmailBody 	= "*******";

public static function sendEmail()
{
    mail (self::$EmailTo, self::$EmailSubject , self::$EmailBody );
}
}
// call the static method
Email::sendEmail();

That will solve the Object-Oriented problems you're having, but your mail probably won't be delivered without setting the proper headers - read more on the [man]mail/man function page.

Additionally, I don't see this being terribly useful as-is -- it will only ever send one message, to one recipient. If you are building a wrapper for the mail() function, I'd recommend making it so you can pass parameters (different messages, subjects, and recipients at a minimum) when you call the method.

[volant]

Thanks Weedpacket and traq.

traq, the Email class is a sample to elaborate the problem I faced.
I am going to revise my scripts from:

$obj = new Object; $obj->Function(); 

to:

call_user_func("Class::Function");

Then I found many restrictions and I wonder if I could reduce the modification needed.

Thanks for your guys' suggestion!

[Weedpacket]

volant wrote:

call_user_func("Class::Function");

What's wrong with

Class::Function();

?

[volant]

Weedpacket;10999187 wrote:

What's wrong with

Class::Function();

?

Dear Weedpacket,

I think both are equivalent?

[Weedpacket]

Except that [font=monospace]Class::Function();[/font] is parsed at compile time and [font=monospace]"Class::Function"[/font] is parsed at run time and involves an extra function call?

Even if they were equivalent, why pick the more complicated one?

[traq]

...I'd tend to agree. Unless you have a real need to do this, I think you're over-complicating things.

[ewangeorge77]

What I do is dab my perfume on the outside of my nostrils (good lasting perfume). This makes me smell my own perfume most of the day. You can retouch it whenever you think is necessary. Vicks is medicine smell and you deal with a lot of that, I am sure.