Starter troubles with OOP; no data from Class.

[spookztar]

Hi there,

Been away from coding for a while, but have decided to take it back up again, but also take the opportunity to jump to the OOP side of the river. However, I'm in the water already.

I'm using the following very simple class:

<?php
class LED_kit_generator {

public $ledstrip;

function __construct($led_strips) {
           $this->ledstrip = $led_strips;               
           }


public function set_led_strip($new_strip) {
     $this->ledstrip = $new_strip;
    }
public function get_led_strip() {
    return $this->ledstrip;
    }
}
?>

On data picked up in a separate input file, like so:

<?php
if ($_POST['led_params'] === 'Process') {
    $clean_led_strip = strip_tags(trim($_POST['led_strip']));
    //
    // Invoke an instance of the LED_kit_generator class.
    //
    $led_kit = new LED_kit_generator();
    //
    // Pull the result from the get methods of the class
    //
    echo $led_kit->get_led_strip();
    //
    // The pick-up form
    //
     }    

echo sprintf("<div class='applicationarea'>
         <div class='centertext'><h2 class='hlook1'>LED custom kit generator</h2></div><br />");
         $token = md5(uniqid(rand(), TRUE));
         $_SESSION['token'] = $token;        

         echo sprintf("<form class='form' action={$safeself} method='post'>
                 <fieldset>
                  <legend>LED CUSTOM KIT BUILDER</legend>
                    <select name='led_type'>
                    <option>Steam proof</option>
                    <option>Dry room</option>
                   </select><br />
                    <label>Meters of LED strip: </label><input class='inputfield_colors' type='text' maxlength='3' name='led_strip' size='3' /> 
                    <label>Number of LED sections: </label><input class='inputfield_colors' type='text' maxlength='3' name='led_sections' size='3' />
                    <input type='hidden' name='formtoken' value='%s'>
                   <span><input name='led_params' type='submit' value='Process' /></span>
                  </fieldset>
                 </form>", $token);

//                         

?>

-and I simply cannot get echo $led_kit->get_led_strip(); to produce the integer.

I get the following message, when I hit the form button.

Warning: Missing argument 1 for LED_kit_generator::__construct(), called in /home/jacques/public_html/consultant.php on line 48 and defined in /home/jacques/public_html/classes/LED_kit_generator_test.php on line 6 Notice: Undefined variable: led_strips in /home/jacques/public_html/classes/LED_kit_generator_test.php on line 7

I have strict error reporting on as you can propably tell.

Where does the chain break? Hope you can help get up and running in the OOP world.

Thx.

[spookztar]

Sorry, think I got it:

$led_kit = new LED_kit_generator($clean_led_strip);

Funny, the tutorial I used as reference didn't mention having to pass a variable inside the "new" creator of the object :-(

[Bonesnap]

You will need as many arguments for your constructor as you've defined, so if you have one, like in your code, then you will require one argument. If your constructor requires zero arguments then you need zero. You also need zero if there's no constructor defined at all.

[spookztar]

Still not out of the woods yet, the chain is still breaking I alttered the orignal code a bit, have a look:

if ($_POST['led_params'] === 'Process') { 
    $clean_led_strip = strip_tags(trim($_POST['led_strip']));
    $clean_led_sections = strip_tags(trim($_POST['led_sections']));
    $clean_led_type = $_POST['led_type'];
    //
    // Invoke an instance of the LED_kit_generator class.
    //
    $led_kit = new LED_kit_generator($clean_led_strip, $clean_led_sections, $clean_led_type);
    //
    // Pull the result from the get methods of the class
    //
    echo $led_kit->get_led_strip();
    echo '<br /><br />';
    echo $led_kit->get_led_sections();
    echo '<br /><br />';
    echo $led_kit->get_led_type();

<?php
class LED_kit_generator {

public $ledstrip;
public $ledsections;
public $ledtype;

//////////////////////////////////////////////////////////////////

public function __construct($led_strip, $led_sections, $led_type) {

           $this->ledstrip = $led_strip; 
           $this->ledsections = $led_sections,
           $this->ledtype = $led_type;  

           }
public function set_led_strip($new_ledstrip) {
     $this->ledstrip = $new_ledstrip;
    }


public function get_led_strip() {
    return $this->ledstrip;
    }


public function set_led_sections($new_ledsections) {
    $this->ledsections = $new_ledsections;
    }


public function get_led_sections() {
    return $this->ledsections;
    }


public function set_led_type($new_ledtype) {
    $this->ledtype = $new_ledtype;
    }


public function get_led_type() {
    return $this->ledtype;
    }

}
?>

Fatal error: Call to undefined method LED_kit_generator::get_led_sections() in /home/jacques/public_html/consultant.php on line 54

There's still something about the "hopping back-and-forth" between input file and class that I'm not getting.

[bradgrafelman]

Are you sure you've got this:

    public function get_led_sections() { 
        return $this->ledsections; 
        } 

in your class definition? Perhaps you added it in a later revision but forgot to upload the changes to your remote server?

That's the only thing I can think of that would cause that error message based on the code snippet you provided (since in that code snippet, LED_kit_generator::get_led_sections() is a defined method).

[spookztar]

Thx for responding Brad,

I run a local LAMP, nothing should be missing anywhere.