Openinviter: Write email addresses to database

genista

Hi all,

I am using Openinviter and want to add any email addresses that the user selects to mysql database. right now it is only inserting one email into the database, when I need it to insert all of those selected by the user:

if ($sendMessage===-1)
				{
				$message_footer="\r\n\r\n";
				$message_subject=$_POST['email_box'].$message['subject'];
				$message_body=$message['body'].$message['attachment'].$message_footer; 
				$headers="From: {$_POST['email_box']}";
				foreach ($selected_contacts as $email=>$name)
					mail($email,$message_subject,$message_body,$headers);
				$oks['mails']="Mails sent successfully";
                                $id=$_SESSION['id'];
                                  $query="insert into external_invites (email, id) values ('".$email."', '".$id."')";
                mysql_query($query);

Thanks in advance,

bradgrafelman

You're only executing the SQL query once - after the foreach() loop has finished walking through the $selected_contacts array.

Either execute the SQL query inside the loop (e.g. so that it gets executed for each item in the array), OR better yet, do a bit of [man]implode/man'ing on the array itself to create a single INSERT query in the form of:

INSERT INTO myTable (col1) VALUES ('val1'), ('val2'), ('val3')

genista

ok thanks! I have looked into the implode function and have tried out the following, but 2 things:

It is still writing the first email from the list only.
It is not writing the id to the database either. I need this in order to link the emails against the userid of the person logged in.

I am not sure whether it is $email I should be imploding or $selected_contacts? Or maybe its something else again?

if ($sendMessage===-1)
				{
				$message_footer="\r\n\r\n";
				$message_subject=$_POST['email_box'].$message['subject'];
				$message_body=$message['body'].$message['attachment'].$message_footer; 
				$headers="From: {$_POST['email_box']}";
				foreach ($selected_contacts as $email=>$name)
					mail($email,$message_subject,$message_body,$headers);
				$oks['mails']="Mails sent successfully";
                                //Now lets insert into the database
                                $id=$_SESSION['id'];
                                  $query="insert into external_invites (email, id) values '.implode ($email, ','), ('".$id."')";
                mysql_query($query);

Thanks,

phpSimon

In case bradgrafelman is not online and doesn't respond immediately, a good way to debug this would be to add:

print ($query);

ahead of the mysql_query command.

That way you'll see what the query looks like, which may help.

When getting incorrect results from queries I've found that printing them quite often shows up bugs I hadn't even thought of.

Another handy one (but NOT for production environments) is:

mysql_query($query) or die ('Error:<br />'.$query);

Of course, that'll only display the query if it actually fails.

Weedpacket

$query="insert into external_invites (email, id) values '.implode ($email, ','), ('".$id."')";

You want the implode outside the string where PHP (and the syntax highlighting) can see it; basically, you've got your double and single quotes mixed up.

genista

Thanks Weedpacket and phpSimon,

I have printed both queries (my original and Weedpacket's new one):

$query="insert into external_invites (email, id) values '.implode ($email, ','), ('".$id."')";

insert into external_invites (id, email) values ('1'), '.implode (Array, ',')

This is not inserting anything into the database.

Your help is really appreciated.

Thanks,

johanafm

As you can see, the line starting with $query is coloured red all the way up to $id. Red means it's considered a string literal, and thus is nothing but plain text. You need to terminate the leading string part to be able to execute functions and concatenate their results to the string (missing a double quote)

genista

ok thanks, I am getting there on the query, however the following:

$query = "INSERT INTO `external_invites` (id, email) VALUES ".implode(",",$email)."" ;

Produces the following error:

implode() [function.implode]: Invalid arguments passed

I don't understand why I am getting this error when $email has already been defined (as you can see in the code I started this thread with)??

Thanks again (and for your patience)

Derokorian

Actually, $email is defined as as single key per loop through each element in the $selected_contacts array. Keys can't be arrays, therefore $email will never be an array but rather a single string.

genista

ok, thats a greater pointer. I have run a search and typically implodes are used when trying to push checkbox results into the db.

If my problem is not having an array on email, should I create one or is this creating more work for myself?

Before I start the db insert I could take the line I have:

foreach ($selected_contacts as $email=>$name)

and add a other line with the order changed to:

foreach ($email as $selected_contacts=>$name)

If there is a better way I would love to hear it.

Thanks,

johanafm

Why don't you try things out and inspect your data to get an understanding about what's happening.

foreach ($selected_contacts as $email=>$name)
and add a other line with the order changed to:
foreach ($email as $selected_contacts=>$name)

printf('The selected_contacts array<br/><pre>%s</pre><br/>',
	$selected_contacts
);
foreach ($selected_contacts as $email=>$name)
{
	echo "$email => $name<br/>";
}

printf('The email array<br/><pre>%s</pre><br/>',
	$email
);
foreach ($email as $selected_contacts=>$name)
{
	echo "$selected_contacts => $name<br/>";
}

genista

Thanks, been out for a bit so apologies for delay. I printed out the first suggestion and got the following:

Code you suggested:

printf('The selected_contacts array<br/><pre>%s</pre><br/>',
    $selected_contacts
);
foreach ($selected_contacts as $email=>$name)
{
    echo "$email => $name<br/>";
}

This gave:

The selected_contacts array

Array


me@googlemail.com => Me
wife@yahoo.co.uk => Wife

So this is perfect, I want to write the email addresses and the names to my database.

How do I do this?

Thanks,

genista

anyone?