Directory is created but file uploaded is not stored

seamres

Me again. I'm trying to have an optional image upload. The input name in my form for uploading the file is 'image', but I'm getting the error Undefined index 'image' which is beside $_FILES. The directory is created and all the other data are successfully added to the database, except for the image path.

if(isset($_POST['image']))
{
	//directory where images will be saved
	$target = "uploaded_images/".$_SESSION['idnum']."/";

$pic=$_FILES['image']['$name'];

//creates the directory
if(!is_dir($target))
{
	mkdir($target,0777);
}

$url_image=$target.date("YmdHms").$pic;

if(move_uploaded_file($_FILES['image']['tmp_name'],$url_image))
{
	$sql_query="INSERT INTO order_t(design) VALUES('$url_image')";
	$result=mysql_query($sql_query,$con);

	if($result)
	{
		echo "Successfully added image.<br/>";
	}
	else echo "Error uploading image.";
}
else
{
	echo "Error uploading. Please try again.";
}
mysql_close($con);					
}

bradgrafelman

Few issues:

Can you show us the HTML of the <form> you're working with? Are you sure you set the 'enctype' attribute correctly?
This if() statement:
```
if(isset($_POST['image'])) 
{
```
suggests that you've got a form entity named $_POST['image'], but then you later refer to $FILES['image']. So... which is it? Is the 'image' form entity a file upload or is it some other type of form entity? It can't be both.
```
$pic=$_FILES['image']['$name']; 
```
Entries in the $_FILES array will never have an index named '$name' - perhaps you meant 'name' instead?
The name of this variable:
```
$url_image=$target.date("YmdHms").$pic; 
```
is a bit misleading (read: just plain wrong 😉). URLs are not file paths, and file paths are not URLs. The two have no direct correlation to each other by definition.
You never check the 'error' index to see if the file was actually uploaded successfully before you attempt to process the upload. See [man]features.file-upload.errors[/man] for more information about this error value; at the very least, you should be checking to see if it is equal to the constant UPLOAD_ERR_OK before processing the file upload.
Some of the above issues should be generating PHP error messages, and yet you haven't mentioned any. Either you don't have display_errors (or log_errors, for production environment) set to On and error_reporting set to E_ALL (or better), or you're simply withholding pertinent information to the problem at hand. Neither of those possibilities is a good situation to be in.

seamres

Made a few tweaks. The image is now there but the path is still null.
Oh, and the form.

<form action="success_neworder.php" method="post" enctype="multipart/form-data">
	<table id="contable">
		<tr><th colspan="2">Add Order</th></tr>
		<tr><td>Product and Quantity</td><td>
				<input type="radio" value="Slimfit Shirt" name="prod"/>Slimfit Shirt<select style="float:right" name="qty-slimfit"><option value="0">Select quantity</option><option value="30">30</option><option value="50">50</option><option value="75">75</option><option value="100">100</option><option value="200+">200+</option></select><br/>
				<input type="radio" value="T-Shirt" name="prod"/>T-shirt <select style="float:right" name="qty-tee"><option value="0">Select quantity</option><option value="30">30</option><option value="50">50</option><option value="75">75</option><option value="100">100</option><option value="200+">200+</option></select><br/>
				<input type="radio" value="Polo Shirt" name="prod"/>Polo Shirt <select style="float:right" name="qty-polo"><option value="0">Select quantity</option><option value="30">30</option><option value="50">50</option><option value="75">75</option><option value="100">100</option><option value="200+">200+</option></select><br/>
				<input type="radio" value="Baller" name="prod"/>Baller <select style="float:right" name="qty-baller"><option value="0">Select quantity</option><option value="500">500</option><option value="1000">1000</option></select><br/>
				<input type="radio" value="Lanyard" name="prod"/>Lanyard <select style="float:right" name="qty-lanyard"><option value="0">Select quantity</option><option value="100">100</option></select><br/>					
			</td></tr>	
			<tr><td>Describe your order</td><td><input type="text" name="descr"/></td></tr>
			<tr><td>Upload a Design <small><small>(Optional)</small></small></td><td><input type="file" name="image" value="image"/></td></tr>
			<tr><td><input type="submit" name="add" value="submit"/></td></tr>
		</table>
</form>

Some lines from success_neworder.php

if($total_amount!=0)
			{
				//add order to database
				$query=mysql_query("INSERT INTO order_t(order_desc, prod, prod_qty, total_amount, order_date, cust_id) values('$descr', '$prod', '$qty', $total_amount, CURDATE(), $id)");
				echo "<div id=\"panel\"><table id=\"contable\"><tr><th colspan=\"2\">New order has been added.</th></tr>";
				echo "<tr><td><a href=\"cust_manageorders.php\">Back to Manage Orders</a></td></tr>";			
				echo "</table></div>";

			if(isset($_FILES['image']))
			{
				//directory where images will be saved
				$target = "uploaded_images/".$_SESSION['idnum']."/";

				$pic=$_FILES['image']['name'];

				//creates the directory
				if(!is_dir($target))
				{
					mkdir($target,0777);
				}

				$image_path=$target.date("YmdHms").$pic;

				if(move_uploaded_file($_FILES['image']['tmp_name'],$image_path))
				{
					$sql_query="INSERT INTO order_t(design) VALUES('$image_path') WHERE order_desc='$descr' AND cust_id=$id";
					$result=mysql_query($sql_query,$con);

					if($result)
					{
						echo "<div id=\"panel\"><p>Successfully image.</p></div>";
					}
					else echo "<div id=\"panel\"><p>Error uploading image.</p></div>";
				}
				else
				{
					echo "Error uploading. Please try again.";
				}
				mysql_close($con);					
			}					
		}

I get no error message, except "Error uploading image."
This isn't my code, really, and I don't understand what this statement

if(move_uploaded_file($_FILES['image']['tmp_name'],$image_path))

means at all 😕

Weedpacket

seamres wrote:
I don't understand what this statement
PHP Code:
if(move_uploaded_file($_FILES['image']['tmp_name'],$image_path))
means at all

And that's why the developers of PHP have put together a page describing exactly what [man]move_uploaded_file[/man] means.

I get no error message, except "Error uploading image."

That could be made a bit more informative by including the result of [man]mysql_error[/man] in the message.

But the nature of the error is pretty clear from the query:

INSERT INTO order_t(design) VALUES('$image_path') WHERE order_desc='$descr' AND cust_id=$id

This is meaningless: INSERT commands don't have WHERE clauses. Did you mean to insert values for the "order_desc" and "cust_id" fields as well as "design" (and where do "$descr" and "$id" come from)?