Checkbox problem

boob

Hallo guys,

i want to update my SQL-Table with checkboxes.

If checkbox on write 1 and off write 0.

My Code works but it updates ever the last row in my SQL-Table.
Whats my mistake.

<?php
include("connect.php");

 $sql = "SELECT id, user FROM work";

 $select = mysql_query( $sql ) or trigger_error(mysql_error(),E_USER_ERROR);

if (!isset($_POST['send'])) $_POST['send'] = '';
$status = '';
if ($_POST['send'] == 1) {
    if (is_array($_POST['checkbtn']) == true) {
        $i = 0;
        foreach ($_POST['checkbtn'] as $key => $value) {
            if ($i == 0) $status .= $value;
            else $status .= ''.$value;
            $i++;
        }
        if ($status != '') {
            mysql_query ("UPDATE work SET status='".$status."' WHERE id='".$_POST['id']."'") OR die(mysql_error());
        }
    } else {
        mysql_query ("UPDATE work SET status='0' WHERE id='".$_POST['id']."'") OR die(mysql_error());
    }

} else {
?>
<form action="<? echo htmlspecialchars($_SERVER["SCRIPT_NAME"]);?>" method="post">
<table>
<?PHP
while ($data = mysql_fetch_array( $select ))
{
echo '<tr>';
echo '<td style="width:155px">' . $data['user'] . '</td>';
echo '<td style="width:15px"><input type="hidden" name="send" value="1"></td>';
echo '<td style="width:15px"><input name="checkbtn[]" type="checkbox" value="1"></td>';
echo '<td><input type="hidden" name="id" value="'.$data['id'].'" /></td>';
echo '<td style="width:15px"><input type="submit" value="Send" name="submit"></td>';
echo '<tr>';
}
?>

</table>
</form>
<? } ?>

Thanks for Help

bradgrafelman

What's the point of all of this:

            $i = 0; 
            foreach ($_POST['checkbtn'] as $key => $value) { 
                if ($i == 0) $status .= $value; 
                else $status .= ''.$value; 
                $i++; 
            }

? I only ask, because this:

                if ($i == 0) $status .= $value; 
                else $status .= ''.$value;

is no different than this:

$status .= $value;

which means that the entire foreach() statement (including the superfluous $i counter) could be reduced to this:

$status = implode('', $_POST['checkbtn']);

Next, note that your current form structure prevents you from knowing which checked checkbox corresponds to which "id" value. Unchecked checkboxes are not POST'ed at all, thus if your while() statement loops over 3 rows from your DB, and you only check the box for one of them (let's say the second one), all you're going to see in $_POST['checkbtn'] is this:

Array
(
    [0] => 1
)

What you should do instead is modify your checkbox elements to include the ID value as the array index, e.g.:

<input name="checkbtn[123]" type="checkbox" value="1">

(where 123 is the ID from the database). That way, you would get a more useful array structure in $_POST['checkbtn'] like:

Array
(
    [123] => 1
)

since PHP won't auto-number the checkbox values (as opposed to just using "[]" in the field name).

Also note that your "id" hidden input is completely useless and should be removed. Likewise, your hidden "send" element is useless (since it always contains a constant value) and should also be removed.

boob

Thanks for your help,

The first code is from a tutorial but i changed it.

Now it wrotes 1:ID when i check the checkbox, because when the checkbox is noncheckt it it wrotes 0:

My target is write 0:ID

<?php
include("../php/connect.php");
?>
<html>
<head>
<title>test</title>
</head>
<body>
<?php


 $sql = "SELECT id, user FROM work";

 $select = mysql_query( $sql ) or trigger_error(mysql_error(),E_USER_ERROR);

   if (isset($_REQUEST['checkbtn']))
   {
    foreach ($_REQUEST['checkbtn'] as $value)
    {
     echo "1:$value";
    }
   }
    else
     {
      echo "0:$value";
     }
  ?>
     <form action="<? echo $_SERVER['SCRIPT_NAME']?>" method="post">
    <table>
    <?PHP
    while ($data = mysql_fetch_array( $select ))
    {
    echo '<tr>';
    echo '<td style="width:155px">' . $data['user'] . '</td>';
    echo '<td style="width:15px"><input name="checkbtn[]" type="checkbox" value="'.$data['id'].'"></td>';
    echo '<tr>';
    }
    ?>
    <td style="width:15px"><input type="submit" value="Send" name="submit"></td>
    </table>
    </form>
    </body>
</html>

Thanks