Foreach

[lilRachie]

why isn't this allowed

foreach( ($_POST['Returned'] as $AN => $RET) && ($_POST['2nd'] as $chk => $val) && ($_POST['3rd'] as $chk2 => $val2) ){

do whatever

}

i really need that to work.

lilRachie

[bradgrafelman]

One way:

$idx['Returned'] = array_keys( $_POST['Returned'] );
$idx['2nd'] = array_keys( $_POST['2nd'] );
$idx['3rd'] = array_keys( $_POST['3rd'] );

for(
     $i = 0;
     $i < min( array_map( 'count', $idx ) );
     $i++
   )
    {
    $AN = $idx['Returned'][$i];
    $RET = $_POST['Returned'][$AN];
    $chk = $idx['2nd'][$i];
    $val = $_POST['2nd'][$chk];
    $chk2 = $idx['3rd'][$i];
    $val2 = $_POST['3rd'][$chk2];

// do something
}

[lilRachie]

that looks great fixed a few syntax errors, ran it and got

Warning: array_keys() expects parameter 1 to be array, null given in /home/blah/public_html/blah/blah/insertret.php on line 9

//line 9
$idx['3rd'] = array_keys( $_POST['3rd'] );

[bradgrafelman]

lilRachie;10999558 wrote:

that looks great fixed a few syntax errors

Oops - one too many semicolons. To be honest, I'm surprised there weren't more errors with me posting untested code that late at night. :o

lilRachie;10999558 wrote:

Warning: array_keys() expects parameter 1 to be array, null given in /home/blah/public_html/blah/blah/insertret.php on line 9

//line 9
$idx['3rd'] = array_keys( $_POST['3rd'] );

My code above was meant to serve as a bare-bones example of the type of array operations you might use in order to achieve the type of loop you were after.

It was not meant to be used directly in real code. For example, you should always check to see if external data exists (e.g. by using [man]isset/man or [man]empty/man) before you attempt to access it. Additionally, you might want to use [man]is_array/man as well to verify that the POST'ed elements are indeed arrays as you expect.

[lilRachie]

I appreciate it. 😃

I'll try that and let you know

lilRachie

[Derokorian]

bradgrafelman;10999559 wrote:

Additionally, you might want to use [man]in_array/man as well to verify that the POST'ed elements are indeed arrays as you expect.

I do believe you meant to say [man]is_array/man not in_array() since these test two different things. =D

[lilRachie]

<?
if (isset($_POST["update"])) // if it's not set, do nothing.
{
include('cond.php');


$idx['Returned'] = array_keys( $_POST['Returned'] );
$idx['2nd'] = array_keys( $_POST['2nd'] );
$idx['3rd'] = array_keys( $_POST['3rd'] );

for(
     $i = 0;
     $i < min( array_map( 'count', $idx ) );
     $i++   )
    {
    $AN = $idx['Returned'][$i];
    $RET = $_POST['Returned'][$AN];
    $chk = $idx['2nd'][$i];
    $val = $_POST['2nd'][$chk];
    $chk2 = $idx['3rd'][$i];
    $val2 = $_POST['3rd'][$chk2];


//If date is filled in
if(isset($RET)){

// store it
$doit = "UPDATE `DB`.`table` SET `Returned`= '$RET' WHERE `account_number`='$AN'";
mysql_query($doit) or die('mySQL Error: ' . mysql_error());

}else{

//      	      2nd isn't filled check 3rd
	         if (!isset($Val)) {

//		  3rd is filled in 
		       If(isset($Val2)) {
			print "Third VOR cannot be checked before Second.";
		       }else{
//		       	3rd is not set but 2nd is
	      		if(!isset($Val2)){
				$doit = "UPDATE `DB`.`table` SET `Second`='$Val' WHERE `account_number`='$Chk'";
				mysql_query($doit) or die('mySQL Error: ' . mysql_error());
			}else{
//			2nd and 3rd are set
				$doit = "UPDATE `DB`.`table` SET `Second`='$Val' ,`Third`='$Val2' WHERE `account_number`='$Chk'";
				mysql_query($doit) or die('mySQL Error: ' . mysql_error());
			}//end if 2
		       }//end if
	         }//end if


   } 

}}
?>

none of the above updates are working/updating. and im getting

Warning: array_keys() expects parameter 1 to be array, null given in

still.

lilRachie

[lilRachie]

I may know what the problem is but no idea how to fix it.

 $i = 0; 

isn't 0-whatever it's account numbers

lilRachie

[bradgrafelman]

Few problems with your code:

1. You need to find a style of whitespace/indentation that you like and stick with it...

   im p  r  o  per l   y sp  a c  e   d c o d ei s   h  a   rdt o re ad!    !!

2. You still haven't done anything to address the issue I mentioned in my previous post:

   bradgrafelman;10999559 wrote:

   For example, you should always check to see if external data exists (e.g. by using [man]isset/man or [man]empty/man) before you attempt to access it. Additionally, you might want to use [man]is_array/man as well to verify that the POST'ed elements are indeed arrays as you expect.

3. Your use of [man]isset/man doesn't make any sense. isset() is always going to return true for those variables because they were set at the beginning of the for() loop.

4. You try to use variables named $Val and $Val2, but those are undefined.

5. You never sanitize user-supplied data before placing it into a SQL query string. Not doing so will leave your code vulnerable to SQL injection attacks and/or just plain SQL errors. If you're unfamiliar with the topic of SQL injections, see the manual page [man]security.database.sql-injection[/man] for an introduction.

lilRachie;10999602 wrote:

I may know what the problem is but no idea how to fix it.

 $i = 0; 

isn't 0-whatever it's account numbers

No. $i is being used as a counter variable to access each index of the numerically index array produced as a result of calling [man]array_names/man.

[lilRachie]

<?
if (isset($_POST["update"])) // if it's not set, do nothing.
{
include('cond.php');


$idx['Returned'] = array_keys( $_POST['Returned'] );
$idx['2nd'] = array_keys( $_POST['2nd'] );
$idx['3rd'] = array_keys( $_POST['3rd'] );

for(
     $i = 0;
     $i < min( array_map( 'count', $idx ) );
     $i++   )
    {
    $AN = $idx['Returned'][$i];
    $RET = $_POST['Returned'][$AN];
    $Chk = $idx['2nd'][$i];
    $Val = $_POST['2nd'][$Chk];
    $Chk2 = $idx['3rd'][$i];
    $Val2 = $_POST['3rd'][$Chk2];


//If date is filled in
if(!empty($RET)){

// store it
$doit = "UPDATE `dbname`.`tname` SET `Returned`= '$RET' WHERE `account_number`='$AN'";
mysql_query($doit) or die('mySQL Error: ' . mysql_error());

}else{

//      	      2nd isn't filled check 3rd
	         if (empty($Val)) {

//		  3rd is filled in 
		       If(!empty($Val2)) {
			print "Third VOR cannot be checked before Second.";
		       }else{
//		       	3rd is not set but 2nd is
	      		if(empty($Val2)){
				$doit = "UPDATE `dbname`.`tname` SET `Second`='$Val' WHERE `account_number`='$Chk'";
				mysql_query($doit) or die('mySQL Error: ' . mysql_error());
			}else{
//			2nd and 3rd are set
				$doit = "UPDATE `dbname`.`tname` SET `Second`='$Val' ,`Third`='$Val2' WHERE `account_number`='$Chk'";
				mysql_query($doit) or die('mySQL Error: ' . mysql_error());
			}//end if 2
		       }//end if
	         }//end if


   } 

}}
?>

Ok I used empty/!empty but apparently not in the correct location.

I looked up is_array at http://php.net/manual/en/function.is-array.php but unsure if I can nest it with array_key.

Can you advise location of those things please.

lilRachie