help with inputting new data in database

mr_zo392011

here is the error message.........Warning: mysqli_query() expects parameter 1 to be mysqli, resource given in C:\xampp\htdocs\tutorials\includes\register.php on line 45

<html>
<head>
<title> insert data into db</title>
</head>
<body>


<h1>insert data into db</h1>					



				<form action="register.php" method="post">
				<input type="hidden" name="submitted" value />
				<fieldset>
					<legend>new data</legend>
				<label>username: <input type="text" name = "username" /></label> <br />
				<label>password: <input type="password" name = "password" /></label> <br />
				<input type="submit" name = "submit" value = "register" /> 
				</form>
				</fieldset>

		<?php
		define("NEWDATA", "1 new record added to database");
		?>



<?php
	$database_host = 'localhost';
	$database_username = 'user';
	$database_password = 'pass';
	$database_name = 'registration';



include ('config.php');



if (isset($_POST['submitted'])) {
	$username = $_POST['username'];
	$password = $_POST['password'];
	$sqlinsert = "INSERT INTO users (username, password) VALUES ('$username', '$password')";

	if (!mysqli_query($dbcon, $sqlinsert)) {
		die ('error inserting new data');
	}
echo NEWDATA;

	}
?>

NogDog

I would guess that your config.php file is doing a mysql_connect() (i.e. using the old MySQL extension), while you are then trying to use its return value, in $dbcon, in a mysqli/b call, which is a function from the "improved" MySQLi extension.

bradgrafelman

Welcome to PHPBuilder! When posting PHP code, please use the board's [noparse]

[/noparse] bbcode tags as they make your code much easier to read and analyze.

As for your issue, where is $dbcon defined? Does that code verify that your connection to the MySQL server was successful?

EDIT: Looks like NogDog beat me to it.

Also, note that you might want to remove/obfuscate your DB login credentials the next time you post some code. 😉

mr_zo392011

my config.php code

<?php

$database_host = 'localhost';
$database_username = 'root';
$database_password = 'bigzolilzo8789';
$database_name = 'registration';

$dbcon = mysql_connect($database_host, $database_username, $database_password);
$db = mysql_select_db($database_name);

mysql_query (INSERT INTO users (username, password) VALUES ('$username', '$password') );

bradgrafelman

Two things (both which have already been posted in this thread):

bradgrafelman;10999712 wrote:
note that you might want to remove/obfuscate your DB login credentials the next time you post some code. 😉

NogDog;10999711 wrote:
I would guess that your config.php file is doing a mysql_connect() (i.e. using the old MySQL extension), while you are then trying to use its return value, in $dbcon, in a mysqli/b call, which is a function from the "improved" MySQLi extension.

And to state the last quote a bit differently: You can't mix the [man]mysql[/man] extension with the [man]MySQLi[/man] extension. The two are completely different extensions and their functions can not be used interchangeably.

mr_zo392011

i am going to make another php data in another attempt to send data to my database i would love the help if i need it which im sure i will need it

cybereclipse

<?php

$database_host = 'localhost';
$database_username = 'root';
$database_password = 'bigzolilzo8789';
$database_name = 'registration';

$dbcon = mysql_connect($database_host, $database_username, $database_password);
$db = mysql_select_db($database_name);

mysql_query (INSERT INTO users (username, password) VALUES ('$username', '$password') );

?>

my advice to you is to keep the mysql_connect code separate from your register.php file. Why? Because of security reasons. 😉 Also the file that contains the db info is not accessible from a web browser which can secure more. plus put that db connect file in a folder than the public wwwroot folder.

bradgrafelman

My advice is to not keep the "mysql_connect code" anywhere at all. Why? Because you shouldn't be using any of the mysql_*() functions anyway. The [man]mysql[/man] extension has been deprecated in favor of [man]MySQLi[/man] (or [man]PDO[/man]).

As for the security matters... it's all pretty moot if you post your DB credentials on a public message board (one indexed by all of the major search engines, no less.)

cybereclipse

LOL, I would def agree about posting your db credentials on here. It's like leaving the cell of a jail open.

mr_zo392011

i am very new to php like 3-4 days experience i hope to seek a career in web design and right now am completely self taught i never took into consideration what could happen if i posted my db info into thread but i am full aware now...if there is anyone wiling to help me learn php with current standards because i am using youtube to learn from so i dont know what is dprecated and what is still used