db.php error

[halfcj]

We have added menus onto our website and this automatically adds a 'new item' link in Latest products sidebar. When we select these links, the database appears to hang, and the following message displays:

Fatal error: Maximum execution time of 30 seconds exceeded in /home/electron/public_html/cms/include/db.php on line 91.

The relevant line 91 code is:
($this->queryresult =& mysql_query($q, $this->connection)) or

can anyone help me to see what needs to be done to :
a) make these links work again and
b) recover the 8 hours work entering all the products and menus, which now don't seem to be accessible?

many thanks

[dalecosp]

halfcj;11000005 wrote:

We have added menus onto our website and this automatically adds a 'new item' link in Latest products sidebar. When we select these links, the database appears to hang, and the following message displays:

Fatal error: Maximum execution time of 30 seconds exceeded in /home/electron/public_html/cms/include/db.php on line 91.

The relevant line 91 code is:
($this->queryresult =& mysql_query($q, $this->connection)) or

can anyone help me to see what needs to be done to :
a) make these links work again and
b) recover the 8 hours work entering all the products and menus, which now don't seem to be accessible?

many thanks

I'm guessing there's a line above this, or several lines, in which a value is assigned to $q? For example:

$q="select id, title, description,brand from products where online=1";

// OR, Maybe:

$q="SELECT ".$this->somevariable." from ".something::atable
   "WHERE ".$conditions;

// etc.

If you can piece together what the query is and tell us something about your system hardware, that might help; otherwise, we might need to see a lot more code.

The error message you've posted, as it indicates, merely shows that the program is either requesting something that's either impossibly large, or just plain impossible, to get. It's actually the sort of error you'd receive if you created an endless control loop. Not good ;-) PHP sets a limit on how long a script can run to avoid bringing your server to its knees if you do something dumb like that.

Which I have done 😃

[dalecosp]

Oh, and:

1. Welcome to PHPBuilder 🙂

and

2. Don't give up hope on your data completely. There are ways - most of the time.

[halfcj]

Thank you. swimming way out of my depth!

Not sure I see anything like you suggest should be there.
The previous lines of code are:

 Constructs a new Db object, connects to the db server and
  selects the desired database.

*/
function Db($DB_HOST, $DB_USER, $DB_PASSWD, $DB_DBNAME, $oe = 'report')
{

	$this->on_error = $oe;

    	$this->server = $DB_HOST;
    	$this->dbname = $DB_DBNAME;
    	$this->user = $DB_USER;
    	$this->password = $DB_PASSWD;
    	$this->limit = $GLOBALS['LIMIT'];
    	$this->show_pages_number = 1;
    	$this->number_type == 'number';
    	$this->qcounter = 0;

	$this->connect();

}

function connect($server='', $user='', $password='', $dbname='')
{
	if ($server)
	{
		$this->server = $server;
		$this->dbname = $user;
		$this->user = $password;
		$this->password = $dbname;
	}

    $this->connection = @mysql_connect( $this->server, $this->user, $this->password )
        or $this->error( "could not connect to the database server ($this->server, $this->user)." );

    @mysql_select_db( $this->dbname )
        or $this->error( "could not select the database ($this->DB)." );

}

/*!
	executes query, returns query result handle
*/
function &query($q, $print = false)
{
	if ($print) { echo "<br/><b>query: </b>" . htmlentities($q) . "<br/>";}

($this->queryresult =& mysql_query($q, $this->connection)) or

followed by:

	$this->error("<b>bad SQL query</b>: " . htmlentities($q) . "<br/><b>". mysql_error() ."</b>");

	$this->qcounter++;
	$this->qall[] = $q;
	return $this->queryresult;
}

Not sure if this helps?

[dalecosp]

Well, it doesn't help a lot, but it's somewhat interesting.

If this server isn't in production, or if you don't care if people see this (I would unless the business is very much at stake), change "false" to "true" here:

function &query($q, $print = false)

and let's see the query(s). You can change it back real quick ;-)

Incidentally, the problem is more than likely in another file. Which file are you accessing when this error occurs? It's calling the "db.php" file ... possibly more often than it should, I'd think.

[halfcj]

Unfortunately, this is a live site! It was my client who was updating a menu and adding new product (he's in catering) when everything disappeared! His clients book online for lunches etc., every day!

So can really run the risk of taking the whole site down, as the problem lies with the new spring menu which is not effective for another week.

My problem is, the developers I used for this site (they built a CMS for me years ago too, which this site runs on) got paid and promptly went out of business...to re-emerge out of the embers as someone else...if you know what I mean.

Left me with a number of problems, but this one is an immediate 'required-to-solve' before the site goes live.

I feel I need to focus on finding the data that has been input during the day, as time is not on our side and I have posted a new menu and product myself and is working perfectly for that. So the code must be OK.

I'm a bit lost in the jungle right now!

[johanafm]

Change it to

function &query($q, $log = false)
{
	if ($log)
	{
		error_log(sprintf('Query:%s%s%S', PHP_EOL, $q, PHP_EOL));
		);
	}