[RESOLVED] Upload files and special characters problem

xamonix

Hi,
I've got a script to upload images by users. What happens is users usually put special characters on filename like "ç" and "ã". When they do so the filename on server gets weird like this "canóú.jpg". I would like to have some help on this script to remove this special charactres from filename on upload.
Here is the script I got:

//Send Images

$userfile2=(isset($_FILES['userfile']['tmp_name']) ? $_FILES['userfile']['tmp_name'] : "");
$userfile_name=(isset($_FILES['userfile']['name']) ? $_FILES['userfile']['name'] : "");
$imagesize = $_FILES['userfile']['size'];

if (( $imageenabled == 2 ) || ( ($imageenabled == 1) && (!empty($userfile_name)) ) ) {
$base_Dir = ELPATH.'/images/eventlist/events/';
$sizelimit = $sizelimit*1024; //size limit in kb

if ($imagesize > $sizelimit) {
mosRedirect("index.php?option=$option&Itemid=$Itemid", "Image too big"." ");
}

if (!move_uploaded_file ($_FILES['userfile']['tmp_name'],$base_Dir.$_FILES['userfile']['name']) || !mosChmod($base_Dir.$_FILES['userfile']['name'])) {
mosRedirect("index.php?option=$option&Itemid=$Itemid", _EVENTS_IMAGEFAIL." ");
} else {
$file = $base_Dir.$userfile_name;
//chmod Bild
@chmod ($file, octdec($imagechmod));
//Vorbereiten auf Thumbnailerstellung
$thumbdir = $base_Dir.'small/';
$save = $thumbdir.$userfile_name ;
if ($imageprob = 1) {
$imageprob = TRUE;
} else {
$imageprob = FALSE;
}
if ($gddisabled == 1) {
evlist_imgd::thumb($file, $save, $imagewidth, $imagehight, $imageprob);
}
}
$_POST['datimage'] = $userfile_name ;
}

Thank you for your time!

Ashley_Sheridan

First of all, it's not particularly safe to let users choose the filenames of things they upload. What happens if two users upload a file with the same name, or one user uploads 2 with the same name and the files get overwritten?

Also, what is with your changing the permissions on the file the user has just uploaded? Your web server will have read/write permissions on it anyway.

It's considered a better practice to save the files with the temp name (or something else which can be considered uniquely random) and store a reference to it in the DB (which is where I am assuming the other event information is stored?)

xamonix

OK OK! I agree but tell me how to do it. That kind of answers are useless if you don't tell me how to do it or point me a link to do it. It´s like I tell you how to build a house "you have to digg foundations and then build the walls, and finally cover the whole thing with a roof" but as you can see this in not enough to get your house done. You must know how to digg foundations, build walls, etc...

Ashley_Sheridan

What bit did you need me to tell you how to do? My last post outlined the steps you'd need to take.

xamonix

For example put here a piece of code to avoid uploading files with the same name or point me a link to get it. I'm not a programmer and there are a lot of "codes" I can find on the Internet to do that, but of course not all of them fit my needs. Are you getting my point?

As you figured it out already, my code was taken from the Net, and as far as I can see this is not the best code!

I assume that for you guys that know a lot more about PHP than me or any other begginer it's not difficult to help by posting the right piece of code (most of times it's just a matter of COPY/PASTE) or point a link where to find it.

Thank you for your time.

Derokorian

Handling File uploads

Generally if you want help its best to show what you've tried and say why its not working (IE what do you expect, what actually happens, steps to recreate the problem). No one here is going to spoon feed you all the code you need to make something work. However we will gladly help solve problems you face when trying to do it on your own.

A common practice for naming uploads is to use timestamp plus an identifier for the uploader. Something like:

$filename = md5($_SESSION['username'] . time()) . '.' . pathinfo($_FILES['fieldname']['name'], PATHINFO_EXTENSION);

Then you just use $filename instead of $_FILES['fieldname']['name'] when calling move_uploaded_file.

Then inserting this into a database is no different than inserting any other data into a DB. You connect to the database, like with [man]mysqli_connect[/man] then you execute an insert query you make, such as with [man]mysqli_query[/man].

xamonix

Thanks, This way it's much more simple and objective.
I'll try it and post her my feedback.

bradgrafelman

xamonix;11000213 wrote:
I'm not a programmer

Then why are you trying to do the same job as one?

xamonix;11000213 wrote:
and there are a lot of "codes" I can find on the Internet to do that, but of course not all of them fit my needs. Are you getting my point?

I think I am getting your point, yes. (Your point is you need to hire a programmer, right?)

xamonix;11000213 wrote:
As you figured it out already, my code was taken from the Net, and as far as I can see this is not the best code!

So not only are we supposed to have already done all of your work for you (minus the copying and pasting part - sounds like you've got that down), but we were also supposed to be psychic and know that you don't really understand the code you posted and that you simply copied it from elsewhere?

I'm afraid our resident psychic is on vacation - sorry about that.

xamonix;11000213 wrote:
I assume that for you guys that know a lot more about PHP than me or any other begginer it's not difficult to help by posting the right piece of code

Actually it is difficult, because that doesn't help anyone learn anything at all. PHPBuilder doesn't exist to supply free work for non-programmers - it exists to build the skills of other programmers (of any skill level... other than 'none' I suppose).

Now, as for your issue... well, normally I'd love to help, but frankly your attitude is quite off-putting (to say the least).

xamonix

bradgrafelman!
If you don't wanna help just keep way from the keyboard and from this post!

This is not for a business or profit purpose, so why spend money on a programmer?
This is a work I'm doing as a volunteer for a charity community, where I'm trying to help! Is that a crime? Why do have to face this on a money and profit basis?

Have you ever thaught that people helping and contribuiting on Foruns are not here to make money or get rich? What about human values like knowledge sharing? Are you afraid that guys like me will steal your job? Please don't be ridiculous! The world, the internet and foruns like this one, would be better places without guys like you!

xamonix

bradgrafelman!
If you don't wanna help just keep way from the keyboard and from this post!

sneakyimp

xamonix;11000199 wrote:
OK OK! I agree but tell me how to do it. That kind of answers are useless if you don't tell me how to do it or point me a link to do it. It´s like I tell you how to build a house "you have to digg foundations and then build the walls, and finally cover the whole thing with a roof" but as you can see this in not enough to get your house done. You must know how to digg foundations, build walls, etc...

I'm sorry but this is really irritating. If you want to build a house, you are either a builder or you hire a builder to do it for you. This pisses me off.

xamonix

This forum is like a dictatorship! I've posted an answer to bradgrafelman (who I'm guessing is the administrator) and my answer was simply deleted. What happened bradgafelman ? Are you a mama's boy who don't like to be confronted?
I'm wasting my time here. By the way I got precious help from another forum much more useful than this one. This one is for illuminated programmers.... be careful not to choke on your shell!

Ah! go a head and delete this post! You should show some guts and keep this post on!

bradgrafelman

xamonix;11000233 wrote:
I've posted an answer to bradgrafelman

No you didn't. I asked no non-rhetorical questions, thus there was nothing to answer. All you did was throw a little temper tantrum, and that I deleted solely because it wasn't constructive or necessary.

xamonix;11000233 wrote:
(who I'm guessing is the administrator)

Nay, just a moderator.

xamonix;11000233 wrote:
What happened bradgafelman ? Are you a mama's boy who don't like to be confronted?

Not really, no. I was just trying to return this thread to a constructive state. But apparently you're not mature enough (or actually want help badly enough) in order for that to happen. What a shame.

xamonix;11000233 wrote:
I'm wasting my time here.

Agreed. Don't let the door hit you in the... er, I mean, good luck with your endeavors, come back soon!

xamonix;11000233 wrote:
By the way I got precious help from another forum

...which means you won't be bothering us with your temper tantrums and demand for free work? Awesome - sounds like a win-win for both you and this entire community!

xamonix;11000233 wrote:
Ah! go a head and delete this post! You should show some guts and keep this post on!

I think I'm going to take your advice and leave all of these posts here... just to give everyone else a chuckle at how immature some people can be. 🙂 (Also note that the previously deleted replies have been restored for the same reason.)