help creating php form mail script

[bumpn]

im new to php and trying to write a script with form validation for all fields
i cant get the scrip to work tho and it needs modified i guess how does one go about writing php code to fit all my needs?

Name
Street (Address)
City
State OHIO
Zip
Email
Best number to reach you?
Preferred method of contacting you? Any E-mail Phone
Vehicle make
Model
Year
Type
Window
Options
Tint
Any commeants or messages for us?

heres the php

<?php
if(isset($_POST['email'])) {

// EDIT THE 2 LINES BELOW AS REQUIRED
$email_to = "myemailadress.com";
$email_subject = "email subject";


function died($error) {
    // your error code can go here
    echo "We are very sorry, but there were error(s) found with the form you submitted. ";
    echo "These errors appear below.<br /><br />";
    echo $error."<br /><br />";
    echo "Please go back and fix these errors.<br /><br />";
    die();
}

// validation expected data exists
if(!isset($_POST['name']) ||
    !isset($_POST['last_name']) ||
    !isset($_POST['email']) ||
    !isset($_POST['phone']) ||
    !isset($_POST['comments'])) {
    died('We are sorry, but there appears to be a problem with the form you submitted.');      
}

$name = $_POST['name']; // required
$last_name = $_POST['number']; // required
$email_from = $_POST['email']; // required
$telephone = $_POST['phone']; // not required
$comments = $_POST['comments']; // required

$error_message = "";
$email_exp = '/^[A-Za-z0-9._%-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}$/';
  if(!preg_match($email_exp,$email_from)) {
    $error_message .= 'The Email Address you entered does not appear to be valid.<br />';
  }
    $string_exp = "/^[A-Za-z .'-]+$/";
  if(!preg_match($string_exp,$name)) {
    $error_message .= 'The First Name you entered does not appear to be valid.<br />';
  }
  if(!preg_match($string_exp,$last_name)) {
    $error_message .= 'The Last Name you entered does not appear to be valid.<br />';
  }
  if(strlen($comments) < 2) {
    $error_message .= 'The Comments you entered do not appear to be valid.<br />';
  }
  if(strlen($error_message) > 0) {
    died($error_message);
  }
    $email_message = "Form details below.\n\n";

function clean_string($string) {
  $bad = array("content-type","bcc:","to:","cc:","href");
  return str_replace($bad,"",$string);
}

$email_message .= "name: ".clean_string($name)."\n";
$email_message .= "Last Name: ".clean_string($last_name)."\n";
$email_message .= "Email: ".clean_string($email_from)."\n";
$email_message .= "Telephone: ".clean_string($telephone)."\n";
$email_message .= "Comments: ".clean_string($comments)."\n";


// create email headers
$headers = 'From: '.$email_from."\r\n".
'Reply-To: '.$email_from."\r\n" .
'X-Mailer: PHP/' . phpversion();
@mail($email_to, $email_subject, $email_message, $headers); 
?>
 /* Redirect visitor to the thank you page */
header('Location: redirect url');
exit();

<?php
}
?>

[bradgrafelman]

Welcome to PHPBuilder!

bumpn;11000318 wrote:

i cant get the scrip to work tho

Can you give us more information than that? (We already know it's not working - that's why you're here, after all. 😉)

For example, what happens when you tried to use it? Did you get any PHP errors? If not, did you verify (such as via a [man]phpinfo/man page) that display_errors is set to On and error_reporting is set to E_ALL? Also, can you show us the HTML form that is getting POST'ed to this script?

Here are a couple of comments about the code (I'll wait to dive into it more when you reply back with some of the above info):

1. Get rid of the '@' error suppressor in front of your call to mail() near the end of the script. This operator should, IMHO, almost never be used since it doesn't do anything helpful. All it does do is force PHP to quietly hide error messages that it might be trying to generate in order to help you debug a problem.

2. Note that your redirect code:

   /* Redirect visitor to the thank you page */ 
   header('Location: redirect url'); 
   exit();

   isn't inside of any <?php .. ?> tags, thus it's not going to be executed as PHP code (it'll get sent along to the browser as output).

[bumpn]

when i hit submit white screen and the url changes from the form page form.htm to the form script script.php

[bradgrafelman]

Okay, that mostly answers the first of four questions I asked previously:

bradgrafelman;11000328 wrote:

For example, what happens when you tried to use it? Did you get any PHP errors? If not, did you verify (such as via a [man]phpinfo/man page) that display_errors is set to On and error_reporting is set to E_ALL? Also, can you show us the HTML form that is getting POST'ed to this script?

Any chance you can respond to the other three? The last question/request is especially important, otherwise we have no idea what the data that you're POST'ing to this script might look like.

Another test you can do just to examine the POST data itself would be to use something like [man]print_r/man or [man]var_dump/man on the entire $_POST array to view its contents.