Parse error: syntax error, unexpected $end in

[anon443]

Hi everybody, quick question here.

I am getting this error Parse error: syntax error, unexpected $end in /xxxxx/xxxx/top_players.php on line 29

<?php '<ul>';

$sql = mysql_query("SELECT * FROM ava_users ORDER BY 0+points desc LIMIT $template[homepage_topplayers_limit]");
while($row = mysql_fetch_array($sql)) {

'<div align="center">'.$name = shortenStr($row['username'], 13);

$username = htmlspecialchars($name);

$url = ProfileUrl($row['id'], $row['seo_url']);

if ($setting['module_thumbs'] == 1) {
	$avatar = '<img alt="'.$name.'" src="'.AvatarUrl($row['avatar'], $row['facebook'], $row['facebook_id']).'" width="64" height="64" />';
}
else {
	$avatar = '';
}

echo $avatar.' <div class="top_players_info">&nbsp;<a href="'.$url.'">'.$username.'</a>';
if ($row['points'] != '') {
	echo $row['points'].' '.PTS.'"</div>" "</div>";
}
}



"<'/ul>";
}
php?>

I've been editing this bit of code for a while, stripping out unwanted properties

I appreciate any help 🙂

[bradgrafelman]

Several issues:

1. When posting PHP code, please use the board's [noparse]

   ..

   [/noparse] bbcode tags as they make your code much easier to read and analyze.

2. Statements like this:

   '<ul>'; 

   do absolutely nothing and might as well be removed. What is that supposed to be doing?

3. This:

   '<div align="center">'.$name = shortenStr($row['username'], 13);

   makes no sense. Why is there a string on the left-hand side of the assignment operator? What is that statement supposed to be doing?

4. The last string in this echo statement:

    echo $row['points'].' '.PTS.'"</div>" "</div>"; 

   is never closed (which explains why the color coding goes haywire after this statement - something you should be seeing in your code editor of choice).

5. The closing tag in PHP is '?>', not 'php?>'.

[anon443]

1. Sorry I didn't use the php code markup.

2. I think <ul> is supposed to underline the text generated, it was just there in the file I was editing.

3. I'm assuming the assignment operator begins with $, im new to php so i don't know much.

It was supposed to be centering the username generated, but i'm just removing it now for the time being, i'll find a better way of doing that.

4. How is it not closed? I'm sorry I just don't understand... My color coding in cpanel did not go haywire, can you suggest a better tool to edit php with?

5. I have changed the closing tag, but the problem still persists.

Appreciate the reply 🙂

[anon443]

Sorry I can't edit my posts, and I forgot to include my updated php code.

<?php '<ul>';

$sql = mysql_query("SELECT * FROM ava_users ORDER BY 0+points desc LIMIT $template[homepage_topplayers_limit]");
while($row = mysql_fetch_array($sql)) {

$name = shortenStr($row['username'], 13);

$username = htmlspecialchars($name);

$url = ProfileUrl($row['id'], $row['seo_url']);

if ($setting['module_thumbs'] == 1) {
	$avatar = '<img alt="'.$name.'" src="'.AvatarUrl($row['avatar'], $row['facebook'], $row['facebook_id']).'" width="64" height="64" />';
}
else {
	$avatar = '';
}

echo $avatar.' <div class="top_players_info">&nbsp;<a href="'.$url.'">'.$username.'</a>';
if ($row['points'] != '') {
	echo $row['points'].' '.PTS.' "</div>";
}
}



"<'/ul>"

?>

[bradgrafelman]

I would highly suggest you look for some very basic PHP tutorials, articles, guides, etc. and learn the syntax of the language rather than trying to hack away at a script that you don't understand.

[anon443]

I have been learning, but clearly I need to learn more.

Can you suggest a good tool to edit php in?

Cpanels syntax highlighting is not 100&#37; functional.

Thanks

[Weedpacket]

It's not the editor, it's the understanding of the person using it.