[RESOLVED] OOP PHP data retrieval script issue..

[PeterPans]

Hello,

I am writing a data retrieval script, printing the data found on a DB. For some reason the script does not work..

More details..

the HTML form that calls the initiator..

<form method='get' action="init.Get.php">
<div><input type="submit" name="get" value="See Data"></div>    

</form>

the initiator script..

<?php
include 'dataGet.class.php';
$data= new getData();
$data= retrData($name, $email, $text);
?>

and my class

<?php
class getData {
    private $name;
    private $email;
    private $text;

function getData(){
    $this->host = 'localhost';
    $this->uname = 'root';
    $this->pword = '9189';
    $this->dbname = 'teststorage';
    $this->dbtable = 'userData';
    }
function retrData($name, $email, $text){
    $this->dbconnect = mysql_connect($this->host, $this->uname, $this->pword);
    if (!$this->dbconnect) die("Connection Unable " . mysql_error());

    mysql_select_db($this->dbname);
    $sql_query = "SELECT * FROM $this->dbtable ";//WHERE name = '$name' , email = '$email' AND text = '$text'";
    $result = mysql_query($sql_query);

    if ($result){
        echo $result;
    }
    else{
        echo "Retrieval Unsuccesful";
    }
    mysql_close($sql_query);
}
}

?>

Can someone please what is wrong in this picture? Why doesn't it work?

Thank you in advance.

[dalecosp]

Just a guess, but:

$data= new getData(); 
$data= retrData($name, $email, $text);

... could it be you make an object and then overwrite it?

[Derokorian]

With an undefined function no less. Either error_reporting or display_errors is turned off, otherwise you would be seeing a [ Fatal error: Call to undefined function retrData() in /path/to/file.php on line # ]

[dalecosp]

The function is in the class. It's just that when he overwrites the object the function disappears, right?

[Derokorian]

Even without overwriting the $data object the function is still a member of that class, so you can't just call it by function name. You have to call it as part of the object, using the -> operator. IE:

class foobar {
   function foo() {
      echo 'This is my foobar saying foo!';
   }
}

$foobar = new foobar();
$foobar->foo(); // Works
foo(); // Fatal error: undefined function foo() in file.php on line #

[PeterPans]

yes actually my output is an empty page to be honest.. the concept of both scripts is solid... but the commandline is what worries me.. and where actually..

ok.. i have removed the attributes and tried to see if the script works.. but it doesn't..

also, my php.ini file has error reporting enabled.. and i have tried to run my script with this line of code

$error_reporting = error_reporting(E_ALL); 
echo $error_reporting;

in it.. but still i get no errors..

[dalecosp]

Right, so he'd have an "undefined function error", but the function, technically IS defined.

It's just being called improperly. Sorry for being so pedantic. 🙂

Anyway, to directly answer the OP question --- "you're doing it wrong." :p

<?php 
include 'dataGet.class.php'; 
$data= new getData(); 
$blargh= $data->retrData($name, $email, $text); 
?>

I believe that's what you want.

[PeterPans]

omg.. Derokorian yes you are right.. damn.. i completely forgot the operator.. ill try it now.. thx a lot m8..

[PeterPans]

$data->retrData($name, $email, $text);

thats how it has to be.. 🙂

[bradgrafelman]

In addition to the problems noted above, note that in this script:

<?php 
include 'dataGet.class.php'; 
$data= new getData(); 
$data= retrData($name, $email, $text); 
?>

$name, $email, and $text are all undefined.

EDIT:

dalecosp;11000623 wrote:

Right, so he'd have an "undefined function error", but the function, technically IS defined.

In my opinion, no, it isn't defined because we're talking about a method and not a function.

[PeterPans]

not proud of myself now.. but it works.. 🙂

[PeterPans]

yes yes i know 🙂 thx a lot guys.. pheww it works!

[dalecosp]

bradgrafelman;11000626 wrote:

EDIT: In my opinion, no, it isn't defined because we're talking about a method and not a function.

Ah, the pendantic Dalecosp pwned by a true pedant! 😃