Else If Correction

Martin_Dickson

Hi there,

Thanks for having a look at my question. I have built a site for my charity (see www.youthheroes.org.uk) and I want to display a different menu depending on the the location of the project we are working on. I have managed to get close to what I want using the following code which calls a Wordpress menu🙂:

<?php if ( get_post_meta($post->ID, 'main', true) ) { ?>
<?php do_action('wp_menubar','Main Menu'); ?>
<?php } ?>

<?php if ( get_post_meta($post->ID, 'wirral', true) ) { ?>
<?php do_action('wp_menubar','Main Menu'); ?>
<?php } ?>

<?php if ( get_post_meta($post->ID, 'salford', true) ) { ?>
<?php do_action('wp_menubar','Salford'); ?>
<?php } ?>

However, I would like to include a catch all and tidy up the code a bit to make expansion easier. I have this code below but it's incorrect and returns an error😕:

<?php if ( get_post_meta($post->ID, 'salford', true) ) { ?>
<?php do_action('wp_menubar','salford'); ?>
<?php elseif ( get_post_meta($post->ID, 'wirral', true) ) ?>
<?php  do_action('wp_menubar','wirral'); ?>
<?php else ?>
<?php  do_action('wp_menubar','Main Menu'); } ?>

Any help much appreciated.

Thanks,

Martin

Weedpacket

You don't need to put every line in its own pair of PHP tags....

Your problem is that you've removed some of the braces, and the two you've left don't belong together. Try putting the braces back.

Martin_Dickson

Awesome! Thanks for explaining too rather than just rewriting the code for me to copy; that has helped me learn from my mistake.

This works really well:

<?php if ( get_post_meta($post->ID, 'salford', true) ) { 
do_action('wp_menubar','salford'); }
elseif ( get_post_meta($post->ID, 'wirral', true) ) {
do_action('wp_menubar','wirral'); }
else {
do_action('wp_menubar','Main Menu');  }
?>

Much appreciated!

Martin

Martin_Dickson

I wonder if I can get one other quick answer to a similar thing. This works:

<?php if ( get_post_meta($post->ID, 'main', true) ) { ?>
<div class="main_table">
<?php } ?>

<?php if ( get_post_meta($post->ID, 'wirral', true) ) { ?>
<div class="main_table_wirral">
<?php } ?>

<?php if ( get_post_meta($post->ID, 'salford', true) ) { ?>
<div class="main_table_salford">
<?php } ?>

But I would like to use something like this because it allows for a default using the else:

<?php if ( get_post_meta($post->ID, 'salford', true) ) { 
'<div class="main_table_salford">' ; }
elseif ( get_post_meta($post->ID, 'wirral', true) ) {
'<div class="main_table_wirral">' ;  }
else {
'<div class="main_table">' ;  }
?>

There are no errors in the code but the ' before and after the div class means that it just ignores this line. Without the ' I get an error presumably because I have < and > in the middle of the php.

Does that make any sense at all? I am such a novice but I am really enjoying this.

Cheers,

Martin

Weedpacket

You have to tell PHP what to do with the string: [man]echo[/man].

Martin_Dickson

Brilliant! Thank you!

spufi

Also look up the switch statement since it gives you a way to check something that has could have various values in it and also offers a default option.

http://php.net/manual/en/control-structures.switch.php