Strange PHP / SQL Problem

saricDen

Hi everyone, I'm having trouble figuring out what's going on with my code here:

mysql_select_db("kdb", $mysql_link);

$query = "SELECT * FROM ForumProfiles WHERE Email='".$_SESSION['Email']."'";
if ($result = mysql_query($query)) $row = mysql_fetch_assoc($result);

$new_balance = $row['Money']+1;
$p_id = $row['ID'];

$query = "UPDATE ForumProfiles SET Balance = $new_balance WHERE ID = '$p_id'";
if ($result = mysql_query($query)) $row = mysql_fetch_assoc($result);

The weird thing is that it does work, the php and the sql do exactly what I want them to, but it always returns this:
Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in...

If anyone can help me alleviate this problem I'd be very grateful, thanks!

Weedpacket

The deeper observation I feel I need to make is that it looks like it's intended to have the same effect as:

UPDATE ForumProfiles SET Balance = Money + 1 WHERE Email = '[i]<insert email here>[/i]'

saricDen

Nevermind, I actually figured it out!
It was because I wasn't passing a SELECT result to the mysql_fetch_assoc().
Thanks anyways!

bradgrafelman

The point Weedpacket was trying to make is that your code is unnecessarily inefficient and complex, because there's no need for the SELECT query at all.

Bonesnap

In other words, you don't need to pull specific rows from the database just to update them and put them back. You can update the specific rows with the WHERE clause like you have been, but without having to add the extra step of selecting the data.

saricDen

Ohh okay, I see what you mean. I select the row because I need to access information from it later in the page. This would still need 2 queries right?

saricDen

Ohhhhh sorry I see now.
Okay thanks guys! I'll fix it up to be more efficient!