Help please!! Code not working today

ckerr27

Hey I finally got this code working yesterday, when the user enters a name into the form and submits it the specific users details should be shown on the next page, this was working fine yesterday and when i turned my laptop on today it is not working, I am not getting any errors just not displaying the user details?? Any ideas? Heres the code

Form:

<table width="300" border="1" align="center" cellpadding="2" cellspacing="1" bgcolor="#9999cc">
<tr>
<form name="form1" method="post" action="getdetails.php">
<td>
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td colspan="3"><strong><center>Personal Details</center> </strong></td>
</tr>
<tr>
<td width="78">Username</td>
<td width="6">:</td>
<td width="294"><input name="submit" type="text" id="username"></td>
</tr>
<tr>

<td>&nbsp;</td>
<td>&nbsp;</td>
<td><input type="submit" name="Submit" value="Get Details"></td>
</tr>
</table>
</td>
</form>
</tr>
</table>

getdetails.php

<html>
<head>
<link rel="stylesheet" type ="text/css" href="anything2.css"
</head>

<body>


<div id="container">

<div id="header"><img src="imagesb.jpg" alt="Cool Image" align="left">
<img src="images.jpg" alt="Cool Image" align="right"><center><b><font size="6.5"><br><br>User Details</b></center></font>

</div>


<div id="leftnav"><center>
<br><br>
<input type= "button" style="width:120px;" value="Home" onClick="window.location= 'home.php' ">
<br><br>
<input type= "button" style="width:120px;" value="Club Details" onClick="window.location= 'clubdetails.php' ">
<br><br>
<input type= "button" style="width:120px;" value="Future Events" onClick="window.location= 'futureevents.php' ">
<br><br>
<input type= "button" style="width:120px;" value="News" onClick="window.location= 'news.php' ">
<br><br>
<input type= "button" style="width:120px;" value="FAQ" onClick="window.location= 'faq.php' ">
<br><br>
<input type= "button" style="width:120px;" value="Wall" onClick="window.location= 'wall.php' ">
<br><br>
<input type= "button" style="width:120px;" value="About Us" onClick="window.location= 'about.php' ">
</div>

<div id="body">
<br><br>
<?php
mysql_connect ("localhost","root","")
or die("Cannot connect to Database");
mysql_select_db ("test");



if (isset($_POST['Submit'])){
$username=mysql_real_escape_string(trim($_POST['Submit']));   

$sql = "select * from memberdetails WHERE username='$username'";
       $result = mysql_query ($sql);

   while ($row = mysql_fetch_array($result))
                     {
          $username= $row["username"];
          $firstname= $row["firstname"];
          $surname= $row["surname"];
          $dob= $row["dob"];
          $totalwins= $row["totalwins"];   
          $totalloses= $row["totalloses"];
          $email= $row["email"];
          $country= $row["country"];
       $info= $row["info"];

   echo "<b><u>Username:</b></u>  $username<br>";
   echo "<b><u>Firstname:</b></u> $firstname<br>";
   echo "<b><u>Surname: </b> </u> $surname<br>";
   echo "<b><u>Date of Birth:</b></u> $dob<br>";
   echo "<b><u>Total Chess Wins:</b></u>  $totalwins<br>";   

   echo "<b><u>Total Chess loses:</b></u> $totalloses<br>";
   echo "<b><u>Email Address: </b></u> $email<br>";
   echo "<b><u>Born in: </b></u> $country<br>";
   echo "<b><u>Other Details:</b></u>  $info<br><br><br>";
          }}   

?>
<a href="delete.php">Delete User</a>
<div id="footer">This is the footer</div>

</body>
</html>

Bonesnap

Please use the forum's [noparse]

[/noparse] tags when posting PHP code as it makes it much easier to read.

I can tell though that this line...

$username=mysql_real_escape_string(trim($_POST['Submit']));

...is probably not what you want. You'll want to supply the username POST variable, not the submit variable.

You also have two elements in your from named "submit". I'm not sure if name attributes are case sensitive or not, but I wager that this is not what you intended anyway.

<input name="submit" type="text" id="username">
<input type="submit" name="Submit" value="Get Details">

Change the name attribute in the first element to "username".

Remember, PHP uses the name attribute of elements for POST'd data, not the id attribute. To learn more about HTML attributes, click here or do a Google search.

php_rockzz

U r using the following code to get the value of username:

$username=mysql_real_escape_string(trim($_POST['Submit']));

if u see ur html code, the name 'Submit' refers to the 'submit button'.

<input type="submit" name="Submit" value="Get Details">

Thts the reason why u r not getting the value of the text field..

And as Bonesnap said, what is the use of giving such conflicting and confusing names to the fields when there r infinite names u can give.. select such names that would make the code easier to understand and does not confuse u..

ckerr27

Thanks i got that working perfectly.

I have tried to add a function to allow the user to delete a user from the database if required. The code I have used is:

<?php
mysql_connect ("localhost","root","")
or die("Cannot connect to Database");
mysql_select_db ("test");

mysql_query ("DELETE FROM members WHERE username='$username'") or die (mysql_error));
echo "User has been deleted";
header("Location: personaldetails.php");

This is giving me an error on the mysql_query line.

I am not sure if i am using the correct format?

Derokorian

mysql_error is a function, not a constant, it should have parens at the end

mysql_error()

Also you shouldn't be using the mysql library, instead you should use mysqli or better yet PDO.

PHP.net wrote:
http://php.net/manual/en/mysqlinfo.api.choosing.php
It is recommended to use either the mysqli or PDO_MySQL extensions. It is not recommended to use the old mysql extension for new development.

Also see [man]header/man. You can't have output before header calls. Also note, the Location header expects a full URI which you aren't giving it. Therefore this is all wrong:

echo "User has been deleted";
header("Location: personaldetails.php");

If you want to show a confirmation of deletion do it on the page you redirect to OR use a refresh header to redirect after a short time.

Bonesnap

Bonesnap;11000883 wrote:
Please use the forum's [noparse]
[/noparse] tags when posting PHP code as it makes it much easier to read.

...