next issue with php mial script

[bumpn]

so my other thread here I fixed the issue and stopped being lazy and created my own script for my very first one I think I did good. now for the next step i need to protect it from spam and email spiders. were should i go to look for info on such? what issues do i have with me script?

/* basic mailer works 4/5/12*/

<?php
/* form will be sent to these email addresses */
$myemail = "[e-mail]";


/* headers*//*this syntax makes it show up inbox not spam*/
$subject = "place subject here.";
$headers = 'From: [e-mail]' . "\r\n" .
'Cc: [e-mail]' . "\r\n" .
'Bcc: [e-mail]' . "\r\n" .
'Reply-To: [e-mail]' . "\r\n" .
'X-Mailer: PHP/' . phpversion();

/* syntax//  $php item = $action ['$value on form'];*/
/* defines whats included in mail message */
$field1 = $_REQUEST ['field1'];
$field2 = $_REQUEST ['field2'];
$field3 = $_REQUEST ['field3'];
$field4 = $_REQUEST ['field4'];
$field5 = $_REQUEST ['field5'];
$field6 = $_REQUEST ['field6'];
$field7 = $_REQUEST ['field7'];
$field8 = $_REQUEST ['field8'];
$field9 = $_REQUEST ['field9'];
$field10 = $_REQUEST ['field10'];
$field11 = $_REQUEST ['field11'];
$field12 = $_REQUEST ['field12'];   

$field13 = $_REQUEST ['field13'];   

$field14 = $_REQUEST ['field14'];   


/* message how I want it to appear inbox*/
/* defines what form items are*/
$message = "
field1: $field1
field2: $field2
field3: $field3
field4: $field4
field5: $field5
field6: $field6
field7: $field7
field8: $field8
[line here]
field9: $field9
field10: $field10
field11: $field11
[a line here]
field12: $field12
field13: $field13
field14: $field14
---
End of message
";


/* Send the message using mail() function */
mail($myemail,$subject,$message,$headers);


/* Redirect visitor to the thank you page */
header('Location: link to url here');
exit();


?>

[bumpn]

can anyone tell me tho why this syntax didn't work? $field10 = $_post ['field10'];

[jeepin81]

I would have to guess it is something with your form where the data is entered.. can you post that code? Also, you can save yourself some time w/ those repetitive variables by using a loop... for example:

for($i=1;$i<15;$i++){
  ${'field'.$i} = $_REQUEST['field'.$i];
}

Also, make sure you sanitize ur data.

[dalecosp]

jeepin81;11000955 wrote:

Also, make sure you sanitize ur data.

Which is pivotal in order to "protect it from spam and email spiders".

A couple of good "strings to Google for" might be:

php email form validation
php email injection attack

For example ... check to make sure that fields that shouldn't have linebreaks in them don't have linebreaks in them ;-)

It's quite a bit more complicated than that. Read up, and good luck!

[Derokorian]

Also you can give your fields names like field[] to make it an array in PHP instead of a bunch of name# combos that don't really tell you much. Also I suggest giving your fields meaningful names, as it is now if you put this away and came back in 3 weeks would you know what data to expect in any of those fields?

Also as suggested on the previous thread, that you linked to, you should use $POST / $GET as opposed to $REQUEST since request fills from those (as well as $COOKIE iirc) what happens if multiple keys are the same? How do you know which one you got with request? IE if I POST my name, and have a GET variable of your name, how does your code know which one you got if you use REQUEST?