[RESOLVED] Values not going in DB

chrisguk

Hi,

I have put the following code together in an attempt to insert data into my DB. It isnt producing any error messages just posting to self returning back to the start again.

Any ideas?

<html>
<head></head>
<body>
<?php 

session_start();

$self = $_SERVER['PHP_SELF'];

$localhost = 'localhost';
$dbuser = 'root';
$dbpass = 'password';
$dbname = 'north';

$connect = mysql_connect($localhost, $dbuser, $dbpass);

mysql_select_db($dbname, $connect);
if(isset($_POST['submit']))
{
$id = $_POST['id'];
$title = $_POST['title'];
$description = $_POST['description'];
$keywords = $_POST['keywords'];
$_SESSION['id']=$id;
$_SESSION['title']=$title;
$_SESSION['description']=$description;
$_SESSION['keywords']=$keywords;

$query = "INSERT INTO URL VALUES ('','$id','$title','$description','$keywords')";
mysql_query($query);
header("location: home.php");

echo 'Success';

} 
?>

<form method="post" action="<?php echo $self; ?>">
Page Name: <input type="text" name="id"><br>
Title of Page: <input type="text" name="title"><br>
Description: <input type="text" name="description"><br>
Keywords: <input type="text" name="keywords"><br>
<input type="Submit">
</form>


</body>
</html>

anoopmail

Change <input type="Submit"> to

<input type="submit" name="submit">

chrisguk

I have just been reading the PHP manual on the mysql_real_escape_string

But I am not sure how to implement that into my code?

Ashley_Sheridan

As an example:

$title = mysqli_real_escape_string($_POST['title']);

Note I've used the mysqli function call here, as the older mysql stuff is deprecated.

chrisguk

Ashley Sheridan;11002569 wrote:
As an example:
$title = mysqli_real_escape_string($_POST['title']);
Note I've used the mysqli function call here, as the older mysql stuff is deprecated.

Did that and got:

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 47

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 48

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 49

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 50

Ashley_Sheridan

My bad, it seems that the function call differs slightly between the old and new versions. The first argument to it needs to be the link identifier you created when you made the DB connection, i.e.:

mysqli_connect()

However, you may need to alter your code if that's not how you're connecting.

chrisguk

Ashley Sheridan;11002572 wrote:
My bad, it seems that the function call differs slightly between the old and new versions. The first argument to it needs to be the link identifier you created when you made the DB connection, i.e.:
mysqli_connect()
However, you may need to alter your code if that's not how you're connecting.

No that was stupid of my not to realise I was using depreciated functions with current ones.

chrisguk

Thanks Brad,

You and Ashley have been very helpful today and I have learnt lots already 🙂

Slowly im getting there!

chrisguk

Hi,

Just when you thought I had gone. For the last 40 mins I have been trying to find the answer to this issue. This time I will post my code as it is now and the errors below that:

<?php 

session_start();

$self = $_SERVER['PHP_SELF'];


$localhost = 'localhost';
$dbuser = 'root';
$dbpass = 'password';
$dbname = 'north';

$mysqli = new mysqli($localhost, $dbuser, $dbpass, $dbname);
if ($mysqli->connect_errno) {
    echo "Failed to connect to MySQL: (" . $mysqli->connect_errno . ") " . $mysqli->connect_error;
}

//select_db($dbname, $connect);
if(isset($_POST['submit']))
{
var_dump($_POST);
$id = mysqli_real_escape_string($_POST['id']);
$title = mysqli_real_escape_string($_POST['title']);
$description = mysqli_real_escape_string($_POST['description']);
$keywords = mysqli_real_escape_string($_POST['keywords']);
$_SESSION['id']=$id;
$_SESSION['title']=$title;
$_SESSION['description']=$description;
$_SESSION['keywords']=$keywords;

$query = "INSERT INTO URL VALUES ('','$id','$title','$description','$keywords')";
mysqli_query($query);

$success = 'You have successfully updated your data';

} 

$form ="<div style=\"width:400px;\">";
$form.="<p>Database result:";
if(isset($success)) {
   $form .= $success;
}
$form.= "</p>"; 

$form.="<form action=\"$self\" method=\"post\" id=\"contactus\">";
$form.="<fieldset>";
$form.="<span>Page Name:</span> <label><input type=\"text\" name=\"id\"></label><br>\n";
$form.="<span>Title:</span> <label><input type=\"text\" name=\"title\"></label><br>\n";
$form.="<span>Description:</span> <label><input type=\"text\" name=\"description\"></label><br>\n";
$form.="<span>Keywords:</span> <label><input type=\"text\" name=\"keywords\"></label><br>\n";
$form.="<input type=\"submit\" name=\"submit\">\n";
$form.="</fieldset>";
$form.="</form>";
$form.="</div>";

print $form;
?>

Errors:

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 50

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 51

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 52

Warning: mysqli_real_escape_string() expects exactly 2 parameters, 1 given in /var/www/test/index.php on line 53

Warning: mysqli_query() expects at least 2 parameters, 1 given in /var/www/test/index.php on line 60

Derokorian

Did you refer to the docs for those functions? As you're attempting to use them they expect a connection to be made with mysqli_connect and that resource to be passed as the first parameter (as stated in the docs). Alternatively you can connect OOP style (as you did here) but then you have to use them OOP style like so:

$mysqli = new mysqli();
$var = $mysqli->real_escape_string($_POST['var']);
$result = $mysqli->query($query);
// etc..

// OR
$mysqli = mysqli_connect();
$var = mysqli_real_escape_string($mysqli,$_POST['var']);
$result = mysqli_query($mysqli,$query);

chrisguk

Thread moved and Renewed http://www.phpbuilder.com/board/showthread.php?p=11002596#post11002596