How to create a success message within a div upon successfull form submission?

polarexpress

A form that has the following code displays the success message every time on page launch in the browser logically but the form should display the success message only after it is submitted successfully.

This is the php syntax:

$editFormAction = $_SERVER['PHP_SELF'];
if (isset($_SERVER['QUERY_STRING'])) {
  $editFormAction .= "?" . htmlentities($_SERVER['QUERY_STRING']);
}

$message = "Record has been updated successfully.";

if ((isset($_POST["MM_update"])) && ($_POST["MM_update"] == "form1")) {
  $updateSQL = sprintf("UPDATE table SET name=%s, email=%s, 

                   GetSQLValueString($_POST['name'], "text"),
                   GetSQLValueString($_POST['email'], "text"),

  mysql_select_db($database_test, $test);
  $Result1 = mysql_query($updateSQL, $test) or die(mysql_error()); 

  $updateGoTo = "test.php";
  if (isset($_SERVER['QUERY_STRING'])) {
    $updateGoTo .= (strpos($updateGoTo, '?')) ? "&" : "?";
    $updateGoTo .= $_SERVER['QUERY_STRING'];
  }
  header(sprintf("Location: %s", $updateGoTo));
}

This is the html form part:

<form action="<?php echo $editFormAction; ?>" method="post" name="form1" id="form1">
     <table align="center" class="test_table">
      <tr valign="baseline">
         <td align="right" nowrap="nowrap" class="table-title">Name:</td>
         <td class="table-content"><input type="text" name="name" value="<?php echo htmlentities($row_user['name'], ENT_COMPAT, 'utf-8'); ?>" size="32" /></td>
       </tr>
       <tr valign="baseline">
         <td align="right" nowrap="nowrap" class="table-title">E-mail:</td>
         <td class="table-content"><input type="text" name="email" value="<?php echo htmlentities($row_user['email'], ENT_COMPAT, 'utf-8'); ?>" size="32" /></td>
       </tr>
     </table>
     <input type="hidden" name="MM_update" value="form1" />
     <input type="hidden" name="id" value="<?php echo $row_user['id']; ?>" />
      <input class="submit" name="UpdateRecord" type="submit" id="UpdateRecord" value="Update Record" /></form>

This is how the success message is called within a div on the page:

<p> <?php 
	  if (!empty($message)) {
	  echo "<div class=\"successmessage\">" . $message . "</div>";
	  } 
	  ?></p>

As far as I realize it's is the following conditional statement that is causing such output.

if (!empty($message)) {

How should I replace this statement in order get the output properly?

Thanks in advance.

Weedpacket

Don't set $message to say "Record has been updated succesfully" until after (and only if) the record has been updated succesfully.

polarexpress

Weedpacket;11003123 wrote:
Don't set $message to say "Record has been updated succesfully" until after (and only if) the record has been updated succesfully.

Should I set the $message just before header in this case?

Thanks,

polarexpress

Weedpacket;11003123 wrote:
Don't set $message to say "Record has been updated succesfully" until after (and only if) the record has been updated succesfully.

I'm trying to call the message from anywhere on the page based on a conditional statement.

Should I set the $message just before header in this case?

Thanks,

cretaceous

don't post your problem in multiple threads - not helpful

your problem is because when your form is submitted, entries are processed and immediately you are bouncing the user to a new page :

header(sprintf("Location: %s", $updateGoTo));

when you get to new page that page has no information of the update success

you need to add a "success" variable to $updateGoTo

maybe like
$updateGoTo.="&updateok=1"

then on the "updateGoTo" page you add a $_GET['updateok'] and if that is true (1) you show the message

(it seems users always end up on the success page, so you don't need any logic - just show the message - but you are not showing all your code so that's a guess)

this next bit is moving the goalposts !

I'm trying to call the message from anywhere on the page based on a conditional statement.

you want it on a form submit or what?

polarexpress

Thanks for your comments

Actually the header has been defined as tes.php where both the form itself and success message exist.

[B][COLOR="RoyalBlue"] $updateGoTo = "test.php";[/COLOR][/B]
  if (isset($_SERVER['QUERY_STRING'])) {
    $updateGoTo .= (strpos($updateGoTo, '?')) ? "&" : "?";
    $updateGoTo .= $_SERVER['QUERY_STRING'];
  }
  header(sprintf("Location: %s", $updateGoTo));
}

The purpose can be served easily by adding a query string to the end of url like

[B][COLOR="RoyalBlue"]tes.php?action=updated [/COLOR][/B]

and then creating a conditional statement based on the query string to wrap and print the desired div with success message like

<p>
 		<?php if ((isset($_GET["action"])) && ($_GET["action"] == "updated")) { ?>
 <div class="successmessage">Record Has Been updated Successfully</div>
<?php } ?> 
</p>

but there are situations there when users navigate from one page to another (based on page id) those contain the same form on every page and in such cases the key / value pair of query string on form submission doesn't remain consistent. This is why I was trying to implement the success message similar to the other way I posted as a problem

I've posted the most important blocks of syntax that help understand the problem clearly. The only thing left here is MySql syntax. Shall I post MySql syntax too?

and thanks for share.

polarexpress

cretaceous;11003148 wrote:
don't post your problem in multiple threads - not helpful

your problem is because when your form is submitted, entries are processed and immediately you are bouncing the user to a new page :
header(sprintf("Location: %s", $updateGoTo)); 
when you get to new page that page has no information of the update success

you need to add a "success" variable to $updateGoTo

maybe like
$updateGoTo.="&updateok=1"

then on the "updateGoTo" page you add a $_GET['updateok'] and if that is true (1) you show the message

(it seems users always end up on the success page, so you don't need any logic - just show the message - but you are not showing all your code so that's a guess)

this next bit is moving the goalposts !

you want it on a form submit or what?

"from anywhere" is from a part of the page where some variables or functions can be created reasonably, I mean.

cretaceous

If you are posting the form back to itself (i.e back to same set of scripting) then you don't need to do the redirect - just check the submission has worked then show the message

I don't understand what the problem is really!

To differentiate the multiple pages and forms you can add another item to the querystring, that maybe comes from a hidden input in the form, which changes based on the page it's in

If people are navigating from one page to another they won't be submitting a form at the same time..
and you are doing it all via 'POST' and checking for a "submit" so not sure what is wrong!

polarexpress

This way the problem shall occur if the visitors submit the form over and over from here and there without returning to the main url.

To create a conditional statement with a hidden form field value for displaying the success message can be a good idea in this case but I was expecting a more clean way to do it.

Kind regards,