[RESOLVED] Array Issue - Format Data

james182

i am trying to get this to format the data properly.

I want it to format like this 'D',E','F','G','H'
But this is what i get: "D"E","F","G","H","I",J" "",

$colour = "D-E-F-G-H-I-J-"; // string to be formatted.

$colours = explode('-', $colour);
			$num_items = count($colours);

		$colour_is = '';
		$i = 0;
		foreach ($colours as $key => $value) {

			if ($i == 0) {
		        // first
		        $colour_is .= ' "'. $value;
		    } else if ($i == $num_items - 1) {
		        // last
		        $colour_is .= $value. '" ';
		    }else{
		    	$colour_is .= '"'. $value .'",';
		    }

		    $i++;				
		}
		print_r($num_items .' - '. $colour_is);

Help on this would be nice. Thanks.

Weedpacket

Use [man]implode[/man] instead.

"'" . implode("','", $array) . "'"

laserlight

One problem is that your input is "D-E-F-G-H-I-J-", and I don't get how you intend to go from that to "'D',E','F','G','H'".

Otherwise, I might expect something like:

$colour = "D-E-F-G-H";
$colours = "'" . implode("','", explode('-', $colour)) . "'";
print_r($colours);

james182

I tried it and got: 'D','E','F','G','H',''

james182

[SOLVED]

I used this
$colours = "'". implode("','", explode('-', substr_replace($colour ,"",-1))) ."'";

Weedpacket

james182 wrote:
substr_replace($colour ,"",-1)

Or just [font=monospace]substr($colour, 0, -1)[/font] or [font=monospace]rtrim($colour, '-')[/font]...