Something i make - easy to fix, just dont know whats wrong!

jordandouglas98

Hi, i have some php code, it keeps saying this:
"Parse error: syntax error, unexpected T_STRING in /home/a9453679/public_html/forum/main_forum.php on line 12:"

here is the whole php code:
"
<html>
<title>main_forum</title>
<body>
<?php

$host="mysql7.*******.com";
$username="a9453679_users";
$password="password";
$db_name="a9453679_users";
$tbl_name="forum_question"; ?>
<?php
$mysql_connect("mysql7.******.com", "a9453679", "password") or die (cannot connect);
$mysql_select_db("$a9453679")or die("cannot select DB - main_forum.php");
$sql="SELECT FROM $forum_question ORDER BY id DESC";

$result=mysql_query($sql);
?>

<table width="90%" border="0" align="center" cellpadding="3" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<td width="6%" align="center" bgcolor="#E6E6E6">#</td>
<td width="53%" align="center" bgcolor="#E6E6E6">Topic</td>
<td width="15%" align="center" bgcolor="#E6E6E6">Views</td>
<td width="13%" align="center" bgcolor="#E6E6E6">Replies</td>
<td width="13%" align="center" bgcolor="#E6E6E6">Date/Time</td>
</tr>

<?php

while($rows=mysql_fetch_array($result)){
?>
<tr>
<td bgcolor="#FFFFFF"><? echo $rows['id']; ?></td>
<td bgcolor="#FFFFFF"><a href="view_topic.php?id=<? echo $rows['id']; ?>"><?php echo $rows['topic']; ?></a> </td>
<td align="center" bgcolor="#FFFFFF"><?php echo $rows['view']; ?></td>
<td align="center" bgcolor="#FFFFFF"><?php echo $rows['reply']; ?></td>
<td align="center" bgcolor="#FFFFFF"><?php echo $rows['datetime']; ?></td>
</tr>

<?php

}
mysql_close();
?>

<tr>
<td colspan="5" align="right" bgcolor="#E6E6E6"><a href="create_topic.php">Create New Topic </a></td>
</tr>
</table>
</body>
</html>
"
Thanks

jeepin81

You should wrap you code in PHP tags it makes it a little easier to read. It's also not a great idea to show the whole world your DB credentials as well.

//here's your issue - you need to wrap your string in quotes in your die statement.
$mysql_connect("mysql7.**********.com", "a9453679", "*password*") or die ('cannot connect');

I would also hunt down a post from forum member Derokorian and look at his tutorial on MySQLi.

bradgrafelman

You've also got dollar signs ($) in front of what should instead be function calls. Dollar signs are used to denote variables - not variables and function calls.

Weedpacket

[Passwords elided]

$mysql_select_db("$a9453679")

As well as the $ in front of mysql_select_db (which is one of those bradgrafelman referred to), you don't have a variable named [font=monospace]$a9453679[/font] either, so [font=monospace]"$a9453679"[/font] is just an empty string (and a notice from PHP about an undefined variable).