Error Undefined Index - Newbie PHP'er Here :confused:

paulbray

Hi All,

I am trying to set up an offline shopping project but am running into issues with this and I am struggling to rectify the editing bit.

Basically the suppliers are listed in suppliers.php with an include to edit_suppliers.php so I can edit entries on same screen.

Can anyone assist and help complete this part of the coding.

Thanks

Paul

supplier.php

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>


<H2>Edit Supplier</H2>


<?php


require 'Connections/conn_local.php';

$id = $_GET['id'];
$name = $_GET['Name'];
$VATReg = $_GET['VATReg'];
$Cashback = $_GET['Cashback'];


$order = "SELECT * FROM suppliers";

$result = mysql_query($order);

$row_edit_supplier = mysql_fetch_array($result);


?>
<form action="edit_supplier.php" method="POST">
<table>
<tr>
<td>ID: -</td><td><input type="text" name="id"  disabled="disabled" value="<?php echo $row_edit_supplier['id']?>" /></td></tr>
<tr>
<td>Supplier Name: -</td><td><input type="text" name="Name" value="<?php echo $row_edit_supplier['Name']?>" /></td></tr>
<tr>
<td>Charge VAT: -</td><td><input type="text" name="VATReg" value="<?php echo $row_edit_supplier['VATReg']?>"/></td></tr>
<td>Cashback %: -</td><td><input type="text" name="Cashback" value="<?php echo $row_edit_supplier['Cashback']?>" /></td></tr>
<tr>
<td><input type="hidden" name="submitted" value="TRUE"/></td>
<td><input type="submit" name="edit" value="Edit Now" /></td>
</table>

</form>
<?php

if (isset($_POST['edit'])) {

$update_supplier = "UPDATE suppliers SET id ='$id', Name = '$name', VATReg = '$VATReg', Cashback = '$Cashback'";

} else  { echo 'Can not update record';
}
?>
</body>
</html>

edit_supplier.php


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>


<H2>Edit Supplier</H2>


<?php


require 'Connections/conn_local.php';

$id = $_GET['id'];
$name = $_GET['Name'];
$VATReg = $_GET['VATReg'];
$Cashback = $_GET['Cashback'];


$order = "SELECT * FROM suppliers";

$result = mysql_query($order);

$row_edit_supplier = mysql_fetch_array($result);


?>
<form action="edit_supplier.php" method="POST">
<table>
<tr>
<td>ID: -</td><td><input type="text" name="id"  disabled="disabled" value="<?php echo $row_edit_supplier['id']?>" /></td></tr>
<tr>
<td>Supplier Name: -</td><td><input type="text" name="Name" value="<?php echo $row_edit_supplier['Name']?>" /></td></tr>
<tr>
<td>Charge VAT: -</td><td><input type="text" name="VATReg" value="<?php echo $row_edit_supplier['VATReg']?>"/></td></tr>
<td>Cashback %: -</td><td><input type="text" name="Cashback" value="<?php echo $row_edit_supplier['Cashback']?>" /></td></tr>
<tr>
<td><input type="hidden" name="submitted" value="TRUE"/></td>
<td><input type="submit" name="edit" value="Edit Now" /></td>
</table>

</form>
<?php

if (isset($_POST['edit'])) {

$update_supplier = "UPDATE suppliers SET id ='$id', Name = '$name', VATReg = '$VATReg', Cashback = '$Cashback'";

} else  { echo 'Can not update record';
}
?>
</body>
</html>

Weedpacket

What is the complete error message? What line does it refer to? What does it say on that line?

By the way, you should be checking that [font=monospace]$_GET['id'][/font] and the like are actually set before trying to use them - and know what you want to do if any of them are not.

Weedpacket

What is the complete error message? What line does it refer to? What does it say on that line?

By the way, you should be checking that [font=monospace]$_GET['id'][/font] and the like are actually set before trying to use them - and know what you want to do if any of them are not.

paulbray

Weedpacket;11007551 wrote:
What is the complete error message? What line does it refer to? What does it say on that line?

By the way, you should be checking that [font=monospace]$_GET['id'][/font] and the like are actually set before trying to use them - and know what you want to do if any of them are not.

Notice: Undefined index: id in C:\xampp\htdocs\test\supplier.php on line 19

Notice: Undefined index: Name in C:\xampp\htdocs\test\supplier.php on line 20

Notice: Undefined index: VATReg in C:\xampp\htdocs\test\supplier.php on line 21

Notice: Undefined index: Cashback in C:\xampp\htdocs\test\supplier.php on line 22
ID: -
Supplier Name: -
Charge VAT: -
Cashback %: -

Can not update record

Weedpacket

You should be checking that $_GET['id'] and the like are actually set before trying to use them - and know what you want to do if any of them are not.

paulbray

Can you advise how I do this? I am new to PHP just need a little guidance, All entries will be in DB so will always be filled

bradgrafelman

The database has nothing to do with it. These lines:

	$id = $_GET['id'];
	$name = $_GET['Name'];
	$VATReg = $_GET['VATReg'];
	$Cashback = $_GET['Cashback'];

are attempting to access external variables (e.g. supplied via the query string). However, if they do not exist, you'll be generating error messages (as you've shown above).

As such, I personally tend to define such local variables like so:

$foo = isset($_GET['foo']) ? $_GET['foo'] : NULL;

(where NULL can be any default value that makes sense for the given variable).

That way, I could later do something like:

if($foo === NULL) {
    // user didn't even supply 'foo' in the URL, go with a default here...
} else {
    // well at least they gave us something to work with - try to use it instead
}

paulbray

I am still struggling to actually insert data into my database table, can anyone shed any light on this for me.

suppliers.php

<?php require_once('Connections/conn_local.php'); ?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  if (PHP_VERSION < 6) {
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  }

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? doubleval($theValue) : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}

mysql_select_db($database_conn_local, $conn_local);
$query_suppliers = "SELECT * FROM suppliers";
$suppliers = mysql_query($query_suppliers, $conn_local) or die(mysql_error());
$row_suppliers = mysql_fetch_array($suppliers);
$totalRows_suppliers = mysql_num_rows($suppliers);

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>
<table width="350px" border="3" bgcolor="#CCFFFF" >
  <tr>
    <th>Name</th>
    <th>VAT Charged</th>
    <th>Cashback %</th>
    <th>Edit</th>
    <th>Delete</th>
    </tr>
    <?php do { ?>
      <tr>
        <td align="center"><?php echo $row_suppliers['Name']; ?></td>
        <td align="center"><?php echo $row_suppliers['VATReg']; ?></td>
        <td align="center"><?php echo $row_suppliers['Cashback']; ?></td>
        <td align="center"><?php echo '<a href="suppliers.php?id=' . $row_suppliers['id'] . '"'?>>Edit</a></td>
        <td align="center"><?php echo $row_suppliers['Cashback']; ?></td>
      </tr>
      <?php } while ($row_suppliers = mysql_fetch_assoc($suppliers)); ?>
</table>

</body>
<?
include 'edit_supplier.php'
?>
</html>
<?php
mysql_free_result($suppliers);
?>

edit_supplier.php


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>


<H2>Edit Supplier</H2>


<?php


require 'Connections/conn_local.php';

$id = isset($_GET['id']) ? $_GET['id'] : NULL;
$name = isset($_GET['Name']) ? $_GET['Name'] : NULL;
$VATReg = isset($_GET['VATReg']) ? $_GET['VATReg'] : NULL;
$Cashback = isset($_GET['Cashback']) ? $_GET['Cashback'] : NULL;


$order = "SELECT * FROM suppliers WHERE id = '$id'";

$result = mysql_query($order);

$row_edit_supplier = mysql_fetch_array($result);


?>
<form action="suppliers.php" method="GET">
<table>
<tr>
<td>ID: -</td><td><input type="text" name="id"  disabled="disabled" value="<?php echo $row_edit_supplier['id']?>" /></td></tr>
<tr>
<td>Supplier Name: -</td><td><input type="text" name="Name" value="<?php echo $row_edit_supplier['Name']?>" /></td></tr>
<tr>
<td>Charge VAT: -</td><td><input type="text" name="VATReg" value="<?php echo $row_edit_supplier['VATReg']?>"/></td></tr>
<td>Cashback %: -</td><td><input type="text" name="Cashback" value="<?php echo $row_edit_supplier['Cashback']?>" /></td></tr>
<tr>
<td><input type="hidden" name="submitted" value="TRUE"/></td>
<td><input type="submit" name="edit" value="Edit Now" /></td>
</table>

</form>
<?php
if (isset($_POST['edit'])) {

$sql = "UPDATE suppliers SET 'Name' = '$name', 'VATReg' = '$VATReg', 'Cashback' = '$Cashback' WHERE 'id' = '$id'" ;

$update_result = mysql_query($sql);
}



?>
</body>
</html>

bradgrafelman

You're checking for a variable in the $_POST array, but that array will always be empty since your form doesn't use the POST method.

Furthermore, note that you should NEVER place user-supplied data directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. See [man]security.database.SQL-injection[/man] for more information.