Image conversion

[Judit1983]

I want to convert an uploaded JPG into PNG. I want to store the new file in the uploads/ directory
$ext is the extension of the uploaded file. $target_path is the uploads/ directory. How should I change the following code?

if ($ext='jpg' or $ext='jpeg')

{
switch ($target)
{
case "PNG";
$image = imagecreatefromjpeg($path);
imagepng($image, '.basename' . 'png', 100);
move_uploaded_file($image,$target_path);
break;
}
}

[Weedpacket]

If you don't want to keep the JPEG, you don't need [man]move_uploaded_file[/man]. Just use [man]imagecreatefromjpeg[/man] to read the uploaded JPEG, and [man]imagepng[/man] to save it (with the appropriate name) in the uploads/ directory.

[Judit1983]

Now my code works better but not perfect yet. The new *.png file is created and uploaded in the uploads/ directory but its size is 0 kb. What's wrong with my code?

imagecreate(200,200);
    $image=imagecreatefromjpeg('uploads/'.$filename);
        print ($path);
        print ($filename);
      imagestring($image,5,0,0,date("Y.m.d H:i:s"),10);
      imagepng($image,'uploads/' . $file . '.png',100);

[Judit1983]

I also got this error:

Warning: imagepng() [function.imagepng]: gd-png error: compression level must be 0 through 9 in C:\xampp\htdocs\imageconvert\function.php on line 65

[Judit1983]

I also got this error:

Warning: imagepng() [function.imagepng]: gd-png error: compression level must be 0 through 9 in C:\xampp\htdocs\imageconvert\function.php on line 65

[Weedpacket]

What the error message says: the PNG compression level must be 0 through 9 (see [man]imagepng[/man]). You're giving it 100.

[Judit1983]

Now I have the following error message:

Warning: imagepng() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\imageconvert\function.php on line 147

Warning: imagestring() expects parameter 1 to be resource, null given in C:\xampp\htdocs\imageconvert\function.php on line 148

Line 147 and 148 are

$newimage=imagepng($image,'uploads/' . $file . '.png',9);<?php

$_POST['target']."<br/>";
$_REQUEST['target'];

$filename=$_FILES["file"]["name"];
$filesize=$_FILES["file"]["size"];
$filetype=$_FILES["file"]["type"];
$tmp=$_FILES["file"]["tmp_name"];
$ext=strtolower(pathinfo($filename, PATHINFO_EXTENSION));
$file=strtolower(pathinfo($filename, PATHINFO_FILENAME));
$max_size=2097152;
$target_path="uploads/";
$option="";
$target=$_REQUEST['target'];
$path=$target_path . $filename;




if ($filesize>2097152)
    {
      echo "Fájl nem lehet nagyobb, mint 2MB";
    }
    else
    {
      if ($ext=='jpg' || $ext=='jpeg' || $ext=='png' || $ext=='bmp' ||$ext=='gif')
         {
            if (!is_dir('uploads'))
                {
                    mkdir('uploads');
                }
                else
                {
                    move_uploaded_file($_FILES["file"]["tmp_name"],"uploads/" . $_FILES["file"]["name"]);

            }
      }
      else
      {
        echo "Fájltípus nem megfelel&#337;.";
      }
}

$target=$_POST['target'];


// Ha a feltöltött fájl jpg formátumú

if ($ext='jpg' or $ext='jpeg')
{
switch ($target)
    {
      case "JPEG";
        echo "A cél- és a forrásfájl formátuma ugyanaz, így nem történt konvertálás";
      break;

  case "BMP";
    $image=imagecreatefromjpeg('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagewbmp($image,'uploads/' . $file . '.bmp',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

  case "PNG";
    $image=imagecreatefromjpeg('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagepng($image,'uploads/' . $file . '.png',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

  case "GIF";
    $image=imagecreatefromjpeg('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagegif($image,'uploads/' . $file . '.gif',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;


}
}

// Ha a feltöltött fájl png formátumú

if ($ext='png')
{
switch ($target)
    {
      case "JPEG";
        $image=imagecreatefrompng('uploads/'.$filename);
        print ($path);
        print ($filename);
        $newimage=imagpng($image,'uploads/' . $file . '.jpg',9);
        imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
        break;

  case "BMP";
    $image=imagecreatefrompng('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagewbmp($image,'uploads/' . $file . '.bmp',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
    break;

  case "PNG";
    echo "A cél- és a forrásfájl formátuma ugyanaz, így nem történt konvertálás";
  break;


  case "GIF";
    $image=imagecreatefrompng('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagegif($image,'uploads/' . $file . '.gif',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

}
}

// Ha a feltöltött fájl bmp formátumú

if ($ext='bmp')
{
switch ($target)
    {
      case "JPEG";
        $image=imagecreatefromwbmp('uploads/'.$filename);
        print ($path);
        print ($filename);
        $newimage=imagewbmp($image,'uploads/' . $file . '.jpg',9);
        imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
      break;

  case "BMP";
    echo "A cél- és a forrásfájl formátuma ugyanaz, így nem történt konvertálás";
  break;


  case "PNG";
    $image=imagecreatefromwbmp('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagepng($image,'uploads/' . $file . '.png',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

  case "GIF";
   $image=imagecreatefromwbmp('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagegif($image,'uploads/' . $file . '.gif',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

}
}

// Ha a feltöltött fájl  gif formátumú

if ($ext='gif')
{
switch ($target)
    {
      case "JPEG";
        $image=imagecreatefromgif('uploads/'.$filename);
        print ($path);
        print ($filename);
        $newimage=imagegif($image,'uploads/' . $file . '.jpg',9);
        imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
      break;

  case "BMP";
    $image=imagecreatefromgif('uploads/'.$filename);
    print ($path);
    print ($filename);

    $newimage=imagewbmp($image,'uploads/' . $file . '.bmp',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

  case "PNG";
    $image=imagecreatefromgif('uploads/'.$filename);
    print ($path);
    print ($filename);
    $newimage=imagepng($image,'uploads/' . $file . '.png',9);
    imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);
  break;

  case "GIF";
    echo "A cél- és a forrásfájl formátuma ugyanaz, így nem történt konvertálás";
  break;





}
}
?>
<html>
<head>
<body>

<br />
<br />
<br />
Az átkonvertált fájl.
<img src=" <?php echo $newimage; ?> alt="új kép" width="100px" height="100px" />;

<br />

</body>
</head>
</html>        imagestring($newimage,5,0,0,date("Y.m.d H:i:s"),10);

and also this error: Warning: imagecreatefromwbmp() [function.imagecreatefromwbmp]: 'uploads/017.JPG' is not a valid WBMP file in C:\xampp\htdocs\imageconvert\function.php on line 144

Line 144 is

$image=imagecreatefromwbmp('uploads/'.$filename);

The whole code is :

[Weedpacket]

Judit1983 wrote:

Line 147 and 148 are

That's a lot more than just lines 147 and 148. But if no image was created on line 144, there won't be a valid image on line 147.

Judit1983 wrote:

and also this error: Warning: imagecreatefromwbmp() [function.imagecreatefromwbmp]: 'uploads/017.JPG' is not a valid WBMP file in C:\xampp\htdocs\imageconvert\function.php on line 144

That's probably because 017.jpg is a JPEG image, not a WBMP image.