returning all urls from database

[borrarensson]

<title>Public Url Post</title>
<form action="" method="post">
URL:<input type="text" label="Url" name="url" /><br />
Title:<input type="text" label="Title" name="title" /><br />
<input type="submit" value="Submit Link" />
<?php
require 'connect.php';
error_reporting(0);
$url = $_POST['url'];
$title = $_POST['title'];
if (!isset($url, $title)){
echo 'Type a title and url please...';
} else {
mysql_query("INSERT INTO `pup` VALUES ('', '$url', '$title')");
}
?>

This code insert urls into a database, but how do i return ALL the urls and make a <a href=""></a><br /> list with all the urls?

[bradgrafelman]

borrarensson;11008691 wrote:

This code insert urls into a database

Yup, and it also:

1. Quietly hides any errors you may or may not be aware of

2. Doesn't check if external variables exist before attempting to use them

3. Is vulnerable to SQL injection attacks and/or just plain SQL errors

4. Doesn't check if the INSERT query was successful

5. Contains invalid HTML (INPUT elements don't have "label" attributes)

borrarensson;11008691 wrote:

how do i return ALL the urls and make a <a href=""></a><br /> list with all the urls?

Perform a SELECT query (one with no WHERE clause) and loop through the result set, outputting the appropriate HTML as you go.