Need help with error message

[leebrehm]

I would be ever grateful to get this to work...

Below is the first 21 of 261 lines.

When I go to website/lxadmin.php?admin=password, to access the admin page, I get an
error message. [You must supply your password]

The lxadmin.php should recognize the password value on lxconfig.php and it isn't.

Here is the code on lxconfig.php

//Your password for LX
$password = "1234567";

Here's the code on lxadmin.php

<?php
include 'lxconfig.php';

if($admin)
{
if ($admin != $password)
{
exit("Incorrect password");
}
}

if(!$admin)
{
exit("You must supply your password");
}

if($batchcheck)
{

MYSQL_CONNECT($dbserver,$dbuser,$dbpass) OR DIE("Unable to connect to database");
@mysql_select_db($dbname) or die("Unable to select database");

To test admin.php I deleted the below code and was able to log into lxadmin.php?admin (with no password) but then anyone could because I can't password protect the file in cpanel.

if($admin)
{
if ($admin != $password)
{
exit("Incorrect password");
}
}

if(!$admin)
{
exit("You must supply your password");

Thanks in advance,
Roy

[Weedpacket]

Where does [font=monospace]$admin[/font] come from? What is it's value? If it's from a form it needs to be either [font=monospace]$POST['admin'][/font] or [font=monospace]$GET['admin'][/font], depending on the method the form uses. See [man]variables.external[/man].

Also, note that to test whether a variable has a value you should be using [man]isset[/man]. You might also want to look at the [man]else[/man] statement to save yourself some coding.

[leebrehm]

The script has an admin page. To access the admin.php file I go to website/lxadmin.php?admin=password (replacing password with the
password value entered at lxconfig.php but I get the error message [You must supply your password]

I don't know where $admin comes from, I didn't write the script. I'm assuming there is an error somewhere between lines 4-15 because when
I delete them I can enter admin (website/lxadmin.php?admin) with no password.

[bradgrafelman]

leebrehm;11010727 wrote:

I don't know where $admin comes from

Neither does PHP, hence why you're having problems.

leebrehm;11010727 wrote:

I didn't write the script.

Perhaps you should contact the person who did? (Or, alternatively, find a new programmer to write a new script for you.)

leebrehm;11010727 wrote:

I'm assuming there is an error somewhere between lines 4-15

No need to assume anything - Weedpacket's already pointed out one critical issue; you're using a variable $admin even though you've never defined such a variable.

[NogDog]

It's likely either old code or written by someone who's not kept up to date with reasonably modern versions of PHP, and is depending on the now-deprecated register_globals setting (and depending on it poorly, as it still should be testing for existence instead of assuming it does).

For a quick test, trying changing all occurences of $admin to $REQUEST['admin'] and see if that helps. Also change this...

if($admin)

...to this...

if(isset($_REQUEST['admin']))