Variables nost posting from email.

JayNomad

I know this is an easy fix but I am getting lost in the code. someone please give me a hand. I have had this problem before and fixed it but i don't remember what I did.

This is what I get:

Emial:
Name:
Newest Randy/Randeen:
Favorite Nickname:
Best Quote:
Favorite Security:
BILF:
Favorite Bartender of The year:
Most Creative:
Party of the Year:
Favorite Drinking Buddies:
Funniest Drunk:
Biggest Drama Queen:
Nicest Drunk:
Loudest Drunk:
Best Drunken Moment:
King of Belltown:
Queen of Belltown:
Cutest Couple:
Drunk of The Year:

I had to delete part of the code but the answer can be found within what is here. Here is the code:

<?php
/ Subject and email Variables /

$emailSubject = 'Voter Ballots';
$webMaster = 'liljohnnyray@gmail.com';

/ gather data variable /

$nameField = $_POST['Name2'];
$emailField = $_POST['Email'];
$nomineeField = $_POST['form1'];
$nomineeField = $_POST['form2'];
$nomineeField = $_POST['form3'];
$nomineeField = $_POST['form4'];
$nomineeField = $_POST['form5'];
$nomineeField = $_POST['form6'];
$nomineeField = $_POST['form7'];
$nomineeField = $_POST['form8'];
$nomineeField = $_POST['form9'];
$nomineeField = $_POST['form10'];
$nomineeField = $_POST['form11'];
$nomineeField = $_POST['form12'];
$nomineeField = $_POST['form13'];
$nomineeField = $_POST['form14'];
$nomineeField = $_POST['form15'];
$nomineeField = $_POST['form16'];
$nomineeField = $_POST['form17'];
$nomineeField = $_POST['form18'];

$body = <<<EOD

<hr> 
Emial: $Email 
Name: $Name2 
Newest Randy/Randeen: $form1 
Favorite Nickname: $form2 
Best Quote: $form3 
Favorite Security: $form4 
BILF: $form5 
Favorite Bartender of The year: $form6 
Most Creative: $form7 
Party of the Year: $form8 
Favorite Drinking Buddies: $form9 
Funniest Drunk: $form10 
Biggest Drama Queen: $form11 
Nicest Drunk: $form12 
Loudest Drunk: $form13 
Best Drunken Moment: $form14 
King of Belltown: $form15 
Queen of Belltown: $form16 
Cutest Couple: $form17 
Drunk of The Year: $form18 
EOD;

$headers = "From: $Email\r\n";
$headers .= "Content-type: text/html\r\n";
$success = mail($webMaster, $emailSubject, $body, $headers);

/ results /

?>[/COLOR]

JayNomad

There should be information after the colon in received emails. This is the actual page: http://solograph.info/12AMballotphp.php

JayNomad

There is a lot more to this page than on this string but the forum said it was too long.

bradgrafelman

First thing I notice is that this:

$nomineeField = $_POST['form1'];
$nomineeField = $_POST['form2'];
$nomineeField = $_POST['form3'];
$nomineeField = $_POST['form4'];
$nomineeField = $_POST['form5'];
$nomineeField = $_POST['form6'];
$nomineeField = $_POST['form7'];
$nomineeField = $_POST['form8'];
$nomineeField = $_POST['form9'];
$nomineeField = $_POST['form10'];
$nomineeField = $_POST['form11'];
$nomineeField = $_POST['form12'];
$nomineeField = $_POST['form13'];
$nomineeField = $_POST['form14'];
$nomineeField = $_POST['form15'];
$nomineeField = $_POST['form16'];
$nomineeField = $_POST['form17'];
$nomineeField = $_POST['form18'];

might as well be written as this:

$nomineeField = $_POST['form18'];

since you're just constantly overwriting the value stored in $nomineeField without ever actually using the previous value.

EDIT: Then again, you might as well not even have that last statement since you don't appear to use $nomineeField even after the last assignment statement.

Second problem I notice is here:

$body = <<<EOD
<br><hr><br>
Emial: $Email <br>
Name: $Name2 <br>
Newest Randy/Randeen: $form1 <br>
Favorite Nickname: $form2 <br>
Best Quote: $form3 <br>
Favorite Security: $form4 <br>
BILF: $form5 <br>
Favorite Bartender of The year: $form6 <br>
Most Creative: $form7 <br>
Party of the Year: $form8 <br>
Favorite Drinking Buddies: $form9 <br>
Funniest Drunk: $form10 <br>
Biggest Drama Queen: $form11 <br>
Nicest Drunk: $form12 <br>
Loudest Drunk: $form13 <br>
Best Drunken Moment: $form14 <br>
King of Belltown: $form15 <br>
Queen of Belltown: $form16 <br>
Cutest Couple: $form17 <br>
Drunk of The Year: $form18 <br>
EOD;

None of the variables you use inside that heredoc string are defined. (You also attempt to use the undefined variable $Email when defining $header as well). These are all problems you should already know about, of course, assuming you've got display_errors (and/oor log_errors) set to On and error_reporting set to E_ALL or better.

JayNomad

The email field is defined its just not listed on this post. As far far as defining the variables in the string what do you suggest is missing. I have done it this particular way numerous times without error. I would like to know. I want to correct the error. Has this method been deprecated?

bradgrafelman

JayNomad;11012589 wrote:
The email field is defined its just not listed on this post.

Who said anything about an email field? I was referring to the $Email variable. If you've actually defined that variable elsewhere, then why are you hiding relevant PHP code from us?

JayNomad;11012589 wrote:
As far far as defining the variables in the string what do you suggest is missing.

Uh... Well how about a variable declaration statement for each variable? 🙂 If I create a blank PHP script that looks like:

<?php
echo $MyFavoriteColor;

would it surprise you to learn that PHP doesn't output green (despite that truly being my favorite color, supposing I had to pick one)? It shouldn't, because I never defined the variable $MyFavoriteColor.

JayNomad;11012589 wrote:
I have done it this particular way numerous times without error. I would like to know. I want to correct the error. Has this method been deprecated?

Sounds like you're suggesting that you've relied on the "register globals" functionality in the past, in which case yes, this method was deprecated long ago - see the manual page [man]security.globals[/man] to learn why this horrible "feature" should never have existed in the first place. Then see the page [man]variables.external[/man] to learn the proper way of accessing data from external sources (such as data POST'ed from a form).