I feel so dirty....

NogDog

...but sometimes laziness and schedule pressures win out. 🙂

function usage($errTxt=null, $errNo=99)
{
	global $reportNames; // yeah, I know...
	global $config;      // what...again?

(It's for a stand-alone command line script to run some reports that will probably not be re-used [famous last words], so I don't feel too terrible about it.)

Bonesnap

Heathen! :evilgrin:

Weedpacket

//environment state
global $centre;
global $colours;
global $controls;
global $diffuse;
global $invisible;
global $interaction;
global $lighton;
global $normal;
global $vertices;
global $zero;
// constraint state
global $clauses;
global $modifiers;
global $modWrapperSet;
global $newClauses;
global $newObjects;
global $outputStream;
global $recentClauses;
global $simplifyModNow;
global $substitutionRule;
global $tempDedSet;
global $tempModSet;

...But I'm in the middle of refactoring.

dalecosp

Weedpacket;11013473 wrote:

//environment state
global $centre;
global $colours;
global $controls;
global $diffuse;
global $invisible;
global $interaction;
global $lighton;
global $normal;
global $vertices;
global $zero;
// constraint state
global $clauses;
global $modifiers;
global $modWrapperSet;
global $newClauses;
global $newObjects;
global $outputStream;
global $recentClauses;
global $simplifyModNow;
global $substitutionRule;
global $tempDedSet;
global $tempModSet;

...But I'm in the middle of refactoring.

I just refactored a couple of site features. I'd probably feel dirty too, if I were smarter 😉

Practically, seems little difference between:

function foo($bar) {

}

and

function foo() {
   global $bar;
}

It appears I couldn't think about the features generically enough to create classes for them. :rolleyes:

Derokorian

Dale the difference would be now you can change the value of a globally available variable from within the function, instead of just passing that value to the function and therefore the value outside the function can't be changed from within the function (unless you pass it by reference) and also removes the dependency of the function on a variable being available outside of its scope, which tightly couples it to the rest of the app. However if you look at any of my sites written before before mid 2010 or so, they almost all rely on globals and its gross =D instead of a db class or something I have tons of functions getThisByThat($var) { Global $DBCONN; ... }

Weedpacket

dalecosp wrote:
Practically, seems little difference between:

That's what I'm doing; going from

function foo($x, $y, $z)
{
    global $bar, $baz;
    //...
}

//...
foo($a, $b, $c);

function foo($x, $y, $z, &$bar, &$baz)
{
    //...
}

//...
global $bar, $baz; // Rinse and repeat
foo($a, $b, $c, $bar, $baz);

And look to see how the variables clump together and where they like to hang out. Another step is to drop the reference if they're read-only, and to adjust the return value if they aren't:

function foo($x, $y, $z, $bar, $baz)
{
    //...
    return [$bar, $baz];
}

//...
global $bar, $baz;
list($bar, $baz) = foo($a, $b, $c, $bar, $baz); // '[$bar, $baz] = ...' would be cleaner, but that's not in the language yet.

And that gives a potential proto-object (let's see how often it shows up).