Copy file from a file

[tutaste]

Hello,

I'm sorry, my English is bad

My example links_data.txt

http://www.ciceksehri.com/wp-content/uploads/2011/03/5888cicek6.jpg
http://www.hediyecicek.com.stabilisim.com/r/buyuk_urun_resimi/3222.jpg
http://www.ciceksehri.com/wp-content/uploads/2011/03/cicek_0011.jpg
http://www.ciceksehri.com/wp-content/uploads/2010/11/kirmizi-pueskuellue-cicek-resmi.jpg
http://www.cicekresimleri.org/data/media/72/masaustucicekresimleri3.jpg
http://www.baylar.net/cicek_resimleri/cicekresimleri13.jpg

This is my codes

<?php
function readUrls()
{
// Reads links from a file  

$read_dir="./";
$read_file="links_data.txt"; 
$connect_to_red=@fopen ("$read_dir/$read_file",'r');
if(!$connect_to_red)
  { 
      echo "could not open database"; 
      exit(); 
  } 
while(!feof($connect_to_red))
  { 
      $read=fgets($connect_to_red,1024); 
      $url[] = $read;
  } 
@fclose($connect_to_red);
return $url;
}

function makeFolders($url)
{
// Creates folders of Links
if(is_array($url) && !empty($url))
  foreach($url as $url_new)
    {
      $path = explode('/',dirname($url_new),4);
      $dirspath = array('./'.$path[count($path)-1].'/');
      $dirspath2 = array($path[count($path)-1]);

  for($i=0;$i<count($dirspath);$i++)
    {
      $fullDir = $dirspath[$i];
      exec("mkdir -p ".$fullDir);
      $dirs=explode("/",$fullDir);
      $currentFolder='';
      for($x=0;$x<count($dirs);$x++)
        {
          $currentFolder.=$dirs[$x].'/';
          if(!is_dir($currentFolder))
            {
              echo "Created: $currentFolder <br/>";
              if(!mkdir($currentFolder))
                {
                  die("Could not make ".$currentFolder);
                }
            }
        }
    }
}   
}

function moveLinks($url)
{
// Moved files of Links
echo '<ol>';

$record_directory = './test_folder/'; 
for($i=0;$i<count($url)-1;$i++)
  {
      $file_name = basename($url[$i]);
      if(copy($url[$i],$record_directory.$file_name))
        {
            echo '<li><b>File Uploaded:</b> ';
            echo $file_name;
            echo '<br /></li>';
        }
      else
        {
            echo '<li>error</li>';
        }
  }
echo '</ol>';
}

$urls = readUrls();
makeFolders($urls);
moveLinks($urls);
?>

Problem this see: http://d1209.hizliresim.com/11/t/dcksp.png

Please help

Thanks

[dalecosp]

Looks as if PHP is complaining because you're calling [man]copy/man on a remote file without establishing a stream_context 😉

[bradgrafelman]

dalecosp;11013765 wrote:

Looks as if PHP is complaining because you're calling [man]copy/man on a remote file without establishing a stream_context 😉

Not at all. The web-related failures are due to one 400 (bad request) and three 404 (not found) error responses.

Note that all of those error messages show a whitespace character between the end of the file name and the right ')' parenthesis in the error message. As such, I would bet that you've got some trailing whitespace on the URLs being passed to copy(). Thus, either [man]trim[/man] those URLs or see that they're formed correctly in the first place (e.g. don't append trailing whitespace even if such whitespace exists in the text file to improve readability).

[NogDog]

To quote the manual page for fgets() (my emphasis):

"Reading ends when length - 1 bytes have been read, on a newline (which is included in the return value), or on EOF (whichever comes first). If no length is specified, it will keep reading from the stream until it reaches the end of the line."

trim() or rtrim() could be your friend in this case.

[bradgrafelman]

One improvement that may even resolve the issue above is: Get rid of the fopen/feof/fgets/fclose() calls in readUrls() and instead use a single call to [man]file/man with the FILE_IGNORE_NEW_LINES flag.

[tutaste]

Hi all,

Thank you very much

I added "trim()" and the problem has solved.

$url[] = $read;

$url[] = trim($read);

[tutaste]

Hi again to everyone,

I have a question,

To skip empty lines, How do I perform this? "FILE_SKIP_EMPTY_LINES"

<?php
function readUrls()
{
// Reads links from a file  

$read_dir="./";
$read_file="links.txt"; 
$connect_to_red=@fopen ("$read_dir/$read_file",'r');
if(!$connect_to_red)
  { 
      echo "could not open database"; 
      exit(); 
  } 
while(!feof($connect_to_red))
  { 
      $read=fgets($connect_to_red,1024); 
      $url[] = trim($read);
  } 
@fclose($connect_to_red);
return $url;
}

?>

Thanks

[bradgrafelman]

Easiest way would be to refactor that function to use [man]file/man rather than the various fopen/feof/fgets/fclose() functions as I suggested before.

[tutaste]

I am inexperienced. please an example?

[Weedpacket]

There's one on the [man]file[/man] manual page.