php user image upload create specified folder unique image names

[fab_t]

I'm (a newbie in php) still working on a time off project and another problem came up, for which I can't find a solution. Therefore I hope u guys can help me! Worked great the last time I posted something on here! I really appreciate your help...thx ahead!

My 1st problem: I want users to be able to upload pictures when they are logged in. They got several little buttons on their profile with images on them...and they should be able to change them... I want to have it like this -> When a user uploads an image, the script shall create a new folder on the server. This shall happen in the "user_images" folder (that exists already). So a user with e.g. "id=55" creates a folder "55" in "user_images" when he uploads images. I tried and tried and tried and tried...with different syntax in line -> "$upload_dir = but without any success" :-/ I just don't get it to work...

Next problem is: each button picture shall get a unique filename cuz I'll connect that value with a database. If he changes button image No.1, it should get the prefix_name ->button1.

And another problem I can't figure out how to fix...the script below ...it kinda works already...

When I upload an image and hit the upload button the browser shows me this ->

Warning: imagecreatetruecolor() [function.imagecreatetruecolor]: Invalid image dimensions in /users/uploadimage.php on line 52

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /users/uploadimage.php on line 67

Warning: imagepng(): supplied argument is not a valid Image resource in /users/uploadimage.php on line 80

Warning: Cannot modify header information - headers already sent by (output started at /users/uploadimage.php:52) in /users/uploadimage.php on line 223

But if I refresh and send the form again it shows me "Cannot display this page..." And another refresh gets me to see the page where I can see the uploaded file and where I'm able to make a selection and crop....and save it.

Here is the a part of the script:

<?php
include 'dbconfig.php';
page_protect();

$rs_settings = mysql_query("select * from user where id='$_SESSION[user_id]'");
while ($row_settings = mysql_fetch_array($rs_settings));


error_reporting (E_ALL ^ E_NOTICE);
session_start();
//only assign a new timestamp if the session variable is empty
if (!isset($_SESSION['user_id']) || strlen($_SESSION['user_id'])==0){
$_SESSION['user_id'] = mysql_query("select * from user where id='$_SESSION[user_id]'");         

//assign the timestamp to the session variable
$_SESSION['user_file_ext']= "";
}

$upload_dir = "user_images/";
$upload_path = $upload_dir;             

$large_image_prefix = "Large_";         

$thumb_image_prefix = "button_";            

$large_image_name = $large_image_prefix.$_SESSION['user_id'];    

image (append the timestamp to the filename)
$thumb_image_name = $thumb_image_prefix.$_SESSION['user_id'];     

image (append the timestamp to the filename)
$max_file = "1";    // Maximum file size in MB
$max_width = "";    // Max width allowed for the large image
$thumb_width = "87"; // Width of thumbnail image
$thumb_height = "35";   // Height of thumbnail image
// Only one of these image types should be allowed for upload
$allowed_image_types =     

array('image/pjpeg'=>"jpg",'image/jpeg'=>"jpg",'image/jpg'=>"jpg",'image/png'=>"png",
'image/x-png'=>"png",'image/gif'=>"gif");
$allowed_image_ext = array_unique($allowed_image_types); // do not change this
$image_ext = "";    // initialise variable, do not change this.
foreach ($allowed_image_ext as $mime_type => $ext) {
$image_ext.= strtoupper($ext)." ";
}

function resizeImage($image,$width,$height,$scale) {
list($imagewidth, $imageheight, $imageType) = getimagesize($image);
$imageType = image_type_to_mime_type($imageType);
$newImageWidth = ceil($width * $scale);
$newImageHeight = ceil($height * $scale);
$newImage = imagecreatetruecolor($newImageWidth,$newImageHeight);
switch($imageType) {
case "image/gif":
$source=imagecreatefromgif($image); 
break;
case "image/pjpeg":
case "image/jpeg":
case "image/jpg":
$source=imagecreatefromjpeg($image); 
break;
case "image/png":
case "image/x-png":
$source=imagecreatefrompng($image); 
break;
}
imagecopyresampled($newImage,$source,0,0,0,0,$newImageWidth,$newImageHeight,
$width,$height);
switch($imageType) {
case "image/gif":
imagegif($newImage,$image); 
break;
case "image/pjpeg":
case "image/jpeg":
case "image/jpg":
imagejpeg($newImage,$image,90); 
break;
case "image/png":
case "image/x-png":
imagepng($newImage,$image);  

break;
}
chmod($image, 0777);
return $image;
}

function resizeThumbnailImage($thumb_image_name, $image, $width, $height, $start_width,   

$start_height, $scale){
list($imagewidth, $imageheight, $imageType) = getimagesize($image);
$imageType = image_type_to_mime_type($imageType);

$newImageWidth = ceil($width * $scale);
$newImageHeight = ceil($height * $scale);
$newImage = imagecreatetruecolor($newImageWidth,$newImageHeight);
switch($imageType) {
case "image/gif":
$source=imagecreatefromgif($image); 
break;
case "image/pjpeg":
    case "image/jpeg":
    case "image/jpg":
        $source=imagecreatefromjpeg($image); 
        break;
    case "image/png":
    case "image/x-png":
        $source=imagecreatefrompng($image); 
        break;
}
imagecopyresampled($newImage,$source,0,0,$start_width,$start_height,$newImageWidth,
$newImageHeight,$width,$height);
switch($imageType) {
case "image/gif":
imagegif($newImage,$thumb_image_name); 
break;
case "image/pjpeg":
case "image/jpeg":
case "image/jpg":
imagejpeg($newImage,$thumb_image_name,90); 
break;
case "image/png":
case "image/x-png":
imagepng($newImage,$thumb_image_name);  

break;
}
chmod($thumb_image_name, 0777);
return $thumb_image_name;
}

function getHeight($image) {
$size = getimagesize($image);
$height = $size[1];
return $height;
}

function getWidth($image) {
$size = getimagesize($image);
$width = $size[0];
return $width;
}


$large_image_location = $upload_path.$large_image_name.$_SESSION['user_file_ext'];
$thumb_image_location = $upload_path.$thumb_image_name.$_SESSION['user_file_ext'];


if(!is_dir($upload_dir)){
mkdir($upload_dir, 0777);
chmod($upload_dir, 0777);
}


if (file_exists($large_image_location)){
 if(file_exists($thumb_image_location)){
    $thumb_photo_exists = "<img
src=\"".$upload_path.$thumb_image_name.$_SESSION['user_file_ext']."\" alt=\"Thumbnail   

Image\"/>";
}else{
 $thumb_photo_exists = "";
}
$large_photo_exists = "<img  

src=\"".$upload_path.$large_image_name.$_SESSION['user_file_ext']."\" alt=\"Large   

Image\"/>";
} else {
$large_photo_exists = "";
$thumb_photo_exists = "";
}

if (isset($_POST["upload"])) { 
//Get the file information
$userfile_name = $_FILES['image']['name'];
$userfile_tmp = $_FILES['image']['tmp_name'];
$userfile_size = $_FILES['image']['size'];
$userfile_type = $_FILES['image']['type'];
$filename = basename($_FILES['image']['name']);
$file_ext = strtolower(substr($filename, strrpos($filename, '.') + 1));

//Only process if the file is a JPG, PNG or GIF and below the allowed limit
if((!empty($_FILES["image"])) && ($_FILES['image']['error'] == 0)) {

foreach ($allowed_image_types as $mime_type => $ext) {
    //loop through the specified image types and if they match the     
extension then break out
        //everything is ok so go and check file size
        if($file_ext==$ext && $userfile_type==$mime_type){
            $error = "";
            break;
        }else{
            $error = "Only <strong>".$image_ext."</strong> images accepted for upload<br />";
        }
    }
    //check if the file size is above the allowed limit
    if ($userfile_size > ($max_file*1048576)) {
        $error.= "Images must be under ".$max_file."MB in size";
    }

}else{
    $error= "Select an image for upload";
}
//Everything is ok, so we can upload the image.
if (strlen($error)==0){

if (isset($_FILES['image']['name'])){
    //this file could now has an unknown file extension (we hope it's one of the ones set above!)
    $large_image_location = $large_image_location.".".$file_ext;
    $thumb_image_location = $thumb_image_location.".".$file_ext;

    //put the file ext in the session so we know what file to look for once its uploaded
    $_SESSION['user_file_ext']=".".$file_ext;

    move_uploaded_file($userfile_tmp, $large_image_location);
    chmod($large_image_location, 0777);

    $width = getWidth($large_image_location);
    $height = getHeight($large_image_location);
    //Scale the image if it is greater than the width set above
    if ($width > $max_width){
        $scale = $max_width/$width;
        $uploaded = resizeImage($large_image_location,$width,$height,$scale);
    }else{
        $scale = 1;
        $uploaded = resizeImage($large_image_location,$width,$height,$scale);
    }
    //Delete the thumbnail file so the user can create a new one
    if (file_exists($thumb_image_location)) {
        unlink($thumb_image_location);
    }
}
//Refresh the page to show the new uploaded image
header("location:".$_SERVER["PHP_SELF"]);
exit();
}
?>

It would be really cool if someone could help me to fix these problems...you may know how hard it is, when you're just a rookie! If there's more weird syntax in there...let me know, I'm just a beginner (like we all have been at the beginning) and trying to get better 🙂

Thank you guys!

[sfullman]

hi fab, so one thing I hate is "post killers and poisoners" who I spend time writing an extensive post and they reply with something like - "Man, that sounds rough! Hope you get that figured out" or "Why would you want to do it that way, you beneath-my-intelligence person you?"

So at the risk of doing same, I will say first of all and the seasoned vets will agree: you should separate a post into bite-sized chunks, and this is a 7-course meal. If you will do the trouble-shooting and isolate down to a specific issue and point of failure, you are more likely to get someone who can see the problem and offer advice.

As far as naming the image, I do have two suggestions:
1. make sure directory indexing is turned off and you have a index.html file in the root - so nobody can see anyone else's images
2. a good naming convention would be 6 random hex characters before "their" file name, for example 4fcd9e_cabo_vacation_2012.jpg or e96d00_2012_budget.pdf - store this code in a table in a database somewhere. Short of tunneling your images through a readfile() emulator, this offers great security against seeing any picture except which and to whom your program wants it to be seen by.

Now as far as sizing images, I'm going to give away some code:

//here is all the code you need  to shrink an image into a box and center/crop:

$resource=create_thumbnail($_FILES['fieldname']['tmp_name'], $shrink=.75, $crop='', $location='returnresource', $options=array());
//here is some coding that makes no sense out of context, replace as needed :)
$left=$thumbLeft-$imgLeft;
$top=$thumbTop-$imgTop;
//2nd pass - create the file from the resource above
$newfile='/images/55/'.$token.'_'.$filename.'.jpg';
create_thumbnail($resource, '', array($left, $top, $left+$thumbWidth, $top+$thumbHeight), $GLOBALS['DOCUMENT_ROOT'].$newfile);

//and here is the function needed for the code above:
define('CREATE_THUMBNAIL_DEBUG',1); //email if problems
$functionVersions['create_thumbnail_getneededmemory']=2.00;
function create_thumbnail_getneededmemory($width, $height, $truecolor=1){
	/* this function adjusts memory limit up to max memory allowable in config.php */
	global $create_thumbnail;

  return $width*$height*(2.2+($truecolor*3));
}
$functionVersions['create_thumbnail']=2.00;
function create_thumbnail($file, $shrink='', $crop='', $location='', $options=array()){
	/*
	2011-08-20 - added option dimsOnly=true - returns the actual pixel size calc only
	2009-03-24 - modified successful return of create thumbnail to be array(w,h) vs just true
	2008-10-28 - too beautiful to touch - this thing is great!  But I can't do a 2-wall box in one operation, so it is done in two calls to this.  Did do some slight coding mods
	* added option stretchImage for when the image is smaller than the box
	Created 2008-02-11 - bit more of the promised land with image manipulation incl. cropping; this is  a radical departure from v1.00 - parameters passed are different

if (location=returnresource), the function returns a resource which if passed to the function again, will be sufficient to perform a 2nd operation on the same image. The goal here is to have this function do all the major features that Picasa does, and then store a history of mods to an image somewhere, say in session.  We then can go forward or back through the process via the steps :)

region is (x,y) for the top left and (x,y) for the bottom right of a crop area - ON THE ORIGINAL DIMENSIONS, not the resized dimensions
shrink can be a containing box (150,200) or a percentage to shrink (.75)
*/
global $cttest, $create_thumbnail, $developerEmail, $fromHdrBugs, $test;
@extract($options);
if(is_array($file)){
	$gis=$file[1];
}else{
	if(!($gis=@getimagesize($file))){
		if(CREATE_THUMBNAIL_DEBUG)mail($developerEmail,'Error file '.__FILE__.', line '.__LINE__,get_globals(),$fromHdrBugs);
		return false;
	}
}
//this is an image
$contentType=$gis['mime'];
$mime=explode('/',$contentType);
$mime=$mime[1]; //lower case
$createFrom='imagecreatefrom'.$mime;
$output='image'.$mime;
$width=$gis[0];
$height=$gis[1];

// Get box dimensions from $shrink variable
if(is_array($shrink)){
	$boxWidth=$shrink[0];
	$boxHeight=$shrink[1];
}else if(preg_match('/^[0-9]+,[0-9]+$/',$shrink)){
	$a=explode(',',$shrink);
	$boxWidth=$a[0];
	$boxHeight=$a[1];
}else{
	if(!$shrink)$shrink=1;
	//normally a decimal like .33
	$boxWidth=round($width * $shrink);
	$boxHeight=round($height * $shrink);
}
//buffer against division by zero
ob_start();
if($height > $boxHeight || $width > $boxWidth || $stretchImage){
	if(@$height/$boxHeight > $width/$boxWidth){
		//the object is more prominent y-wise than x-wise compared to the box; use the box height as a basis
		$newHeight=$boxHeight;
		$newWidth= floor($width * ($boxHeight/$height));
		$shrink=round($boxWidth/$width, 5);
	}else{
		//the object is more prominent x-wise than y-wise compared to the box
		$newWidth=$boxWidth;
		$newHeight= floor($height * ($boxWidth/$width));
		$shrink=round($boxHeight/$height, 5);
	}
}else{
	//we could include a setting here to expand the image to fit the box
	$shrink=1;
	$newHeight=$height;
	$newWidth=$width;
}
$err=ob_get_contents();
ob_end_clean();
if($err && CREATE_THUMBNAIL_DEBUG)mail($developerEmail,'Error file '.__FILE__.', line '.__LINE__,get_globals(),$fromHdrBugs);

//2011-08-20
if($dimsOnly) return array($newWidth,$newHeight,$shrink);

$a=$b=0; //upper left corner
if($crop){
	if(!is_array($crop)){
		$crop=explode(',',$crop);
		foreach($crop as $n=>$v)$crop[$n]=trim($v);
	}
	list($a,$b,$c,$d)=$crop;
	$x=round(($c-$a) * $shrink);
	$y=round(($d-$b) * $shrink);

	//create new image resource, and modify the getimagesize parameters
	$result = imagecreatetruecolor($x, $y);
	$white = imagecolorallocate($result, 255,255,255);
	imagefill($result, 0,0, $white);
	$gis[0]=$x;
	$gis[1]=$y;
}else{
	$result = @imagecreatetruecolor($newWidth, $newHeight);
	$white = @imagecolorallocate($result, 255,255,255);
	@imagefill($result, 0,0, $white);
	$gis[0]=$newWidth;
	$gis[1]=$newHeight;
}
//----------------------------------
if(!function_exists($createFrom)){
	mail($developerEmail,'Unrecognized function in create_thumbnail file '.__FILE__.', line '.__LINE__,get_globals(), $fromHdrBugs);
	return false;
}
// Resample
if(is_array($file)){
	$source = $file[0];
}else{
	if($width*$height * 6.6 > 110*1024*1024){
		echo $width . ':' . $height;
		echo 'cannot allocate memory('.$width*$height * 6.6 . ')';
		return false;
	}else if($width*$height * 6.6 > 40*1024*1024){
		$revertMemory=ini_get('memory_limit');
		ini_set('memory_limit','110M');
	}
	$source = $createFrom($file);
}
@$r=imagecopyresampled($result, $source, 0, 0, $a, $b, $newWidth, $newHeight, $width, $height);
if($revertMemory){
	mail($developerEmail,'Memory limit issue file '. __FILE__.', line '.__LINE__,'Memory usage: '.memory_get_usage()."\n\n".get_globals(),$fromHdrBugs);
	ini_set('memory_limit',$revertMemory);
}

// Output
if($location=='returnresource'){
	//return the modifed image pointer, and the parameters
	return array($result, $gis);
}else if($location){
	//jpeg, gif, png
	$output($result,$location);
	if(file_exists($location)) return array($newWidth, $newHeight);
	return false;
}else{
	header('Content-type: '.$contentType); //jpeg, gif, png
	$output($result, null, 100);
	return array($newWidth, $newHeight);
}
}

$functionVersions['create_thumbnail_scalecrop']=1.00;
function create_thumbnail_scalecrop($path,$g,$w_h,$el_1,$tee_1,$el_2,$tee_2,$options=array()){
	/*
	created 2012-08-07 SF - combo scale and crop function
	location=returnresource || filename || stream(default)
	NOTE that this does not check for valid image, or valid dimensions
	*/
	global $suppressNormalIframeShutdownJS, $assumeErrorState;
	extract($options);
	if ($w_x && $w_x < $g[0]){
		$w=$w_x;
		$h=round($w_x / $g[0] * $g[1], 0);
	}else{
		$w=$g[0];
		$h=$g[1];
	}
	$scaled = imagecreatetruecolor($w, $h); 
	$source = imagecreatefromjpeg($GLOBALS['DOCUMENT_ROOT'].$path); 
	imagecopyresized($scaled, $source, 0, 0, 0, 0, $w, $h, $g[0], $g[1]);
	//prn(($el_2-$el_1) . ':' .($tee_2 - $tee_1),1);
	$cropped = imagecreatetruecolor($el_2 - $el_1, $tee_2 - $tee_1);
	imagecopy($cropped, $scaled, 0, 0, $el_1, $tee_1, $el_2, $tee_2);
	if(!$location){
		header('Content-Type: image/jpeg'); 
		imagejpeg($cropped); 
		$suppressNormalIframeShutdownJS=true;
		$assumeErrorState=false;
		exit;
	}else if($location=='returnresource'){
		error_alert('not developed');
	}else{
		if(imagejpeg($cropped,$location)) return true;
		return false;
	}
}

hope that helps some. Again, BREAK POSTS DOWN, and when you get good at this, give back to the community. I make it a point whenever I ask a question to browse the forum for people needing help also.

Sam