Dealing with arrays and keys...

Jwrbloom

I can never really get my head wrapped around arrays and keys, and in this instance, I'm not sure a "foreach" loop helps me (or at least helps me without rewriting code).

Here is the page in question:
http://metroindybasketball.com/resources/league2012/2012rosters.php

What I want it to do is, where you see A1, A2, A3, etc, I want it to say:

A1 - Coach Brett Crist
A2 - Coach Paul Gosser
etc

Here is my code: (Where it says $nameCoach, that's just sort of a place holder at the moment to keep it from showing errors. I've tried several things there, including messing with key() and current().)

echo '<div class="roster"><table width="500">

<thead>
  <tr>
    <th>#</th>
    <th>Team - Coach</th>
    <th>HT</th>
	<th>GR</th>
    <th>City (School)</th>
    <th>College</th>
	</tr>
</thead>

<tbody>
';

$coach = array (
'A1' =>'Coach Brett Crist',
'A2' =>'Coach Paul Gosser',
'A3' =>'Coach Brian Tonsani',
'B1' =>'Coach Dustin Harvey',
'B2' =>'Coach Kyle Smith',
'B3' =>'Coach Trevor Andershock',
'C1' =>'Coach Jim Reamer',
'C2' =>'Coach Aaron Butcher',
'C3' =>'Coach Bob Cerbone',
'D1' =>'Coach Larry Baker',
'D2' =>'Coach John Tate',
'D3' =>'Coach Victor Stallworth',
'E1' =>'Coach Mark Bailey',
'E2' =>'Coach Angelo Smith',
'E3' =>'Coach Mike Lawson',
'E4' =>'Coach Jeremy Tiers',
'F1' =>'Coach Aaron Butcher',
'F2' =>'Coach Duke Pryor',
'F3' =>'Coach Damon Hawkins',
'F4' =>'Coach Roy Hairston',
'G1' =>'Coach Kristof Kendrick',
'G2' =>'Coach Michael Tucker',
'G3' =>'Coach Kenton Granger',
'G4' =>'Coach Steve Turner',
'H1' =>'Coach Seve Beach',
'H2' =>'Coach Matt Lacey',
'H3' =>'Coach Derrick Gentry',
'H4' =>'Coach Kayle Funkhouser',
'I1' =>'Coach Courtney James',
'I2' =>'Coach Barry Kroot',
'I3' =>'Coach Chris Hawkins',
'J1' =>'Coach Chris Sibila',
'J2' =>'Coach Larry Baker',
'J3' =>'Coach Dan Schukraft'
);

$query = 'SELECT * FROM fallLeague10 WHERE 2012team IS NOT NULL ORDER BY 2012team,2012number';
$results = mysql_query($query) //or trigger_error('MySQL error: ' . mysql_error())
;


$currentTeam = false; 

while($line = mysql_fetch_assoc($results)) {


$coach = $line['2012team'];


    if($currentTeam != $coach)
    {

        //Status has changed, display status header
        $currentTeam = $line['2012team'];
		echo '<tr><td colspan="6"><hr></td></tr>
		<tr><td colspan="6"><span class="coach">'. $coach . ' - ' .$nameCoach. '</td></tr>
		';



	}

echo '<tr>
                    <td>' . $line['2012number'].'</td>
		<td><b>' . $line['nameFirst'] . ' ' . $line['nameLast'] . '</b></td>
		<td><center>'. $line['feet'] . '\'' . $line['inches'] . '"</center></td>
		<td><center>'. $line['grade'] . '</center></td>		
		<td>'. $line['school'] . '</td>';

           echo '<td><b>'. $line['college'].'</b></td>';

	echo '</tr>';}

        echo '</tbody></table>';

Weedpacket

Well, you have that array (which would probably be better handled by storing it in the database so that it can be used in the query), but you don't do anything with it - you blow it away as soon as you write

$coach = $line['2012team'];

No, you don't need a foreach() loop here: you already have the loop.

Replace the line I quoted above with

$namecoach = $line['2012team'][$coach];

Though, as I said before, it would be tidier to have that array in a table, and make the connection in the database query.

Jwrbloom

I did that and received about 300 (one for each player) instances of this error:

Warning: Illegal offset type in /home/jwrbloom/public_html/metroindybasketball.com/resources/league2012/2012rosters.php on line 74

Weedpacket

Oh, yeah, sorry.

$namecoach = $coach[$line['2012team']];

I'm assuming that $line['2012team'] (i.e. the values in the "2012team" column in the table) are things like "E3", "J1", and so on. Incidentally, that column name looks like (another) symptom of poor database design. Next year are you going to add more columns to the table, and rewrite all your code to replace "2012" with "2013"?

Jwrbloom

Where should I put that line? I replaced $coach = $line['2012team']; with it.

What I got is below (it's in table form in the browser). Instead of the team number and coache's name, it just says Array.

Team – Coach HT GR City (School) College

Array –
3 Will Schultz
5’2″
2017
Clinton Central
Array –
6 Grant Neterer
5’5″
2016
Noblesville
Array –
17 Tyler Wolfe
5’10″
2016
Fishers
Array –
36 Cameron Rigley
5’10″
2016
Fishers

To answer your question, I'll likely add columns in the future. I'd like to keep an archive of league rosters, so I decided to do it that way. 2012team could be broken down to 2012pool, which would be the letter, while 2012team would just be the number. I could do that going forward if you think that would help, but this is the extent to which this database is used.

Weedpacket

Smarter would be another column in the table - one that contains the year. Then you wouldn't need to add new columns every year (and have most of them empty, because in 2013 what would you be putting in "2012team"?)