Contact Form

Nickos

Hi to all in this nice forum,

I have a problem with my contact form, and as I am very new in php
I ask help from everybody.
Contact form works nice, but when I click the send button nothing happens.
Some problem must be in the contact.php.
I would be greatful to everybody who helps me...
Thanks a lot
Here is the code of the form:

            <span style="display:inline;position:relative;top:20px;right:-2px;color:red;">*</span> 
            <input class="text" type="text" name="name" id="name" value="Name:" onBlur="if(this.value=='') this.value='Name:'" onFocus="if(this.value =='Name:' ) this.value=''">
            <span style="display:inline;position:relative;top:20px;right:-2px;color:red;">*</span> 

            <input class="text" type="text" name="email"  id="email" value="Email:" onBlur="if(this.value=='') this.value='Email:'" onFocus="if(this.value =='Email:' ) this.value=''">
            <span style="display:inline;position:relative;top:20px;right:-2px;color:red;">*</span>  
            <input class="text" type="text" name="telephone"  id="telephone"  value="Telephone:" onBlur="if(this.value=='') this.value='Telephone:'" onFocus="if(this.value =='Telephone:' ) this.value=''">
            </div>


                        <div class="column-2">

            <span>&nbsp;</span>
            <input class="text" style="width:255px" type="text" name="subject" id="subject" value="Subject:" onBlur="if(this.value=='') this.value='Subject:'" onFocus="if(this.value =='Subject:' ) this.value=''">
            <span style="display:inline;position:relative;top:20px;right:-2px;color:red;">*</span>   
            <textarea class="text" name="message" id="message" value="Message:'" onBlur="if(this.value=='') this.value='Message:'" onFocus="if(this.value =='Message:' ) this.value=''">Message:</textarea>


                            <div class="captcha">
                            <center>
                   Insert Security Code<br />          
    <img src="Captcha/CaptchaSecurityImages.php?width=100&height=40&characters=5" />
    <p></p>


            <input id="security_code" name="security_code" type="text" />
    </center>


                                    <div class="buttons">

                               <a class="button" href="#" onClick="document.getElementById('form-main2').reset()">Clear</a>
                               <a class="button" href="#" onClick="document.getElementById('form-main2').submit()">Send</a>

                                          </div>
                      </div>
                    </div>
                </fieldset>                   
            </form>

And here is contact.php

<?php
session_start();
$name = @$POST['name'];
$email = @$POST['email'];
$message = @$POST['message'];
if( isset($POST['submit'])) {
if (! ereg('[A-Za-z0-9-]+@[A-Za-z0-9-]+.[A-Za-z0-9-]+', $email))
{
header("Location: contact_error.html");
exit;
}
if (!$name or !$message){
header("Location: contact_error.html");
exit;
}
if( $SESSION['security_code'] == $POST['security_code'] && !empty($SESSION['security_code'] ) ) {
// Insert you code for processing the form here, e.g emailing the submission, entering it into a database.
$your_email = "my@male.com";

            $headers= "From: ".$_POST['name']." <".$_POST['email'].">\r\n";
            $headers.='Content-type: text/html; charset=utf-8';
            mail($your_email, $_POST['subject'],  "

<html>
<head>
<title>Contact Message</title>
</head>
<body>
Contact Message<br><br>
Name : ".$POST['name']."<br>
Email : ".$POST['email']."<br>
Message : <br>".$POST['message']."<br>
</body>
</html>" , $headers);
header("Location: contact_message.htm");
unset($SESSION['security_code']);
} else {
// Insert your code for showing an error message here
//echo 'Sorry, you have provided an invalid security code';
header("Location: contact_wrong.html");
}
}
?>

sneakyimp

It would be easier to help you if you bothered to use the code formatting buttons when posting some code -- really hard to read otherwise.

Also "nothing happens" is not very specific. Does your browser load contact.php? Is that page blank? Does the form fail to submit entirely?

Ashley_Sheridan

First thoughts on the PHP code:

The way you're checking for a "valid" email is pretty awful, and blocks tons of legitimate email addresses and allows invalid ones. Try using the filter_var() function instead, there's no point re-inventing the wheel.

Using @ the way you have on $_POST variables and then checking to see if they auto-type to true is not recommended. Use isset() instead, and then once they pass that point assign the values into variables.

You're not checking to see if $_POST['security_code'] exists before you see if it's the same as your session value, and you're checking to see if the session value is empty AFTER you try to use it. Try putting a flow diagram down on paper to get it clearer in your head what you actually want to achieve.

Don't put user input straight into your email headers, that's a sure-fire way of inviting problems. I find it better to leave something generic in the actual headers, and let the user input form the message part only. You can validate the user email to determine if it's safe to use in a header, but judging from your code, I think it would be safer for now to avoid putting this kind of thing in the headers entirely.

You're not checking to see if the server actually sent your email. The PHP function mail() does have a return value, you should use it. Also, sending does not guarantee it will be received. A lot of email servers block incoming mail that says it's from someone it doesn't appear to be.

bradgrafelman

Ashley Sheridan;11014865 wrote:
You're not checking to see if the server actually sent your email.

True, but that's probably because it's impossible to do so. 😉

Ashley_Sheridan

bradgrafelman;11014883 wrote:
True, but that's probably because it's impossible to do so. 😉

I should have really said "checked to see if PHP sent the email to the mail queue", but the general idea still stands :-p