[RESOLVED] Live search with $_GET in the url

[SeanKann]

I'm using W3 Schools AJAX and mySQL example here http://www.w3schools.com/php/php_ajax_database.asp

What I have is a table that has different club_id for different venues I deal with ranging from 1-6

So I need to have a way to search the database with the $club_id option

My sql statement is the following.

$club_id=$_GET["club_id"];
$q=$_GET["q"];

$query=mysql_query("SELECT * FROM $table WHERE location_name LIKE '%$%' AND club_id = '$club_id'");

while($row=mysql_fetch_array($query))
{
echo "" .$row['location_name']. "<br>";
}

Now if I take out the AND club_id = '$club_id' option it works fine. But with my site I have example index.php?club_id=2

So I need to be able to only pull the results for club_id=2. But it's not letting me with the livesearch. I have done some changes to the javascript file but again it still works with out the club_id option

Here is my javascript file

var xmlHttp;
function showLocation(str)
{
xmlHttp=GetXmlHttpObject();
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request");
 return;
 }
var url="search.php";
url=url+"?q="+str;
url=url+"&sid="+Math.random();
xmlHttp.onreadystatechange=stateChanged;
xmlHttp.open("GET",url,true);
xmlHttp.send(null);
}
function stateChanged()
{
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 {
 document.getElementById("result").innerHTML=xmlHttp.responseText;
 }
}
function GetXmlHttpObject()
{
var xmlHttp=null;
try
 {
 // Firefox, Opera 8.0+, Safari
 xmlHttp=new XMLHttpRequest();
 }
catch (e)
 {
 //Internet Explorer
 try
  {
  xmlHttp=new ActiveXObject("Msxml2.XMLHTTP");
  }
 catch (e)
  {
  xmlHttp=new ActiveXObject("Microsoft.XMLHTTP");
  }
 }
return xmlHttp;
}

I have also tried adding to the search.php to see if the club_id would pass but it won't.

Is there another way to do this? I just want to have the option to search 1 field in my table and return it back so I can link it to another page

Thoughts?

TIA

[bradgrafelman]

SeanKann;11015551 wrote:

I'm using W3 Schools

Yikes! Might want to stop now, lest you become a W3Fool!

SeanKann;11015551 wrote:

My sql statement is the following.

$club_id=$_GET["club_id"];
$q=$_GET["q"];

$query=mysql_query("SELECT * FROM $table WHERE location_name LIKE '%$%' AND club_id = '$club_id'");

while($row=mysql_fetch_array($query))
{
echo "" .$row['location_name']. "<br>";
}

Few things I see wrong here:

1. The entire [man]mysql[/man] extension has been outdated for quite some time and is officially deprecated in favor of newer extensions like [man]MySQLi[/man] or [man]PDO[/man]. See [man]mysqlinfo.api.choosing[/man] for more info.

2. User-supplied data should never be placed directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize the data (such as by using [man]mysqli_real_escape_string/man for string data) or use prepared statements.

3. It sounds like this club_id field is used to hold numeric data. If that's true, then I would expect both 1) the column to be defined using a numeric type, and 2) you to treat it as numeric column (e.g. you don't compare it with strings). However, #2 (and perhaps #1?) isn't true.

SeanKann;11015551 wrote:

So I need to be able to only pull the results for club_id=2. But it's not letting me with the livesearch. I have done some changes to the javascript file but again it still works with out the club_id option

What are these changes, and why haven't you shown them to us? The JS code you posted above isn't even attempt to send any "club_id" value in the query string (let alone the correct club_id, whatever that may be).

[SeanKann]

Here is where I made the changes in the javascript

var url="search.php";
url=url+"?q="+str;

I tried adding to the search.php?club_id=$club_id&
and on the ?q I tried putting club_id=$club_id&?q

Still nothing. No errors show. When I type in the input box nothing happens.

This page that I'm currently working on is still testing phase so I'm trying to figure out where the issues is before I change everything around.

With out the club_id option I can't sort out my data for the certain club page that it's on. I don't want to search the whole database just that club_id.

[bradgrafelman]

Can you show us the exact Javascript code you came up with after you attempted to add the "club_id" query string parameter?

[SeanKann]

bradgrafelman;11015573 wrote:

Can you show us the exact Javascript code you came up with after you attempted to add the "club_id" query string parameter?

Here is what I tried to see if it would work but didn't

var xmlHttp;
function showLocation(str)
{
xmlHttp=GetXmlHttpObject();
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request");
 return;
 }
var url="search.php?club_id=$club_id&";
url=url+"q="+str;
url=url+"&sid="+Math.random();
xmlHttp.onreadystatechange=stateChanged;
xmlHttp.open("GET",url,true);
xmlHttp.send(null);
}
function stateChanged()
{
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 {
 document.getElementById("result").innerHTML=xmlHttp.responseText;
 }
}
function GetXmlHttpObject()
{
var xmlHttp=null;
try
 {
 // Firefox, Opera 8.0+, Safari
 xmlHttp=new XMLHttpRequest();
 }
catch (e)
 {
 //Internet Explorer
 try
  {
  xmlHttp=new ActiveXObject("Msxml2.XMLHTTP");
  }
 catch (e)
  {
  xmlHttp=new ActiveXObject("Microsoft.XMLHTTP");
  }
 }
return xmlHttp;
}

and

var xmlHttp;
function showLocation(str)
{
xmlHttp=GetXmlHttpObject();
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request");
 return;
 }
var url="search.php";
url=url+"?club_id=$club_id&q="+str;
url=url+"&sid="+Math.random();
xmlHttp.onreadystatechange=stateChanged;
xmlHttp.open("GET",url,true);
xmlHttp.send(null);
}
function stateChanged()
{
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 {
 document.getElementById("result").innerHTML=xmlHttp.responseText;
 }
}
function GetXmlHttpObject()
{
var xmlHttp=null;
try
 {
 // Firefox, Opera 8.0+, Safari
 xmlHttp=new XMLHttpRequest();
 }
catch (e)
 {
 //Internet Explorer
 try
  {
  xmlHttp=new ActiveXObject("Msxml2.XMLHTTP");
  }
 catch (e)
  {
  xmlHttp=new ActiveXObject("Microsoft.XMLHTTP");
  }
 }
return xmlHttp;
}

[bradgrafelman]

Well neither modifications makes sense, since you're setting the "club_id" query string parameter to a dollar sign followed by "club_id".

Where is this "club_id" value supposed to come from?

[SeanKann]

from the url.

I have my url set at example index.php?club_id=3

[bradgrafelman]

SeanKann;11015597 wrote:

from the url.

You mean it's in the URL of the page that contains the Javascript you posted above?

If so, then you need to pass that value along in the Javascript code rather than passing a literal dollar sign followed by "club_id".

[SeanKann]

ya but it's not always 3. It can change based off of what you click on the main page. could be 1 6 10

[bradgrafelman]

... which is exactly why you need to:

bradgrafelman;11015601 wrote:

pass that value along in the Javascript code rather than passing a literal dollar sign followed by "club_id".