[RESOLVED] Optimizing the Handling of Multiple File Uploads

[rsmith]

I have several functions that process a form that has multiple file uploads. Right now I'm doing everything long-handed.

Snippet 1: Calculate File Size of uploads

// Get the grand total file size of all uploaded files
	$total_size = $_FILES['multi']['size'][0] + $_FILES['multi']['size'][1] + $_FILES['multi']['size'][2] + $_FILES['multi']['size'][3] + $_FILES['multi']['size'][4];

if($total_size <= 0){
	$error_count++;
	array_push($errors, "No file selected");
}elseif($total_size > 26214400){
	$error_count++;
	array_push($errors, "Total combined file size exceeds 25mb limit");
}

Snippet 2: Move the uploaded files (I have a code block for each file)

// Move File 1
	if($_FILES['multi']['size'][0] > 0){
		if(!move_uploaded_file($_FILES['multi']['tmp_name'][0], "/uploads/".$_FILES['multi']['name'][0]."")){
			die("Could not move File 1");
		}
	}

I'm looking for a way of optimizing this so that if I decide to add more file upload inputs I'm not repeating addition functions or code blocks. I'm sure a foreach loop is the answer but I can't quite get it.

[bradgrafelman]

rsmith;11018487 wrote:

I'm sure a foreach loop is the answer but I can't quite get it.

What have you tried? Also, have you seen this example in the PHP manual?

By the way, this might be irrelevant if you use a foreach() loop to process each file upload, but if you wanted to immediately know the "total size", you could simply use [man]array_sum/man on the array at the 'size' index.

[rsmith]

Brad,
Thanks for the link to that article, I will see if I can make it work. As for the array_sum, the examples I found don't use a named index so would it be something like this:

array_sum($_FILES['multi']['size']);

[Weedpacket]

(a) You could try it.
(b) An array of numbers is an array of numbers whatever name you use to refer to it (such as [font=monospace]$_FILES['multi']['size'][/font]).

[rsmith]

Well I found a method of handling this. For calculating the sizes I ended up doing:

$total_size = 0;

foreach($_FILES['multi']['size'] as $fs){
     $total_size = $total_size + $fs;
}

And for the other functions it was just a matter of using a similar foreach() loop and putting the processing code into it.

[Derokorian]

Note: You could have simply done:

$total_size = array_sum($_FILES['multi']['size']);

[rsmith]

I tried that, it didn't work in that total_size never changed from 0.

[Derokorian]

Really? that's just weird...

[johanafm]

First off, have a look at what you really get before you try to do anything else. After you check that form has been submitted, try this output

printf('<pre>%s</pre>', print_r($_FILES, 1));

Several things might prevent your multi file upload:
name attributes aren't specified to be an array
max_file_upload or whatever it's called is set to 1
max_size_something < what you tried

Also note that apart from trying to sum file sizes, checking for errors first is a very good idea. Iterate over
$_FILES['files']['errors']
and unset those with error value other than 0, while of course first moving their filenames to some other array so you can inform the user which files weren't uploaded.