Too few arguments

[dcjones]

Hi all,

I have an issue with an sqlo statement, can any one see where I have gone wrong:

The error I am getting is:

Warning: sprintf(): Too few arguments in /home/vhosts/mydomain/httpdocs/cms/modules/iclean/index.php on line 85 Query was empty

$colname_Inspections = "-1";
if (isset($_SESSION['member_id'])) {
  $colname_Inspections = $_SESSION['member_id'];
}
mysql_select_db($database_flightq, $flightq);

$query_Inspections = sprintf("SELECT  InspectAuditedby, InspectRoomNo, DATE_FORMAT(InspectDate, '%m/%d/%Y') FROM RoomAuditResult WHERE InspectDate BETWEEN CURDATE() - INTERVAL 30 DAY AND CURDATE() ORDER BY InspectDate ASC", GetSQLValueString($colname_Inspections, "int"));

$Inspections = mysql_query($query_Inspections, $flightq) or die(mysql_error());
$row_Inspections = mysql_fetch_assoc($Inspections);
$totalRows_Inspections = mysql_num_rows($Inspections);

[bradgrafelman]

Your use of [man]sprintf/man doesn't make much sense. You've got three placeholders in your format string, yet you're only passing one argument after the string (the return value from GetSQLValueString()). Furthermore, two of the placeholders - '%m' and '%Y' - don't make sense since they will never output anything ('m' and 'Y' are not valid type specifiers as denoted in the PHP manual).

EDIT: Almost forgot the obligatory: Stop Using the MySQL Extension!

[johanafm]

bradgrafelman;11020241 wrote:

You've got three placeholders in your format string (…) two of the placeholders - '%m' and '%Y'

While definitely correct when reading his string, I'm guessing that he has no placeholders and three syntax errros. Those bove should be %%m, %%Y, while the third then is %%d.

bradgrafelman;11020241 wrote:

EDIT: Almost forgot the obligatory: Stop Using the MySQL Extension!

+1