draw_table help

msnhockey

i have a certain code i been using to draw my tables, but now after a while I am wondering if there is a way to set the width of the columns using the code i have or if i need to
rework what i have done.

here is my code and i have put some text in red to help out hopefully


[COLOR="#FF0000"]This bit here gathers the info to be displayed[/COLOR]
        $injuries .= draw_table(array(
            'title' => $row['name'],
            'title_color' => '#FFFFFF',
            'headers' => array('Player','Date','Status','Injury'),  [COLOR="#FF0000"]This is what i want to set the column width on[/COLOR]
            'fields' => $fields,
            'bgtitle' => '#484F53',
            'footer' => array(array('No Current Injuries')),
            'footer_span' => '4',
            'bgheaders' => '#BD2414',
            'bgcolors' => array('#EFEFEF', '#DFDFDF')
        ));
    }
    mysql_free_result($result);

$contents = eregi_replace("<!--%LEAGUE_TITLE%-->", $league_name, $contents);
$contents = eregi_replace("<!--%INFO%-->", $injuries, $contents);

return $contents;

}


[COLOR="#FF0000"]This displays the stuff from what we gathered from above[/COLOR]
function draw_table($o){
    $result = '<table bgcolor="'.$o['bgtitle'].'" width="100%" border="0" cellspacing="0" cellpadding="0" align="center">'.
              '<tr>'.
              '    <td bgcolor="#FFFFFF">'.
              '        <table border="0" width="100%" cellpadding="2" bordercolor="'.$o['bgtitle'].'" cellspacing="1">'.
              '            <tr align="center" bgcolor="#efefef">'.
              '                <td bgcolor="'.$o['bgtitle'].'" colspan="'.count((isset($o['headers']) ? $o['headers'] : $o['fields'][0])).'" class="table_header" align="left"><font color="'.(isset($o['title_color']) ? $o['title_color'] : '#000000').'">'.$o['title'].'</font></td>'.
              '            </tr>';
    if ($o['headers']){
        $result .= '<tr bgcolor="'.$o['bgheaders'].'" align="center" >';
        foreach($o['headers'] as $h){
            $result .= '<td class="table_header" width="$o['headers_width']">'.$h.'</td>';
        }
        $result .= '</tr>';
    }
    if ($o['fields']){
        $i = 0;
        foreach($o['fields'] as $f){
            $result .= '<tr bgcolor="'.($i%2 == 0 ? $o['bgcolors'][0] : $o['bgcolors'][1]).'" align="left">';
            foreach($f as $v){
                $result .= '<td class="table_text" '.(count($f) == 1 ? 'colspan="'.count((isset($o['headers']) ? $o['headers'] : $o['fields'][0])).'"' : '').'>'.($v != '' ? $v : '0').'</td>';
            }
            $result .= '</tr>';
            $i++;
        }
    }
    if ($o['footer'] && !$o['fields']){
        $fi = 0;
        foreach($o['footer'] as $f){
            $first_time = 1;
            $result .= '<tr bgcolor="'.($o['footer_color'] ? (is_string($o['footer_color']) ? $o['footer_color'] : $o['footer_color'][$fi]) : $o['bgtitle']).'" align="center">';
            foreach($f as $v){
                $result .= '<td '.($first_time ? 'colspan="'.(is_string($o['footer_span']) ? $o['footer_span'] : $o['footer_span'][$fi]).'"' : '').' class="table_text"><b><font color="'.(isset($o['title_color']) && $fi == 0 ? $o['title_color'] : '#000000').'">'.($v != '' ? $v : '0').'</font></b></td>';
                $first_time = 0;
            }
            $result .= '</tr>';
            $fi++;
        }
    }
    return $result.'</table></td></tr></table><br />';    

}

bpat1434

I would suggest reworking it anyway to use the <thead> and <tbody> and even <tfooter> elements so you can separate your header from your content instead of having a table within a table.

You could also use the <col> or <colgroup> tags to set the widths of the columns. So add another element to your $o parameter which is "column_widths" and when you iterate over the headers see if the value in the "column_widths" parameter for the same index as the current header is set, and if so, use <col> to set the width/height/style.

Weedpacket

Not directly related to the question, but:

    $contents = eregi_replace("<!--%LEAGUE_TITLE%-->", $league_name, $contents);
    $contents = eregi_replace("<!--%INFO%-->", $injuries, $contents);

These functions have been deprecated since PHP 5.3.0 (and have been outdated for several years, so even though this is clearly very old code it probably isn't that old). They have been supersceded by [man]preg_replace[/man]. (And while I'm on the subject of deprecation, so has [man]mysql_free_result[/man] and the rest of that extension.)

In fact - since there is no regular-expression stuff being used - [man]str_ireplace[/man] would be adequate for the task.

In fact - unless someone has been sloppy writing the template and wrote something like [font=monospace][/font] - [man]str_replace[/man] would have been the most appropriate function all along.

And both [man]str_replace[/man] and [man]str_ireplace[/man] can take arrays of search/replace pairs.

msnhockey

yea this was in the script when i originally got it

    $contents = eregi_replace("<!--%LEAGUE_TITLE%-->", $league_name, $contents);
     $contents = eregi_replace("<!--%INFO%-->", $injuries, $contents);

I will look at changing that

all the other stuff i thought was new since a coder helped me do it that way about 6 months ago. i will read up on your examples first and try some stuff before asking more questions on this..

thanks for replies so far