[RESOLVED] Help with undefined variables? :S

croatiangrn

So here are the errors that are showing on my browser:
Notice: Undefined variable: send in C:\xampp\htdocs\vicevi.php on line 34
Notice: Undefined variable: PHP_SELF in C:\xampp\htdocs\vicevi.php on line 63
And, here's the code

<HTML>
<link rel="stylesheet" href="vicevi.css" type="text/css">
<BODY>
<?php
// Ako korisnik zeli da doda vic
if (isset($dodajvic)):
?>
<FORM ACTION=.$_SERVER['PHP_SELF']; ?>" METHOD=POST>
<P>Upis vic:<BR>
<TEXTAREA NAME="victext" ROWS=10 COLS=40 WRAP>
</TEXTAREA><BR>
<INPUT TYPE=SUBMIT NAME="send" VALUE="SUBMIT">
</FORM>
</BODY>
</HTML>
<?php
	else:
// Povezivanje sa bazom na serveru
$dbcnx = @mysql_connect("localhost",
"Vicevi", "markomarko");
if (!$dbcnx) {
echo( "<P>Trenutno nije moguce " .
"ostvariti konekciju sa bazom.</P>" );
exit();
}
// Biramo bazu vicevi
if (! @mysql_select_db("Vicevi") ) {
echo( "<P>Trenutno nije moguce " .
"pristupiti bazi vicevi.</P>" );
exit();
}
// Ako je vic poslat,
// dodajemo ga u bazu.
if ("SUBMIT" == $send) {
$sql = "INSERT INTO Vicevi SET " .
"VicText='$victext', " .
"VicDate=CURDATE()";
if (mysql_query($sql)) {
echo("<P> Tvoj vic je upisan u bazu.</P>");
} else {
echo("<P>Greska: " .
mysql_error() . "</P>");
}
}
echo("<P> Ovo su vicevi koji " .
" se nalaze u nasoj bazi: </P>");
// Zahtevamo ispis svih viceva iz baze
$result = mysql_query(
"SELECT VicText FROM Vicevi");
if (!$result) {
echo("<P>Greska: " .
mysql_error() . "</P>");
exit();
}
// Ispisujemo sve viceve iz baze na web stranu
while ( $row = mysql_fetch_array($result) ) {
echo("<div class='line-separator' />");
echo("<P>" . $row["VicText"] . "</P>");
echo("<div class='line-separator' />");
}
//Kada korisnik klikne na ovaj link
// otvori mu se strana za upisivanje viceva.
echo("<P><A HREF='$PHP_SELF?dodajvic=1'>" .
"Dodaj viv!</A></P>");
endif;
?>

Help, I'm new in php and mysql stuff

traq

Just read the error messages - they describe exactly what the problem is.

Go to the lines they reference and look for the problems they mention:

croatiangrn;11022721 wrote:
Notice: Undefined variable: send in C:\xampp\htdocs\vicevi.php on line 34

That's this line:

if ("SUBMIT" == $send) {

You don't define [font=monospace]$send[/font] before you try to use it here (hence the notice about it being "undefined").
As a side note, an undefined variable has the value of [font=monospace]null[/font], so this condition will fail.

croatiangrn;11022721 wrote:
Notice: Undefined variable: PHP_SELF in C:\xampp\htdocs\vicevi.php on line 63

And that line is here:

echo("<P><A HREF='$PHP_SELF?dodajvic=1'>" .

Same deal. Here, at least, I would suspect that you intended to write [font=monospace]$_SERVER['PHP_SELF'][/font].

[edit] An unrelated suggestion:

...format / indent your code and use the

 BBCode tags in your post.

...use the standard[B] if(){ /* code */ }else{ /* code */ }[/B] syntax for control structures, 
and avoid the alternate [B]if(): /* code */ else: /* code */ endif;[/B] syntax.
It's much easier to follow, and less error-prone.[/I]

Bonesnap

traq;11022723 wrote:
and avoid the alternate if(): / code / else: / code / endif; syntax.

I hate that syntax. It's rampant in a lot of WordPress source code and plugins. There's no discernible advantage to it that I can see, and Komodo Edit (and I'll assume other IDEs/editors) doesn't pick up on the colons/endif.

Derokorian

Komodo edit matches up the alternate syntax just fine for me. Personally I prefer to use it in templates, while I prefer braces in "real" code.

traq

Bonesnap;11022879 wrote:
I hate that syntax. It's rampant in a lot of WordPress source code and plugins. There's no discernible advantage to it that I can see, and Komodo Edit (and I'll assume other IDEs/editors) doesn't pick up on the colons/endif.

that's exactly where I know it from. It's the cause of all kinds of problems when people modify their WP stuff because they lose track of where the "block" is; plus it makes it close-to-impossible to even figure out what they did, or were trying to do.

Bonesnap

Derokorian;11022881 wrote:
Komodo edit matches up the alternate syntax just fine for me. Personally I prefer to use it in templates, while I prefer braces in "real" code.

Really? Mine certainly doesn't (I'm running 7.1.3). When I put the cursor next to the colon, it doesn't highlight the colon or where the endif or else is. If I put my cursor next to the brace in a real if-else block, it highlights the closing brace without fail, even if there's HTML or whatever in between.

Using ctrl-b to select the block doesn't seem to work so well either.

Is there something else in the fonts and colours section that addresses this?